[lldb] Remove use of comma operator (NFC) (llvm#131233)

kastiglione · web-flow · commit 8705e489dc17 · 2025-03-16T08:41:55.000-07:00
No reason for the comma operator, make this more conventional with two statements.
diff --git a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp b/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
@@ -362,7 +362,9 @@ lldb::ValueObjectSP ValueObjectSynthetic::GetNonSyntheticValue() {
 }
 
 void ValueObjectSynthetic::CopyValueData(ValueObject *source) {
-  m_value = (source->UpdateValueIfNeeded(), source->GetValue());
+  if (!source->UpdateValueIfNeeded())
+    return;
+  m_value = source->GetValue();
   ExecutionContext exe_ctx(GetExecutionContextRef());
   m_error = m_value.GetValueAsData(&exe_ctx, m_data, GetModule().get());
 }

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,9 @@ lldb::ValueObjectSP ValueObjectSynthetic::GetNonSyntheticValue() {`
`362`	`362`	`}`
`363`	`363`
`364`	`364`	`void ValueObjectSynthetic::CopyValueData(ValueObject *source) {`
`365`		`- m_value = (source->UpdateValueIfNeeded(), source->GetValue());`
	`365`	`+ if (!source->UpdateValueIfNeeded())`
	`366`	`+ return;`
	`367`	`+ m_value = source->GetValue();`
`366`	`368`	`ExecutionContext exe_ctx(GetExecutionContextRef());`
`367`	`369`	`m_error = m_value.GetValueAsData(&exe_ctx, m_data, GetModule().get());`
`368`	`370`	`}`