RuntimeLibcalls: Fix missing const on getLibcallNames (llvm#143074)

arsenm · web-flow · commit 94384ae2bd08 · 2025-06-06T23:11:02.000+09:00
This is made simpler by just returning the array ref instead of
the fancy range.
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.h b/llvm/include/llvm/IR/RuntimeLibcalls.h
@@ -81,9 +81,9 @@ struct RuntimeLibcallsInfo {
     return LibcallCallingConvs[Call];
   }
 
-  iterator_range<const char **> getLibcallNames() {
-    return llvm::make_range(LibcallRoutineNames,
-                            LibcallRoutineNames + RTLIB::UNKNOWN_LIBCALL);
+  ArrayRef<const char *> getLibcallNames() const {
+    // Trim UNKNOWN_LIBCALL from the end
+    return ArrayRef(LibcallRoutineNames).drop_back();
   }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,9 @@ struct RuntimeLibcallsInfo {`
`81`	`81`	`return LibcallCallingConvs[Call];`
`82`	`82`	`}`
`83`	`83`
`84`		`- iterator_range<const char **> getLibcallNames() {`
`85`		`- return llvm::make_range(LibcallRoutineNames,`
`86`		`- LibcallRoutineNames + RTLIB::UNKNOWN_LIBCALL);`
	`84`	`+ ArrayRef<const char *> getLibcallNames() const {`
	`85`	`+ // Trim UNKNOWN_LIBCALL from the end`
	`86`	`+ return ArrayRef(LibcallRoutineNames).drop_back();`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`private:`