Revert "YAML: Don't parse Y/N as booleans"

This reverts commit a9f2382.

Change-Id: I9e838b53d1f2374ad0721f5ee1a80e245ca7848c

Author: shiltian

clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp

@@ -340,9 +340,8 @@ TEST(CheckOptionsValidation, ValidIntOptions) {
   CheckOptions["test.BoolIFalseValue"] = "0";
   CheckOptions["test.BoolTrueValue"] = "true";
   CheckOptions["test.BoolFalseValue"] = "false";
-// FIXME: SWDEV-268185.
-//  CheckOptions["test.BoolTrueShort"] = "Y";
-//  CheckOptions["test.BoolFalseShort"] = "N";
+  CheckOptions["test.BoolTrueShort"] = "Y";
+  CheckOptions["test.BoolFalseShort"] = "N";
   CheckOptions["test.BoolUnparseable"] = "Nothing";
 
   ClangTidyContext Context(std::make_unique<DefaultOptionsProvider>(
@@ -364,9 +363,8 @@ TEST(CheckOptionsValidation, ValidIntOptions) {
   CHECK_VAL(TestCheck.getIntLocal<bool>("BoolIFalseValue"), false);
   CHECK_VAL(TestCheck.getIntLocal<bool>("BoolTrueValue"), true);
   CHECK_VAL(TestCheck.getIntLocal<bool>("BoolFalseValue"), false);
-// FIXME: SWDEV-268185.
-//  CHECK_VAL(TestCheck.getIntLocal<bool>("BoolTrueShort"), true);
-//  CHECK_VAL(TestCheck.getIntLocal<bool>("BoolFalseShort"), false);
+  CHECK_VAL(TestCheck.getIntLocal<bool>("BoolTrueShort"), true);
+  CHECK_VAL(TestCheck.getIntLocal<bool>("BoolFalseShort"), false);
   EXPECT_FALSE(TestCheck.getIntLocal<bool>("BoolUnparseable"));
 
   EXPECT_THAT(

llvm/lib/Support/YAMLParser.cpp

@@ -770,18 +770,17 @@ std::string yaml::escape(StringRef Input, bool EscapePrintable) {
 
 std::optional<bool> yaml::parseBool(StringRef S) {
   switch (S.size()) {
-// FIXME: SWDEV-268185.
-//  case 1:
-//    switch (S.front()) {
-//    case 'y':
-//    case 'Y':
-//      return true;
-//    case 'n':
-//    case 'N':
-//      return false;
-//    default:
-//      return None;
-//    }
+  case 1:
+    switch (S.front()) {
+    case 'y':
+    case 'Y':
+      return true;
+    case 'n':
+    case 'N':
+      return false;
+    default:
+      return std::nullopt;
+    }
   case 2:
     switch (S.front()) {
     case 'O':

llvm/unittests/Support/YAMLParserTest.cpp

@@ -419,9 +419,8 @@ TEST(YAMLParser, ParsesBools) {
   expectCanParseBool("TRUE", true);
   expectCanParseBool("True", true);
   expectCanParseBool("true", true);
-// FIXME: SWDEV-268185.
-//  expectCanParseBool("Y", true);
-//  expectCanParseBool("y", true);
+  expectCanParseBool("Y", true);
+  expectCanParseBool("y", true);
   expectCanParseBool("YES", true);
   expectCanParseBool("Yes", true);
   expectCanParseBool("yes", true);
@@ -431,9 +430,8 @@ TEST(YAMLParser, ParsesBools) {
   expectCanParseBool("FALSE", false);
   expectCanParseBool("False", false);
   expectCanParseBool("false", false);
-// FIXME: SWDEV-268185.
-//  expectCanParseBool("N", false);
-//  expectCanParseBool("n", false);
+  expectCanParseBool("N", false);
+  expectCanParseBool("n", false);
   expectCanParseBool("NO", false);
   expectCanParseBool("No", false);
   expectCanParseBool("no", false);