Skip to content

Commit d0a48e9

Browse files
committed
SWDEV-355608 - deprecate a few hipcc-only options
1 parent 9d3864f commit d0a48e9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

amd/hipcc/src/hipBin_amd.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,10 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
656656
// match arg with the starting of targetOpt
657657
string pattern = "^" + targetOpt + ".*";
658658
if (hipBinUtilPtr_->stringRegexMatch(arg, pattern)) {
659+
if (targetOpt == "--amdgpu-target=") {
660+
cout << "Warning: The --amdgpu-target option has been deprecated and will be removed in the future."
661+
<< " Use --offload-arch instead.\n";
662+
}
659663
// If targets string is not empty,
660664
// add a comma before adding new target option value.
661665
targetsStr.size() >0 ? targetsStr += ",": targetsStr += "";
@@ -703,6 +707,8 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
703707
}
704708
if (hipBinUtilPtr_->substringPresent(
705709
arg, "--amdhsa-code-object-version=")) {
710+
cout << "Warning: The --amdhsa-code-object-version option has been deprecated and will be removed in the future."
711+
<< " Use -mllvm -mcode-object-version instead.\n";
706712
arg = hipBinUtilPtr_->replaceStr(
707713
arg, "--amdhsa-code-object-version=", "");
708714
hsacoVersion = arg;
@@ -915,12 +921,11 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
915921
//# Process HIPCC options here:
916922
if (hipBinUtilPtr_->stringRegexMatch(arg, "^--hipcc.*")) {
917923
swallowArg = 1;
918-
// if $arg eq "--hipcc_profile") { # Example argument here, hipcc
919-
//
920-
// }
921924
if (arg == "--hipcc-func-supp") {
925+
cout << "Warning: The --hipcc-func-supp option has been deprecated and will be removed in the future.\n";
922926
funcSupp = 1;
923927
} else if (arg == "--hipcc-no-func-supp") {
928+
cout << "Warning: The --hipcc-no-func-supp option has been deprecated and will be removed in the future.\n";
924929
funcSupp = 0;
925930
}
926931
} else {

0 commit comments

Comments
 (0)