Review comments

ronlieb · ronlieb · commit d3a2ee8930c7 · 2025-04-11T14:55:19.000-05:00
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -9476,9 +9476,8 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA,
         }
 
         if (!OOpt.empty() && OOpt != "0") {
-          CmdArgs.push_back(Args.MakeArgString(
-              "--device-linker=" + TC->getTripleString() +
-              "=--lto-newpm-passes=default<O" + OOpt + ">"));
+          LinkerArgs.push_back(
+            Args.MakeArgString("--lto-newpm-passes=default<O" + OOpt + ">"));
         }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -9476,9 +9476,8 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA,`
`9476`	`9476`	`}`
`9477`	`9477`
`9478`	`9478`	`if (!OOpt.empty() && OOpt != "0") {`
`9479`		`- CmdArgs.push_back(Args.MakeArgString(`
`9480`		`- "--device-linker=" + TC->getTripleString() +`
`9481`		`- "=--lto-newpm-passes=default<O" + OOpt + ">"));`
	`9479`	`+ LinkerArgs.push_back(`
	`9480`	`+ Args.MakeArgString("--lto-newpm-passes=default<O" + OOpt + ">"));`
`9482`	`9481`	`}`
`9483`	`9482`	`}`
`9484`	`9483`