Skip to content

Commit d951bec

Browse files
authored
[NFC][AArch64] Adjust predicate names to be more consistent (llvm#123172)
Some of the predicate names use `_or_`, some use plain `or`, some used `HasXXorHasXX`, some used `HasXX_or_XX`. Make these as consistent as possible.
1 parent 4b06b01 commit d951bec

File tree

5 files changed

+116
-116
lines changed

5 files changed

+116
-116
lines changed

llvm/lib/Target/AArch64/AArch64.td

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,34 +58,34 @@ include "AArch64SystemOperands.td"
5858

5959
class AArch64Unsupported { list<Predicate> F; }
6060

61-
let F = [HasSVE2p1, HasSVE2p1_or_HasSME2, HasSVE2p1_or_HasSME2p1] in
61+
let F = [HasSVE2p1, HasSVE2p1_or_SME2, HasSVE2p1_or_SME2p1] in
6262
def SVE2p1Unsupported : AArch64Unsupported;
6363

6464
def SVE2Unsupported : AArch64Unsupported {
65-
let F = !listconcat([HasSVE2, HasSVE2orSME, HasSVE2orSME2, HasSSVE_FP8FMA, HasSMEF8F16,
65+
let F = !listconcat([HasSVE2, HasSVE2_or_SME, HasSVE2_or_SME2, HasSSVE_FP8FMA, HasSMEF8F16,
6666
HasSMEF8F32, HasSVEAES, HasSVE2SHA3, HasSVE2SM4, HasSVEBitPerm,
6767
HasSVEB16B16],
6868
SVE2p1Unsupported.F);
6969
}
7070

7171
def SVEUnsupported : AArch64Unsupported {
72-
let F = !listconcat([HasSVE, HasSVEorSME],
72+
let F = !listconcat([HasSVE, HasSVE_or_SME],
7373
SVE2Unsupported.F);
7474
}
7575

76-
let F = [HasSME2p2, HasSVE2p2orSME2p2, HasNonStreamingSVEorSME2p2,
77-
HasNonStreamingSVE2p2orSME2p2, HasNonStreamingSVE2orSSVE_BitPerm,
76+
let F = [HasSME2p2, HasSVE2p2_or_SME2p2, HasNonStreamingSVE_or_SME2p2,
77+
HasNonStreamingSVE2p2_or_SME2p2, HasNonStreamingSVE2_or_SSVE_BitPerm,
7878
HasSME_MOP4, HasSME_TMOP] in
7979
def SME2p2Unsupported : AArch64Unsupported;
8080

8181
def SME2p1Unsupported : AArch64Unsupported {
82-
let F = !listconcat([HasSME2p1, HasSVE2p1_or_HasSME2p1, HasNonStreamingSVE2p1orSSVE_AES],
82+
let F = !listconcat([HasSME2p1, HasSVE2p1_or_SME2p1, HasNonStreamingSVE2p1_or_SSVE_AES],
8383
SME2p2Unsupported.F);
8484
}
8585

8686
def SME2Unsupported : AArch64Unsupported {
87-
let F = !listconcat([HasSME2, HasSVE2orSME2, HasSVE2p1_or_HasSME2, HasSSVE_FP8FMA,
88-
HasSMEF8F16, HasSMEF8F32, HasSMEF16F16orSMEF8F16, HasSMEB16B16],
87+
let F = !listconcat([HasSME2, HasSVE2_or_SME2, HasSVE2p1_or_SME2, HasSSVE_FP8FMA,
88+
HasSMEF8F16, HasSMEF8F32, HasSMEF16F16_or_SMEF8F16, HasSMEB16B16],
8989
SME2p1Unsupported.F);
9090
}
9191

llvm/lib/Target/AArch64/AArch64InstrInfo.td

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -244,53 +244,53 @@ def HasOCCMO : Predicate<"Subtarget->hasOCCMO()">,
244244

245245
// A subset of SVE(2) instructions are legal in Streaming SVE execution mode,
246246
// they should be enabled if either has been specified.
247-
def HasSVEorSME
247+
def HasSVE_or_SME
248248
: Predicate<"Subtarget->hasSVE() || (Subtarget->isStreaming() && Subtarget->hasSME())">,
249249
AssemblerPredicateWithAll<(any_of FeatureSVE, FeatureSME),
250250
"sve or sme">;
251-
def HasNonStreamingSVEorSME2p2
251+
def HasNonStreamingSVE_or_SME2p2
252252
: Predicate<"(Subtarget->isSVEAvailable() && Subtarget->hasSVE()) ||"
253253
"(Subtarget->isSVEorStreamingSVEAvailable() && Subtarget->hasSME2p2())">,
254254
AssemblerPredicateWithAll<(any_of FeatureSVE, FeatureSME2p2),
255255
"sve or sme2p2">;
256-
def HasSVE2orSME
256+
def HasSVE2_or_SME
257257
: Predicate<"Subtarget->hasSVE2() || (Subtarget->isStreaming() && Subtarget->hasSME())">,
258258
AssemblerPredicateWithAll<(any_of FeatureSVE2, FeatureSME),
259259
"sve2 or sme">;
260-
def HasSVE2orSME2
260+
def HasSVE2_or_SME2
261261
: Predicate<"Subtarget->hasSVE2() || (Subtarget->isStreaming() && Subtarget->hasSME2())">,
262262
AssemblerPredicateWithAll<(any_of FeatureSVE2, FeatureSME2),
263263
"sve2 or sme2">;
264-
def HasNonStreamingSVE2orSSVE_AES
264+
def HasNonStreamingSVE2_or_SSVE_AES
265265
: Predicate<"(Subtarget->isSVEAvailable() && Subtarget->hasSVE2()) ||"
266266
"(Subtarget->isSVEorStreamingSVEAvailable() && Subtarget->hasSSVE_AES())">,
267267
AssemblerPredicateWithAll<(any_of FeatureSVE2, FeatureSSVE_AES), "sve2 or ssve-aes">;
268-
def HasSVE2p1_or_HasSME
268+
def HasSVE2p1_or_SME
269269
: Predicate<"Subtarget->hasSVE2p1() || (Subtarget->isStreaming() && Subtarget->hasSME())">,
270270
AssemblerPredicateWithAll<(any_of FeatureSME, FeatureSVE2p1), "sme or sve2p1">;
271-
def HasSVE2p1_or_HasSME2
271+
def HasSVE2p1_or_SME2
272272
: Predicate<"Subtarget->hasSVE2p1() || (Subtarget->isStreaming() && Subtarget->hasSME2())">,
273273
AssemblerPredicateWithAll<(any_of FeatureSME2, FeatureSVE2p1), "sme2 or sve2p1">;
274-
def HasSVE2p1_or_HasSME2p1
274+
def HasSVE2p1_or_SME2p1
275275
: Predicate<"Subtarget->hasSVE2p1() || (Subtarget->isStreaming() && Subtarget->hasSME2p1())">,
276276
AssemblerPredicateWithAll<(any_of FeatureSME2p1, FeatureSVE2p1), "sme2p1 or sve2p1">;
277-
def HasSVE2p2orSME2p2
277+
def HasSVE2p2_or_SME2p2
278278
: Predicate<"Subtarget->isSVEorStreamingSVEAvailable() && (Subtarget->hasSVE2p2() || Subtarget->hasSME2p2())">,
279279
AssemblerPredicateWithAll<(any_of FeatureSME2p2, FeatureSVE2p2), "sme2p2 or sve2p2">;
280-
def HasNonStreamingSVE2p1orSSVE_AES
280+
def HasNonStreamingSVE2p1_or_SSVE_AES
281281
: Predicate<"(Subtarget->isSVEAvailable() && Subtarget->hasSVE2p1()) ||"
282282
"(Subtarget->isSVEorStreamingSVEAvailable() && Subtarget->hasSSVE_AES())">,
283283
AssemblerPredicateWithAll<(any_of FeatureSVE2p1, FeatureSSVE_AES), "sve2p1 or ssve-aes">;
284-
def HasSMEF16F16orSMEF8F16
284+
def HasSMEF16F16_or_SMEF8F16
285285
: Predicate<"Subtarget->isStreaming() && (Subtarget->hasSMEF16F16() || Subtarget->hasSMEF8F16())">,
286286
AssemblerPredicateWithAll<(any_of FeatureSMEF16F16, FeatureSMEF8F16),
287287
"sme-f16f16 or sme-f8f16">;
288-
def HasNonStreamingSVE2p2orSME2p2
288+
def HasNonStreamingSVE2p2_or_SME2p2
289289
: Predicate<"(Subtarget->isSVEAvailable() && Subtarget->hasSVE2p2()) ||"
290290
"(Subtarget->isSVEorStreamingSVEAvailable() && Subtarget->hasSME2p2())">,
291291
AssemblerPredicateWithAll<(any_of FeatureSVE2p2, FeatureSME2p2),
292292
"sme2p2 or sve2p2">;
293-
def HasNonStreamingSVE2orSSVE_BitPerm
293+
def HasNonStreamingSVE2_or_SSVE_BitPerm
294294
: Predicate<"(Subtarget->isSVEAvailable() && Subtarget->hasSVE2()) ||"
295295
"(Subtarget->isSVEorStreamingSVEAvailable() && Subtarget->hasSSVE_BitPerm())">,
296296
AssemblerPredicateWithAll<(any_of FeatureSVE2, FeatureSSVE_BitPerm), "sve2 or ssve-bitperm">;

llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -882,7 +882,7 @@ defm LUTI4_S_2ZTZI : sme2p1_luti4_vector_vg2_index<"luti4">;
882882
defm LUTI4_S_4ZTZI : sme2p1_luti4_vector_vg4_index<"luti4">;
883883
}
884884

885-
let Predicates = [HasSMEF16F16orSMEF8F16] in {
885+
let Predicates = [HasSMEF16F16_or_SMEF8F16] in {
886886
defm FADD_VG2_M2Z_H : sme2_multivec_accum_add_sub_vg2<"fadd", 0b0100, MatrixOp16, ZZ_h_mul_r, nxv8f16, int_aarch64_sme_add_za16_vg1x2>;
887887
defm FADD_VG4_M4Z_H : sme2_multivec_accum_add_sub_vg4<"fadd", 0b0100, MatrixOp16, ZZZZ_h_mul_r, nxv8f16, int_aarch64_sme_add_za16_vg1x4>;
888888
defm FSUB_VG2_M2Z_H : sme2_multivec_accum_add_sub_vg2<"fsub", 0b0101, MatrixOp16, ZZ_h_mul_r, nxv8f16, int_aarch64_sme_sub_za16_vg1x2>;

0 commit comments

Comments
 (0)