[flang-new -> flang] Review comments

Author: ronlieb

clang/lib/Driver/ToolChain.cpp

@@ -428,9 +428,6 @@ static const DriverSuffix *FindDriverSuffix(StringRef ProgName, size_t &Pos) {
       {"cl", "--driver-mode=cl"},
       {"++", "--driver-mode=g++"},
       {"flang", "--driver-mode=flang"},
-      // For backwards compatibility, we create a symlink for `flang` called
-      // `flang`. This will be removed in the future.
-      {"flang", "--driver-mode=flang"},
       {"clang-dxc", "--driver-mode=dxc"},
   };
 

clang/tools/amdllvm/CMakeLists.txt

@@ -6,14 +6,8 @@ add_clang_tool(amdllvm
     amdllvm.cpp
 )
 
-option(CLANG_LINK_FLANG "Create flang install link to clang" ON)
-
 list(APPEND CLANG_LINKS_TO_CREATE clang clang++ clang-cl clang-cpp clang-${CLANG_VERSION_MAJOR} lld)
 
-if(CLANG_LINK_FLANG)
-    list(APPEND CLANG_LINKS_TO_CREATE flang flang)
-endif()
-
 foreach(link ${CLANG_LINKS_TO_CREATE})
     add_clang_symlink("amd${link}" amdllvm)
 endforeach()

flang-rt/CMakeLists.txt

@@ -27,7 +27,7 @@ set(FLANG_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../flang")
 # LLVM's requirement is only CMake 3.20, teach CMake 3.20-3.23 how to use Flang.
 if (CMAKE_VERSION VERSION_LESS "3.24")
   cmake_path(GET CMAKE_Fortran_COMPILER STEM _Fortran_COMPILER_STEM)
-  if (_Fortran_COMPILER_STEM STREQUAL "flang" OR _Fortran_COMPILER_STEM STREQUAL "flang")
+  if (_Fortran_COMPILER_STEM STREQUAL "flang")
     include(CMakeForceCompiler)
     CMAKE_FORCE_Fortran_COMPILER("${CMAKE_Fortran_COMPILER}" "LLVMFlang")
 

flang/include/flang/Optimizer/Analysis/AliasAnalysis.h

@@ -66,7 +66,7 @@ struct AliasAnalysis {
   //    a(1) = 1
   //  end subroutine
   //  -------------------------------------------------
-  // 
+  //
   //  flang -fc1 -emit-fir test.f90 -o test.fir
   //
   //  ------------------- test.fir --------------------

flang/test/CMakeLists.txt

@@ -59,10 +59,6 @@ set(FLANG_TEST_PARAMS
 
 set(FLANG_TEST_DEPENDS
   flang
-  llvm-config
-  FileCheck
-  count
-  not
   module_files
   fir-opt
   tco