Skip to content

Commit 2a5595e

Browse files
akashveramdiupaikov-amdjeffdailymalfet
authored andcommitted
[release/2.7] Fix test_rnn_check_device tests for P1 Jira SWDEV-542659 (#2440)
This PR has fixes for P1 Jira https://ontrack-internal.amd.com/browse/SWDEV-542659. In this Jira, there are 3 test files with failing tests. 1) distributed.test_distributed_spawn 2) test_binary_ufuncs 3) test_nn The test files **distributed.test_distributed_spawn** & **test_binary_ufuncs** are passing with latest mainline build- **registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16426_ubuntu22.04_py3.10_pytorch_lw_release-2.7_fe3d37a9**. The test file **test_nn** has 2 failing tests- **test_batchnorm_3D_train_NCHW_vs_native_mixed_float16** & **test_RNN_dropout_state**. The **test_batchnorm_3D_train_NCHW_vs_native_mixed_float16** test is skipped from PR #2370. The **test_RNN_dropout_state** is fixed by cherry picking upstream commit 1aa971a. Tested on MI200 with docker image- **registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16426_ubuntu22.04_py3.10_pytorch_lw_release-2.7_fe3d37a9**. --------- Co-authored-by: Iurii Paikov <[email protected]> Co-authored-by: Jeff Daily <[email protected]> Co-authored-by: Nikita Shulga <[email protected]>
1 parent ab27a01 commit 2a5595e

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

aten/src/ATen/miopen/Descriptors.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,11 @@ struct TORCH_CUDA_CPP_API ConvolutionDescriptor
120120
}
121121
};
122122

123-
// NOLINTNEXTLINE(bugprone-exception-escape)
124-
struct TORCH_CUDA_CPP_API DropoutDescriptor
125-
: public Descriptor<
126-
miopenDropoutDescriptor,
127-
&miopenCreateDropoutDescriptor,
128-
&miopenDestroyDropoutDescriptor> {
123+
struct DropoutDescriptor
124+
: public Descriptor<miopenDropoutDescriptor,
125+
&miopenCreateDropoutDescriptor,
126+
&miopenDestroyDropoutDescriptor>
127+
{
129128
void set(miopenHandle_t handle, float dropout, void* states, size_t stateSizeInBytes,
130129
unsigned long long seed, bool use_mask, bool state_evo, miopenRNGType_t rng_mode) {
131130
MIOPEN_CHECK(miopenSetDropoutDescriptor(mut_desc(), handle, dropout, states, stateSizeInBytes, seed, use_mask, state_evo, rng_mode));

0 commit comments

Comments
 (0)