Commit 36e59d9
[c10d][nvshmem] fix missing override compilation error for nvshmem symmetric code (pytorch#159557)
Summary:
Fix error when compiling nvshmem code section `NVSHMEMSymmetricMemory.cu` with BUCK
```
fbcode/caffe2/torch/csrc/distributed/c10d/symm_mem/NVSHMEMSymmetricMemory.cu:154:20: error: 'get_buffer' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
154 | virtual at::Tensor get_buffer(int
| ^
fbcode/caffe2/torch/csrc/distributed/c10d/symm_mem/SymmetricMemory.hpp:56:20: note: overridden virtual function is here
56 | virtual at::Tensor get_buffer(int rank, c10::IntArrayRef sizes, c10::ScalarType dtype, int64_t storage_offset) = 0;
```
Test Plan:
Build test + CI
Rollback Plan:
Differential Revision: D78813586
Pull Request resolved: pytorch#159557
Approved by: https://github.com/kwen25011 parent fc340d0 commit 36e59d9
File tree
1 file changed
+1
-1
lines changed- torch/csrc/distributed/c10d/symm_mem
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| |||
0 commit comments