Skip to content

Commit 7d854fd

Browse files
authored
find rocm version
1 parent c126ff5 commit 7d854fd

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

aten/src/ATen/CMakeLists.txt

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,22 @@
11
cmake_minimum_required(VERSION 3.27 FATAL_ERROR)
22
set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
33

4+
set(_rocm_ver "")
5+
if(DEFINED ROCM_VERSION AND ROCM_VERSION)
6+
set(_rocm_ver "${ROCM_VERSION}")
7+
elseif(DEFINED HIP_VERSION AND HIP_VERSION)
8+
set(_rocm_ver "${HIP_VERSION}")
9+
else()
10+
# Fall back to hipconfig --version
11+
find_program(HIPCONFIG_EXECUTABLE hipconfig HINTS ENV ROCM_PATH /opt/rocm/bin)
12+
if(HIPCONFIG_EXECUTABLE)
13+
execute_process(
14+
COMMAND ${HIPCONFIG_EXECUTABLE} --version
15+
OUTPUT_VARIABLE _rocm_ver
16+
OUTPUT_STRIP_TRAILING_WHITESPACE)
17+
endif()
18+
endif()
19+
420
if(NOT MSVC)
521
string(APPEND CMAKE_CXX_FLAGS " -Wno-ignored-qualifiers")
622
string(APPEND CMAKE_C_FLAGS " -Wno-ignored-qualifiers")
@@ -301,13 +317,16 @@ IF(USE_FBGEMM_GENAI)
301317

302318
# Add additional HIPCC compiler flags for performance
303319
set(FBGEMM_GENAI_EXTRA_HIPCC_FLAGS
304-
-mllvm
305-
-amdgpu-coerce-illegal-types=1
306320
-mllvm
307321
-enable-post-misched=0
308322
-mllvm
309323
-greedy-reverse-local-assignment=1
310324
-fhip-new-launch-api)
325+
if(_rocm_ver AND _rocm_ver VERSION_LESS "7.2.0")
326+
list(PREPEND FBGEMM_GENAI_EXTRA_HIPCC_FLAGS
327+
-mllvm
328+
-amdgpu-coerce-illegal-types=1)
329+
endif()
311330

312331
hip_add_library(
313332
fbgemm_genai STATIC

0 commit comments

Comments
 (0)