Skip to content

Commit 82da542

Browse files
ethanwee1jeffdaily
authored andcommitted
[release/2.9] remove amdgpu-coerce-illegal-types=1 (#2720)
Valdiation: http://rocm-ci.amd.com/job/mainline-pytorch2.9-manylinux-wheels/21/
1 parent 55b57b3 commit 82da542

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

aten/src/ATen/CMakeLists.txt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
cmake_minimum_required(VERSION 3.27 FATAL_ERROR)
22
set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
3+
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/public")
4+
if(USE_ROCM)
5+
include(LoadHIP OPTIONAL RESULT_VARIABLE _had_loadhip)
6+
if(_had_loadhip)
7+
# Exposed by LoadHIP.cmake, e.g. "7.1.2" or "7.2.0"
8+
message(STATUS "LoadHIP loaded: ROCM_VERSION_DEV='${ROCM_VERSION_DEV}'")
9+
else()
10+
message(WARNING "LoadHIP.cmake not found; ROCM_VERSION_DEV unavailable")
11+
endif()
12+
endif()
313

414
if(NOT MSVC)
515
string(APPEND CMAKE_CXX_FLAGS " -Wno-ignored-qualifiers")
@@ -301,13 +311,14 @@ IF(USE_FBGEMM_GENAI)
301311

302312
# Add additional HIPCC compiler flags for performance
303313
set(FBGEMM_GENAI_EXTRA_HIPCC_FLAGS
304-
-mllvm
305-
-amdgpu-coerce-illegal-types=1
306314
-mllvm
307315
-enable-post-misched=0
308316
-mllvm
309317
-greedy-reverse-local-assignment=1
310318
-fhip-new-launch-api)
319+
if(DEFINED ROCM_VERSION_DEV AND ROCM_VERSION_DEV VERSION_LESS "7.2.0")
320+
list(PREPEND FBGEMM_GENAI_EXTRA_HIPCC_FLAGS -mllvm -amdgpu-coerce-illegal-types=1)
321+
endif()
311322

312323
hip_add_library(
313324
fbgemm_genai STATIC

0 commit comments

Comments
 (0)