Skip to content

Commit be6b921

Browse files
authored
[rocm7.1_internal_testing] Partial revert PR#2735 to match upstream (#2797)
http://rocm-ci.amd.com/job/mainline-framework-pytorch-internal-cs9-ci/413/console Tested this PR via this job id which has passed the changed stages. Triton issue is tracked by https://ontrack-internal.amd.com/browse/SWDEV-562527
1 parent a11dcbd commit be6b921

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

.ci/docker/build.sh

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,6 @@ case "$tag" in
288288
;;
289289
*)
290290
# Catch-all for builds that are not hardcoded.
291-
PROTOBUF=yes
292291
VISION=yes
293292
echo "image '$image' did not match an existing build configuration"
294293
if [[ "$image" == *py* ]]; then
@@ -303,7 +302,6 @@ case "$tag" in
303302
TRITON=yes
304303
# To ensure that any ROCm config will build using conda cmake
305304
# and thus have LAPACK/MKL enabled
306-
CONDA_CMAKE=yes
307305
fi
308306
if [[ "$image" == *centos7* ]]; then
309307
NINJA_VERSION=1.10.2
@@ -320,9 +318,6 @@ case "$tag" in
320318
if [[ "$image" == *glibc* ]]; then
321319
extract_version_from_image_name glibc GLIBC_VERSION
322320
fi
323-
if [[ "$image" == *cmake* ]]; then
324-
extract_version_from_image_name cmake CMAKE_VERSION
325-
fi
326321
;;
327322
esac
328323

@@ -345,7 +340,6 @@ docker build \
345340
${no_cache_flag} \
346341
${progress_flag} \
347342
--build-arg "BUILD_ENVIRONMENT=${image}" \
348-
--build-arg "PROTOBUF=${PROTOBUF:-}" \
349343
--build-arg "LLVMDEV=${LLVMDEV:-}" \
350344
--build-arg "VISION=${VISION:-}" \
351345
--build-arg "UBUNTU_VERSION=${UBUNTU_VERSION}" \
@@ -357,15 +351,13 @@ docker build \
357351
--build-arg "PYTHON_VERSION=${PYTHON_VERSION}" \
358352
--build-arg "GCC_VERSION=${GCC_VERSION}" \
359353
--build-arg "CUDA_VERSION=${CUDA_VERSION}" \
360-
--build-arg "CMAKE_VERSION=${CMAKE_VERSION:-}" \
361354
--build-arg "NINJA_VERSION=${NINJA_VERSION:-}" \
362355
--build-arg "KATEX=${KATEX:-}" \
363356
--build-arg "ROCM_VERSION=${ROCM_VERSION:-}" \
364357
--build-arg "PYTORCH_ROCM_ARCH=${PYTORCH_ROCM_ARCH}" \
365358
--build-arg "IMAGE_NAME=${IMAGE_NAME}" \
366359
--build-arg "UCX_COMMIT=${UCX_COMMIT}" \
367360
--build-arg "UCC_COMMIT=${UCC_COMMIT}" \
368-
--build-arg "CONDA_CMAKE=${CONDA_CMAKE}" \
369361
--build-arg "TRITON=${TRITON}" \
370362
--build-arg "TRITON_CPU=${TRITON_CPU}" \
371363
--build-arg "ONNX=${ONNX}" \
@@ -454,9 +446,9 @@ HAS_TRITON=$(drun python -c "import triton" > /dev/null 2>&1 && echo "yes" || ec
454446
if [[ -n "$TRITON" || -n "$TRITON_CPU" ]]; then
455447
if [ "$HAS_TRITON" = "no" ]; then
456448
echo "expecting triton to be installed, but it is not"
457-
exit 0
449+
exit 1
458450
fi
459451
elif [ "$HAS_TRITON" = "yes" ]; then
460452
echo "expecting triton to not be installed, but it is"
461-
exit 0
453+
exit 1
462454
fi

.ci/docker/centos-rocm/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ COPY ./common/install_conda.sh install_conda.sh
4848
COPY ./common/common_utils.sh common_utils.sh
4949
RUN bash ./install_conda.sh && rm install_conda.sh common_utils.sh /opt/conda/requirements-ci.txt
5050

51-
5251
# (optional) Install vision packages like OpenCV
5352
ARG VISION
5453
COPY ./common/install_vision.sh ./common/cache_vision_models.sh ./common/common_utils.sh ./
@@ -82,7 +81,6 @@ ENV MAGMA_HOME /opt/rocm/magma
8281
ENV LANG en_US.utf8
8382
ENV LC_ALL en_US.utf8
8483

85-
8684
# (optional) Install non-default Ninja version
8785
ARG NINJA_VERSION
8886
COPY ./common/install_ninja.sh install_ninja.sh
@@ -98,7 +96,7 @@ COPY ./common/install_triton.sh install_triton.sh
9896
COPY ./common/common_utils.sh common_utils.sh
9997
COPY ci_commit_pins/triton.txt triton.txt
10098
COPY triton_version.txt triton_version.txt
101-
#RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
99+
RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
102100
RUN rm install_triton.sh common_utils.sh triton.txt triton_version.txt
103101

104102
# Install ccache/sccache (do this last, so we get priority in PATH)

0 commit comments

Comments
 (0)