Skip to content

Commit dba8539

Browse files
committed
Revert "[ROCm] Enable USE_FBGEMM_GENAI (pytorch#160676)"
This reverts commit 69a25f6.
1 parent ff2ba4c commit dba8539

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

CMakeLists.txt

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -881,21 +881,10 @@ cmake_dependent_option(
881881
USE_FBGEMM_GENAI
882882
"Whether to build FBGEMM GenAI quantized GEMM kernels.\
883883
Will be disabled if not supported by the platform"
884-
ON
885-
"USE_ROCM"
884+
OFF
885+
"USE_CUDA OR USE_ROCM"
886886
OFF)
887887

888-
IF(USE_FBGEMM_GENAI AND USE_ROCM AND NOT "gfx942" IN_LIST PYTORCH_ROCM_ARCH)
889-
message(WARNING "Unsupported ROCM arch for FBGEMM GenAI, will set USE_FBGEMM_GENAI to OFF")
890-
set(USE_FBGEMM_GENAI off)
891-
endif()
892-
893-
# Set USE_FBGEMM_GENAI to ON for CUDA build on SM100
894-
if(USE_CUDA AND "$ENV{TORCH_CUDA_ARCH_LIST}" MATCHES "10.0a")
895-
message(WARNING "Setting USE_FBGEMM_GENAI to ON for CUDA build on SM100")
896-
set(USE_FBGEMM_GENAI ON)
897-
endif()
898-
899888
# CAVEAT: Again, Flash Attention2 will error while building for sm52 while Mem
900889
# Eff Attention won't
901890
cmake_dependent_option(

aten/src/ATen/CMakeLists.txt

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ if(USE_MEM_EFF_ATTENTION)
252252
list(APPEND ATen_ATTENTION_KERNEL_SRCS ${mem_eff_attention_cuda_kernels_cu})
253253
endif()
254254

255+
IF(USE_FBGEMM_GENAI AND USE_ROCM AND NOT "gfx942" IN_LIST PYTORCH_ROCM_ARCH)
256+
message(WARNING "Unsupported ROCM arch for FBGEMM GenAI, will set USE_FBGEMM_GENAI to OFF")
257+
set(USE_FBGEMM_GENAI off)
258+
endif()
259+
255260
# FBGEMM GenAI
256261
IF(USE_FBGEMM_GENAI)
257262
set(FBGEMM_THIRD_PARTY ${PROJECT_SOURCE_DIR}/third_party/fbgemm/external/)
@@ -275,9 +280,10 @@ IF(USE_FBGEMM_GENAI)
275280
${fbgemm_genai_native_cuda_cpp}
276281
)
277282

278-
# Now, create the library and provide the sources at the same time
279-
add_library(fbgemm_genai OBJECT ${fbgemm_genai_all_sources})
280-
283+
hip_add_library(
284+
fbgemm_genai STATIC
285+
${fbgemm_genai_native_rocm_hip}
286+
HIPCC_OPTIONS ${HIP_HCC_FLAGS} ${FBGEMM_GENAI_EXTRA_HIPCC_FLAGS})
281287
set_target_properties(fbgemm_genai PROPERTIES POSITION_INDEPENDENT_CODE ON)
282288

283289
set(fbgemm_genai_mx8mx8bf16_grouped

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
# USE_FBGEMM=0
5959
# disables the FBGEMM build
6060
#
61-
# USE_FBGEMM_GENAI=0
62-
# disables the FBGEMM GenAI build
61+
# USE_FBGEMM_GENAI=1
62+
# enables the FBGEMM GenAI kernels to build
6363
#
6464
# USE_KINETO=0
6565
# disables usage of libkineto library for profiling

0 commit comments

Comments
 (0)