[ROCm][Windows] Fix finding ROCm/HIP version (#156486) #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for 358b6a23bfc8d2c10b36c08e66f842c4d901d9a4 commit finished as FAILURE |
jithunnair-amd
force-pushed
the
release/2.8
branch
from
3b41cb5 to
a0ffd4f
Compare
jithunnair-amd
requested review from
jataylo,
jeffdaily,
jithunnair-amd and
pruthvistony
as code owners
Collaborator
|
@tvukovic-amd , |
jeffdaily
requested changes
Aug 22, 2025
Collaborator
jeffdaily
left a comment
jeffdaily
left a comment
There was a problem hiding this comment.
The cherry-pick did not apply cleaning. Please start by checking out the release/2.8 branch, apply the cherry-pick https://github.com/pytorch/pytorch/pull/156486/files, then force-push back to this branch.
tvukovic-amd
force-pushed
the
fix_finding_rocm_and_hip_version
branch
from
358b6a2 to
462ad3e
Compare
|
Jenkins build for 462ad3e20bd6225b6909691c14570d1d71eee55e commit finished as FAILURE |
jeffdaily
approved these changes
Aug 25, 2025
This commit fixes Windows build issue related to trying to use rocm-core (rocm-core doesn't exist on HIP SDK) Pull Request resolved: pytorch#156486 Approved by: https://github.com/jeffdaily, https://github.com/stellaraccident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Windows build issue related to trying to rocm-core/rocm_version.h or hip/hip_version.h.
This is cherry-picked commit from upstream main (PR)