[ROCm] OffsetCalc Unroll Optimization #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry-pick of pytorch#161700 Our compiler is generating inefficient code for the offsetCalc in certain situations. The root-cause for this needs to be identified. For now specialized unrolling based on 'dims' notably helps perf.
Collaborator
Author
|
! cherry-pick --onto release/2.8 rocm7.1_internal_testing |
dhonnappa-amd
pushed a commit
that referenced
this pull request
Sep 3, 2025
cherry-pick of pytorch#161700 Our compiler is generating inefficient code for the offsetCalc in certain situations. The root-cause for this needs to be identified. For now specialized unrolling based on 'dims' notably helps perf. Fixes SWDEV-545713, SWDEV-545710
|
Can't perform the cherry-pick keyword: unexpected error Comment processed by Build |
|
Jenkins build for 9955889a17fade845f2de31093d836a308e0addb commit finished as ABORTED |
jerrymannil
added a commit
that referenced
this pull request
Sep 3, 2025
…2598) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]>
Collaborator
Author
|
! cherry-pick --onto rocm7.1_internal_testing |
dhonnappa-amd
pushed a commit
that referenced
this pull request
Sep 3, 2025
cherry-pick of pytorch#161700 Our compiler is generating inefficient code for the offsetCalc in certain situations. The root-cause for this needs to be identified. For now specialized unrolling based on 'dims' notably helps perf. Fixes SWDEV-545713, SWDEV-545710
|
Can't perform the cherry-pick keyword: unexpected error Comment processed by Build |
jerrymannil
added a commit
that referenced
this pull request
Sep 3, 2025
…ptimization (#2600) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]>
jerrymannil
added a commit
that referenced
this pull request
Sep 5, 2025
…ptimization (#2600) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]>
pragupta
pushed a commit
that referenced
this pull request
Oct 8, 2025
…2598) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]> (cherry picked from commit 9ea02c4)
jithunnair-amd
pushed a commit
that referenced
this pull request
Oct 10, 2025
…2598) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]> (cherry picked from commit 9ea02c4)
jeffdaily
pushed a commit
that referenced
this pull request
Nov 17, 2025
…2598) Cherry-pick of #2597 Co-authored-by: Jerry Mannil <[email protected]> (cherry picked from commit 9ea02c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick of pytorch#161700
Our compiler is generating inefficient code for the offsetCalc in certain situations. The root-cause for this needs to be identified. For now specialized unrolling based on 'dims' notably helps perf.
Fixes SWDEV-545713, SWDEV-545710