Fixed the use of the MSCCLPP_ENABLE_CLIP build flag

* Fixed the setting of the `MSCCLPP_ENABLE_CLIP` arg in the mscclpp build. It wasn't actually being defined in the C++ code at compile time, just passed to the cmake.

* Updated CHANGELOG.md
[rocm-systems] ROCm/rocm-systems#2773 (commit c90d4d6)

Author: corey-derochie-amd

CHANGELOG.md

@@ -14,6 +14,9 @@ Full documentation for RCCL is available at [https://rccl.readthedocs.io](https:
 * The MSCCL feature is now disabled by default. The `--disable-msccl-kernel` build flag is replaced with `--enable-msccl-kernel` in the `rccl/install.sh` script.
 * MSCCL and NPKIT are deprecated and will be removed in a future release of RCCL.
 
+### Resolved Issues
+* Fixed MSCCLPP_ENABLE_CLIP CMake build flag, which was not being properly honored.
+
 ## Unreleased - RCCL 2.27.7 for ROCm 7.2.0
 
 ### Changed

cmake/MSCCLPP.cmake

@@ -177,7 +177,7 @@ function(add_mscclpp_targets)
             mscclpp
             INSTALL_DIR         ${MSCCLPP_INSTALL_DIR}
             LIST_SEPARATOR      %
-            CMAKE_ARGS          "-DGPU_TARGETS=${MSCCLPP_GPU_TARGETS}" -DMSCCLPP_BYPASS_GPU_CHECK=ON -DMSCCLPP_USE_ROCM=ON -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DMSCCLPP_BUILD_APPS_NCCL=ON -DMSCCLPP_BUILD_PYTHON_BINDINGS=OFF -DMSCCLPP_BUILD_TESTS=OFF -DMSCCLPP_CLIP_ENABLED=${ENABLE_MSCCLPP_CLIP} -DMSCCLPP_ENABLE_EXECUTOR=${ENABLE_MSCCLPP_EXECUTOR} -DMSCCLPP_ENABLE_FORMAT_CHECKS=${ENABLE_MSCCLPP_FORMAT_CHECKS} -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> -DCMAKE_VERBOSE_MAKEFILE=1 "${CMAKE_INHERITED_ARGS}" -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} -DFETCHCONTENT_SOURCE_DIR_JSON=${JSON_SOURCE} -DEXT_SOURCE=${EXT_SOURCE}
+            CMAKE_ARGS          "-DGPU_TARGETS=${MSCCLPP_GPU_TARGETS}" -DMSCCLPP_BYPASS_GPU_CHECK=ON -DMSCCLPP_USE_ROCM=ON -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DMSCCLPP_BUILD_APPS_NCCL=ON -DMSCCLPP_BUILD_PYTHON_BINDINGS=OFF -DMSCCLPP_BUILD_TESTS=OFF -DMSCCLPP_ENABLE_CLIP=${ENABLE_MSCCLPP_CLIP} -DMSCCLPP_ENABLE_EXECUTOR=${ENABLE_MSCCLPP_EXECUTOR} -DMSCCLPP_ENABLE_FORMAT_CHECKS=${ENABLE_MSCCLPP_FORMAT_CHECKS} -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> -DCMAKE_VERBOSE_MAKEFILE=1 "${CMAKE_INHERITED_ARGS}" -DFETCHCONTENT_SOURCE_DIR_JSON=${JSON_SOURCE}
             LOG_DOWNLOAD        FALSE
             LOG_CONFIGURE       FALSE
             LOG_BUILD           FALSE

ext-src/remove-clip.patch

@@ -1,3 +1,17 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 712468d..e072852 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -144,6 +144,9 @@ endif()
+ if(MSCCLPP_NPKIT_FLAGS)
+     target_compile_definitions(mscclpp_obj PRIVATE ${MSCCLPP_NPKIT_FLAGS})
+ endif()
++if(MSCCLPP_ENABLE_CLIP)
++    target_compile_definitions(mscclpp_obj PRIVATE MSCCLPP_CLIP_ENABLED)
++endif()
+ 
+ # libmscclpp
+ add_library(mscclpp SHARED)
 diff --git a/apps/nccl/src/allreduce.hpp b/apps/nccl/src/allreduce.hpp
 index fac105a..9ef93ce 100644
 --- a/apps/nccl/src/allreduce.hpp