Skip to content

Commit 1ff3c88

Browse files
committed
address review comments 1
1 parent c2ec6f0 commit 1ff3c88

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Dialect/Rock/IR/MfmaInsnGroup.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -582,8 +582,8 @@ FailureOr<MfmaInsnGroup> MfmaInsnGroup::select(Type elementTypeA,
582582
}
583583
};
584584
bool isGfx908 = arch.contains("gfx908");
585-
bool isGfx90a = arch.contains("gfx908") || arch.contains("gfx90a");
586-
bool isGfx94x = arch.contains("gfx942") || arch.contains("gfx940");
585+
bool isGfx90a = arch.contains("gfx90a");
586+
bool isGfx94x = arch.contains("gfx942");
587587
bool isGfx95x = arch.contains("gfx950");
588588
// TODO: refactor this later to not keep multiple maps for different arches
589589
if (elementTypeA.isBF16()) {

mlir/test/Dialect/Rock/lowering_xdlops_gemm.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,4 +437,4 @@ func.func @accel_gemm_gfx950_i8_16x16x64(%matrixA : memref<1x2xvector<16xi8>, 5>
437437
forceUnroll = true>
438438
} : memref<1x1xvector<4xi32>, 5> += memref<1x2xvector<16xi8>, 5> * memref<1x2xvector<16xi8>, 5>
439439
return
440-
}
440+
}

0 commit comments

Comments
 (0)