Move CSE out of MIGraphXToTosaPass (#2012)

* Move CSE pass invocation out of MIGraphXToTosaPass

* Update LIT tests

Author: justinrosner

mlir/lib/Conversion/MIGraphXToTosa/MIGraphXToTosaPass.cpp

@@ -114,10 +114,6 @@ void MIGraphXToTosa::runOnOperation() {
   if (failed(applyPartialConversion(func, boundaryConversionTarget,
                                     std::move(boundaryPatterns))))
     return signalPassFailure();
-
-  OpPassManager cleanPM("func.func");
-  cleanPM.addPass(createCSEPass());
-  (void)runPipeline(cleanPM, func);
 }
 
 void mlir::migraphx::addMIGraphXToTosaPasses(OpPassManager &pm) {

mlir/lib/Dialect/MIGraphX/Pipeline/Pipeline.cpp

@@ -46,5 +46,6 @@ void migraphx::addHighLevelPipeline(PassManager &pm) {
   funcPm.addPass(migraphx::createMIGraphXTransformPass());
   funcPm.addPass(createCanonicalizerPass());
   funcPm.addPass(createMIGraphXToTosaPass());
+  funcPm.addPass(createCSEPass());
   funcPm.addPass(migraphx::createMIGraphXTosaSimplifyPass());
 }

mlir/test/Conversion/MIGraphXToTosa/mixr-to-tosa-ops.mlir

@@ -1,4 +1,4 @@
-// RUN: rocmlir-opt -split-input-file --migraphx-transform --canonicalize --migraphx-to-tosa %s -verify-diagnostics -o -| FileCheck %s
+// RUN: rocmlir-opt -split-input-file --migraphx-transform --canonicalize --migraphx-to-tosa --cse %s -verify-diagnostics -o -| FileCheck %s
 
 module  {
   // CHECK-LABEL: func @literal_zero

mlir/test/rocmlir-driver/pipelines.mlir

@@ -12,6 +12,7 @@
 // MIGRAPHX-NEXT:migraphx-transform,
 // MIGRAPHX-NEXT:canonicalize{  max-iterations=10 max-num-rewrites=-1 region-simplify=normal test-convergence=false top-down=true},
 // MIGRAPHX-NEXT:migraphx-to-tosa,
+// MIGRAPHX-NEXT:cse,
 // MIGRAPHX-NEXT:migraphx-tosa-simplify))
 
 // GPU:Kernel pipeline: