Address review comments, Revert changes for Navi4x in Jenkinsfile and fix parameterSweeps

Author: umangyadav

mlir/lib/Conversion/EmulateFp8ExtTrunc/EmulateFp8ExtTrunc.cpp

@@ -366,7 +366,7 @@ static FlatSymbolRefAttr makeFp8TruncFunction(Location loc, FloatType outType,
   Value cmp57 = b.create<CmpIOp>(CmpIPredicate::ne, sub43, i32Const(0));
   Value and58 = b.create<AndIOp>(add56, i32Const(1 << 23));
   Value tobool59Not = b.create<CmpIOp>(CmpIPredicate::eq, and58, i32Const(0));
-  Value trueConst = b.create<ConstantIntOp>(true, /*width=*/1);
+  Value trueConst = b.create<ConstantIntOp>(b.getI1Type(), true);
   Value brCond133 = b.create<SelectOp>(cmp57, trueConst, tobool59Not);
 
   Block *ifElse61 = func.addBlock();
@@ -402,7 +402,7 @@ static FlatSymbolRefAttr makeFp8TruncFunction(Location loc, FloatType outType,
   Value cmp72 = b.create<CmpIOp>(CmpIPredicate::eq, f8Exponent0, i32Const(0));
   Value cmp74 = b.create<CmpIOp>(CmpIPredicate::ult, mantissa1,
                                  i32Const(1 << (16 + eBits)));
-  Value falseConst = b.create<ConstantIntOp>(false, /*width=*/1);
+  Value falseConst = b.create<ConstantIntOp>(b.getI1Type(), false);
   Value brCond = b.create<SelectOp>(cmp72, cmp74, falseConst);
   b.create<cf::CondBranchOp>(brCond, ret, ValueRange{outZero}, ifEnd76,
                              ValueRange{f8Exponent0, mantissa1});

mlir/utils/jenkins/Jenkinsfile

@@ -414,8 +414,9 @@ boolean shouldRunFromCodepath(String codepath) {
     if (params.canXdlops && (params.disableNavi3x == false) && (codepath == "navi3x")) {
         return true
     }
-    // Run navi4x on private CI if it is not disabled
-    if (params.canXdlops && (params.disableNavi4x == false) && (codepath == "navi4x")) {  
+    // Run navi4x on private nightly CI only  
+    if (params.canXdlops && (params.disableNavi4x == false) && (codepath == "navi4x") &&  
+        params.nightly) {  
         return true;  
     }  
     return false

mlir/utils/performance/parameterSweeps.py

@@ -525,7 +525,7 @@ def main() -> bool:
             print(f"""Unknown arch {arch}""", file=sys.stderr)
 
     options = Options(debug=args.debug, quiet=args.quiet,
-        arch=arch, flags=rocmlir_gen_flags, concurrent_tests=args.jobs, numCU=getNumCU(getChip()))
+        arch=arch, flags=rocmlir_gen_flags, concurrent_tests=args.jobs, numCu=getNumCU(getChip()))
     paths = perfRunner.create_paths(None, args.mlir_build_dir)
 
     config = args.config