[MIOpen][MLIR][GraphAPI] Dead code removal MLIR + GraphAPI (#4387)

approved dead code removal. In this case whole MLIR and GraphAPI
components are removed completely

---------

Co-authored-by: Vsevolod Golovko <vsevolod.golovko@amd.com>
Co-authored-by: BradPepersAMD <Brad.Pepers@amd.com>

Author: 3 people

projects/miopen/.jenkins/perf_test

@@ -24,7 +24,6 @@ pipeline {
       Full_test       = " -DMIOPEN_TEST_ALL=Off"
       Smoke_targets   = " check MIOpenDriver"
       NOCOMGR_flags   = " -DMIOPEN_USE_COMGR=Off"
-      NOMLIR_flags    = " -DMIOPEN_USE_MLIR=Off"
       perftest_image  = docker.image('ubuntu:22.04')
   }
   parameters {

projects/miopen/CHANGELOG.md

@@ -2,6 +2,11 @@
 # Change Log for MIOpen
 
 Full documentation for MIOpen is available [here](https://rocm.docs.amd.com/projects/MIOpen/en/latest/)
+## MIOpen 3.6.0 for ROCm 7.12.0
+### Removed
+* Removed MLIR compilation backend (`MIOPEN_USE_MLIR`) and all MLIR-based solvers
+* Removed GraphAPI experimental feature and related code
+
 ## MIOpen 3.5.1 for ROCm 7.12.0
 ### Added
 * [Conv] Enabled CK wrw and bwd solvers with split-k disabled in deterministic mode.

projects/miopen/CMakeLists.txt

@@ -116,7 +116,7 @@ if(MIOPEN_STRIP_SYMBOLS AND NOT WIN32 AND NOT APPLE)
     set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -s")
 endif()
 
-rocm_setup_version(VERSION 3.5.1)
+rocm_setup_version(VERSION 3.6.0)
 
 include(TargetFlags)
 
@@ -402,37 +402,6 @@ else()
     message(STATUS "clang-offload-bundler not found")
 endif()
 
-set_var_to_condition(MIOPEN_USE_MLIR_DEFAULT NOT (NOT ${BUILD_SHARED_LIBS} AND ${MIOPEN_USE_COMGR}))
-option(MIOPEN_USE_MLIR "Use MLIR compilation backend" ${MIOPEN_USE_MLIR_DEFAULT})
-
-if(MIOPEN_USE_MLIR)
-    if(NOT ${BUILD_SHARED_LIBS} AND ${MIOPEN_USE_COMGR})
-        message(FATAL_ERROR "Potential symbol conflict between mlir and comgr in static build")
-    endif()
-    if(WIN32)
-        # Windows does not support earlier ROCm versions hence no fallback to MLIRMIOpen.
-        find_package(rocMLIR 1.0.0 CONFIG REQUIRED)
-    else()
-        # Try to find package rocMLIR
-        # REQUIRED is omitted since we do not want cmake to abort if the package is not found
-        find_package(rocMLIR 1.0.0 CONFIG)
-        if(NOT rocMLIR_FOUND)
-            message(STATUS "Falling back to find library libMLIRMIOpen")
-            # Backward compatibility with ROCm 5.3
-            # If the rocMLIR package is not found, try to find the library libMLIRMIOpen directly
-            find_library(LIBMLIRMIOPEN MLIRMIOpen REQUIRED)
-            if(NOT LIBMLIRMIOPEN)
-                message(FATAL_ERROR "library libMLIRMIOpen not found, please reinstall dependencies. \
-                Refer to https://github.com/ROCm/MIOpen#installing-the-dependencies")
-            else()
-                message(STATUS "Build with library libMLIRMIOpen: " ${LIBMLIRMIOPEN})
-                set(rocMLIR_VERSION 0.0.1)
-            endif()
-        endif()
-    endif()
-    message(STATUS "Build with rocMLIR::rockCompiler ${rocMLIR_VERSION} ${rocMLIR_DIR}")
-endif()
-
 # Update HIP Runtime Package Dependency
 if(ENABLE_ASAN_PACKAGING)
   set(DEPENDS_HIP_RUNTIME "hip-runtime-amd-asan" )

projects/miopen/Jenkinsfile

@@ -27,7 +27,7 @@ def get_branch_name(){
 ///   * The default compiler is usually not specified.
 /// BuildType := { Release* | Debug | Install } [ BuildTypeModifier ]
 ///   * BuildTypeModifier := { NOCOMGR | Embedded | Static | Normal-Find | Fast-Find
-///                            NOCK | NOMLIR | Tensile | Tensile-Latest | Package | ... }
+///                            NOCK | Tensile | Tensile-Latest | Package | ... }
 /// TestSet := { All | Smoke* | <Performance Dataset> | Build-only }
 ///   * "All" corresponds to "cmake -DMIOPEN_TEST_ALL=On".
 ///   * "Smoke" (-DMIOPEN_TEST_ALL=Off) is the default and usually not specified.
@@ -300,7 +300,7 @@ pipeline {
 
         Smoke_targets   = " check MIOpenDriver"
         NOCOMGR_flags   = " -DMIOPEN_USE_COMGR=Off"
-        NOMLIR_flags    = " -DMIOPEN_USE_MLIR=Off"
+
         CK_DIR          = "${ckDir}"
         MIOPEN_DIR      = "${miopenDir}"
         PROJ_DIR        = "${projDir}"
@@ -658,7 +658,7 @@ pipeline {
                     }
                 }
                 // GFX90A Tests
-                stage('Fp32 Hip Debug NOMLIR gfx90a') {
+                stage('Fp32 Hip Debug gfx90a') {
                     when {
                         beforeAgent true
                         expression { params.TARGET_GFX90A }
@@ -669,12 +669,12 @@ pipeline {
                     agent{ label rocmnode("gfx90a") }
                     environment{
                         // Can be removed altogether with when WORKAROUND_SWDEV_290754.
-                        NOMLIR_build_cmd = "CTEST_PARALLEL_LEVEL=4 MIOPEN_LOG_LEVEL=5 make -j\$(nproc) check"
+                        debug_build_cmd = "CTEST_PARALLEL_LEVEL=4 MIOPEN_LOG_LEVEL=5 make -j\$(nproc) check"
                     }
                     steps{
                         script {
                             withWorkingDir {
-                                utils.buildHipClangJob( build_type: 'debug', setup_flags: NOMLIR_flags + gfx90a_flags, build_cmd: NOMLIR_build_cmd, test_flags: ' --verbose ', build_install: true, gpu_family: "gfx90X")
+                                utils.buildHipClangJob( build_type: 'debug', setup_flags: gfx90a_flags, build_cmd: debug_build_cmd, test_flags: ' --verbose ', build_install: true, gpu_family: "gfx90X")
                             }
                         }
                     }
@@ -718,7 +718,7 @@ pipeline {
                     steps{
                         script {
                             withWorkingDir {
-                                utils.buildHipClangJob( setup_flags: "-DBUILD_SHARED_LIBS=Off" + gfx90a_flags, mlir_build: 'OFF', build_install: true, gpu_family: "gfx90X")
+                                utils.buildHipClangJob( setup_flags: "-DBUILD_SHARED_LIBS=Off" + gfx90a_flags, build_install: true, gpu_family: "gfx90X")
                             }
                         }
                     }

projects/miopen/README.md

@@ -47,8 +47,6 @@ To install MIOpen, you must first install these prerequisites:
 * [hipBLASLt](https://github.com/ROCm/rocm-libraries/tree/develop/projects/hipblaslt): AMD's flexible Basic Linear Algebra Subprograms
   (BLAS) API.
 * [hipBLAS](https://github.com/ROCm/rocm-libraries/tree/develop/projects/hipblas): AMD's (BLAS) marshalling library.
-* [Multi-Level Intermediate Representation (MLIR)](https://github.com/ROCm/rocMLIR) with its
-  MIOpen dialect to support and complement kernel development
 * [Composable Kernel](https://github.com/ROCm/composable_kernel): A C++ templated device library
   for GEMM-like and reduction-like operators.
 

projects/miopen/docs/install/prerequisites.rst

@@ -28,7 +28,5 @@ all types of MIOpen installations.
   * Minimum version for post-ROCm 3.5
     `master-rocm-3.5 <https://github.com/ROCm/rocBLAS/tree/master-rocm-3.5>`_
 
-* `Multi-Level Intermediate Representation (MLIR) <https://github.com/ROCm/rocMLIR>`_, with an
-  MIOpen dialect to support and complement kernel development
 * :doc:`Composable Kernel <composable_kernel:index>`: A C++ templated device library for
   GEMM-like and reduction-like operators.

projects/miopen/docs/reference/env_variables.rst

@@ -945,28 +945,6 @@ following table.
       - | 0: Disable
         | 1: Enable
 
-MLIR solution control
-=====================
-
-The MLIR solution control environment variables for MIOpen are collected in the following table.
-
-.. list-table::
-    :header-rows: 1
-    :widths: 70,30
-
-    * - **Environment variable**
-      - **Value**
-
-    * - | ``MIOPEN_DEBUG_CONV_MLIR_IGEMM_WRW_XDLOPS``
-        | Controls MLIR implicit GEMM weight-gradient XDLOPS solution.
-      - | 0: Disable
-        | 1: Enable
-
-    * - | ``MIOPEN_DEBUG_CONV_MLIR_IGEMM_BWD_XDLOPS``
-        | Controls MLIR implicit GEMM backward XDLOPS solution.
-      - | 0: Disable
-        | 1: Enable
-
 Attention and softmax control
 =============================
 

projects/miopen/include/miopen/config.h.in

@@ -25,7 +25,6 @@
 #cmakedefine01 MIOPEN_DISABLE_SYSDB
 #cmakedefine01 MIOPEN_LOG_FUNC_TIME_ENABLE
 #cmakedefine01 MIOPEN_ENABLE_SQLITE_BACKOFF
-#cmakedefine01 MIOPEN_USE_MLIR
 #cmakedefine01 MIOPEN_USE_COMPOSABLEKERNEL
 #cmakedefine01 MIOPEN_BUILD_DRIVER
 #cmakedefine01 MIOPEN_ENABLE_AI_IMMED_MODE_FALLBACK