Skip to content

Commit 17272d5

Browse files
authored
Re-enable OpenMP target and testing (#126)
* Re-enable OpenMP target and testing * Enable openmp target tests on mi200 jobs * Fix direct self-inclusion of header file * Enable openmp-target testing on vega20 --------- Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com> [ROCm/rocprofiler-sdk commit: 2fe63d8]
1 parent be053cb commit 17272d5

File tree

6 files changed

+6
-17
lines changed

6 files changed

+6
-17
lines changed

projects/rocprofiler-sdk/.github/workflows/continuous_integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ env:
3232
navi4_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$"
3333
navi3_EXCLUDE_LABEL_REGEX: "^(pc-sampling|pc_sampling|openmp-target)$"
3434
vega20_EXCLUDE_LABEL_REGEX: "^(pc-sampling|pc_sampling|openmp-target)$"
35-
mi200_EXCLUDE_LABEL_REGEX: "^(openmp-target)$"
35+
mi200_EXCLUDE_LABEL_REGEX: ""
3636
mi300_EXCLUDE_LABEL_REGEX: "^(pc-sampling|pc_sampling)$"
3737
mi300a_EXCLUDE_LABEL_REGEX: ""
3838
mi325_EXCLUDE_LABEL_REGEX: "^(pc-sampling|pc_sampling)$"

projects/rocprofiler-sdk/cmake/rocprofiler_config_install_roctx.cmake

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,8 @@ set(${PACKAGE_NAME}_BUILD_TREE
5757
ON
5858
CACHE BOOL "" FORCE)
5959

60-
set(PROJECT_BUILD_TREE_TARGETS
61-
${SDK_PACKAGE_NAME}::${PACKAGE_NAME}-shared-library
62-
${SDK_PACKAGE_NAME}::${SDK_PACKAGE_NAME}-headers
63-
${SDK_PACKAGE_NAME}::${SDK_PACKAGE_NAME}-stack-protector)
60+
set(PROJECT_BUILD_TREE_TARGETS ${SDK_PACKAGE_NAME}::${PACKAGE_NAME}-shared-library
61+
${SDK_PACKAGE_NAME}::${SDK_PACKAGE_NAME}-stack-protector)
6462

6563
configure_file(
6664
${PROJECT_SOURCE_DIR}/cmake/Templates/${PACKAGE_NAME}/build-config.cmake.in

projects/rocprofiler-sdk/cmake/rocprofiler_options.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ rocprofiler_add_option(
5353
rocprofiler_add_option(ROCPROFILER_BUILD_FMT "Enable building fmt library internally" ON)
5454
rocprofiler_add_option(ROCPROFILER_BUILD_GLOG
5555
"Enable building glog (Google logging) library internally" ON)
56-
rocprofiler_add_option(ROCPROFILER_BUILD_OPENMP_TESTS
57-
"Enable building openmp tests and samples" OFF ADVANCED)
5856
if(ROCPROFILER_BUILD_TESTS)
5957
rocprofiler_add_option(
6058
ROCPROFILER_BUILD_GTEST

projects/rocprofiler-sdk/samples/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,4 @@ add_subdirectory(intercept_table)
3232
add_subdirectory(code_object_isa_decode)
3333
add_subdirectory(external_correlation_id_request)
3434
add_subdirectory(pc_sampling)
35-
if(ROCPROFILER_BUILD_OPENMP_TESTS)
36-
add_subdirectory(openmp_target)
37-
endif()
35+
add_subdirectory(openmp_target)

projects/rocprofiler-sdk/tests/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,10 @@ add_subdirectory(thread-trace)
6868
add_subdirectory(pc_sampling)
6969
add_subdirectory(hip-graph-tracing)
7070
add_subdirectory(counter-collection)
71+
add_subdirectory(openmp-tools)
7172
add_subdirectory(rocdecode)
7273
add_subdirectory(rocjpeg)
7374
add_subdirectory(conversion-script)
7475

75-
if(ROCPROFILER_BUILD_OPENMP_TESTS)
76-
add_subdirectory(openmp-tools)
77-
endif()
78-
7976
# rocprofv3 validation tests
8077
add_subdirectory(rocprofv3)

projects/rocprofiler-sdk/tests/bin/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ find_package(rocJPEG)
1616
# applications used by integration tests which DO link to rocprofiler-sdk-roctx
1717
add_subdirectory(reproducible-runtime)
1818
add_subdirectory(transpose)
19-
if(ROCPROFILER_BUILD_OPENMP_TESTS)
20-
add_subdirectory(openmp)
21-
endif()
19+
add_subdirectory(openmp)
2220

2321
set(CMAKE_BUILD_RPATH "\$ORIGIN:\$ORIGIN/../lib")
2422

0 commit comments

Comments
 (0)