Skip to content

Commit 22c4359

Browse files
authored
[Rel 7.0 RC2]Profiler - Remove UUID metric (#224)
[ROCm/rdc commit: 6cb0cea]
2 parents 9f2fa6a + 1466fc7 commit 22c4359

File tree

3 files changed

+1
-26
lines changed

3 files changed

+1
-26
lines changed

projects/rdc/common/rdc_field.data

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ FLD_DESC_ENT(RDC_FI_PROF_CPF_CPF_TCIU_IDLE, "", "CPF_CPF_TCIU_I
195195
FLD_DESC_ENT(RDC_FI_PROF_CPF_CPF_TCIU_STALL, "", "CPF_CPF_TCIU_STALL", false)
196196
// Misc
197197
FLD_DESC_ENT(RDC_FI_PROF_SIMD_UTILIZATION, "Fraction of time the SIMDs are being utilized", "SIMD_UTILIZATION", false)
198-
FLD_DESC_ENT(RDC_FI_PROF_UUID, "UUID from rocprofiler", "PROF_UUID", true)
199198
FLD_DESC_ENT(RDC_FI_PROF_KFD_ID, "GPU_ID from rocprofiler, same as KFD_ID", "PROF_KFD_ID", true)
200199

201200
// Events

projects/rdc/include/rdc/rdc.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,6 @@ typedef enum {
344344
RDC_FI_PROF_CPF_CPF_TCIU_IDLE,
345345
RDC_FI_PROF_CPF_CPF_TCIU_STALL,
346346
RDC_FI_PROF_SIMD_UTILIZATION,
347-
RDC_FI_PROF_UUID,
348347
RDC_FI_PROF_KFD_ID,
349348

350349
/**

projects/rdc/rdc_libs/rdc_modules/rdc_rocp/RdcRocpBase.cc

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ static const std::map<rdc_field_t, const char*> temp_field_map_k = {
110110
{RDC_FI_PROF_CPF_CPF_TCIU_IDLE, "CPF_CPF_TCIU_IDLE"},
111111
{RDC_FI_PROF_CPF_CPF_TCIU_STALL, "CPF_CPF_TCIU_STALL"},
112112
{RDC_FI_PROF_SIMD_UTILIZATION, "SIMD_UTILIZATION"},
113-
{RDC_FI_PROF_UUID, "SQ_WAVES"}, // dummy value,
114113
{RDC_FI_PROF_KFD_ID, "SQ_WAVES"}, // dummy value,
115114
};
116115

@@ -164,21 +163,6 @@ const std::vector<rdc_field_t> RdcRocpBase::get_field_ids() {
164163
return field_ids;
165164
}
166165

167-
rocprofiler_uuid_t asic_serial_to_uuid(const char* asic_serial) {
168-
rocprofiler_uuid_t uuid = {0};
169-
// have to cast to stoull as a workaround for amdsmi ignoring leading zeroes
170-
uuid.value = std::stoull(asic_serial, nullptr, 16);
171-
return uuid;
172-
}
173-
174-
std::string uuid_to_string(const uint64_t uuid) {
175-
std::ostringstream oss;
176-
oss << "0x" << std::hex << std::setw(16) << std::setfill('0') << uuid;
177-
return oss.str();
178-
}
179-
180-
std::string uuid_to_string(const rocprofiler_uuid_t& uuid) { return uuid_to_string(uuid.value); }
181-
182166
rdc_status_t RdcRocpBase::map_entity_to_profiler() {
183167
// std::map<uint32_t, uint32_t> entity_to_index_map;
184168
// kfd_id_t is only used inside this function
@@ -419,15 +403,8 @@ rdc_status_t RdcRocpBase::rocp_lookup(rdc_gpu_field_t gpu_field, rdc_field_value
419403
// FLOPS/clock/CU
420404
data->dbl = divided_dbl / (256.0F / static_cast<double>(agents[agent_index].simd_per_cu));
421405
break;
422-
case RDC_FI_PROF_UUID: {
423-
// do not care what RDC_FI_PROF_UUID is mapped to. read value from agents
424-
*type = STRING;
425-
std::string uuid_str = uuid_to_string(agents[agent_index].uuid);
426-
strncpy_with_null(data->str, uuid_str.c_str(), uuid_str.length());
427-
break;
428-
}
429406
case RDC_FI_PROF_KFD_ID: {
430-
// do not care what RDC_FI_PROF_UUID is mapped to. read value from agents
407+
// do not care what it is mapped to. read value from agents
431408
*type = INTEGER;
432409
data->l_int = agents[agent_index].gpu_id;
433410
break;

0 commit comments

Comments
 (0)