Fix unit tests, remove get_use_cache_output

Author: adjordje-amd

projects/rocprofiler-systems/source/lib/core/config.cpp

@@ -2555,12 +2555,6 @@ get_caching_perfetto()
     return _v;
 }
 
-bool
-get_use_cache_output()
-{
-    return get_use_rocpd() || get_caching_perfetto();
-}
-
 int
 get_kill_delay()
 {

projects/rocprofiler-systems/source/lib/core/config.hpp

@@ -385,9 +385,6 @@ get_use_rocpd() ROCPROFSYS_HOT;
 bool&
 get_caching_perfetto() ROCPROFSYS_HOT;
 
-bool
-get_use_cache_output() ROCPROFSYS_HOT;
-
 bool
 get_merge_perfetto_files();
 

projects/rocprofiler-systems/source/lib/rocprof-sys/library/pmc/collectors/gpu/cache_policy.hpp

@@ -38,21 +38,12 @@ struct cache_policy
      */
     static void initialize_category_metadata()
     {
-        if(!get_use_cache_output())
-        {
-            return;
-        }
         trace_cache::get_metadata_registry().add_string(
             trait::name<category::amd_smi>::value);
     }
 
     static void initialize_tracks_metadata()
     {
-        if(!get_use_cache_output())
-        {
-            return;
-        }
-
         const auto thread_id = std::nullopt;
 
         trace_cache::get_metadata_registry().add_track(
@@ -163,11 +154,6 @@ struct cache_policy
      */
     static void initialize_pmc_metadata(size_t gpu_id)
     {
-        if(!get_use_cache_output())
-        {
-            return;
-        }
-
         // Metadata field constants for PMC info registration
         constexpr size_t      EVENT_CODE       = 0;
         constexpr size_t      INSTANCE_ID      = 0;
@@ -343,10 +329,6 @@ struct cache_policy
                              const enabled_metrics& enabled_metrics_cfg,
                              const metrics& metric_values, unsigned long timestamp)
     {
-        if(!get_use_cache_output())
-        {
-            return;
-        }
         enabled_metrics _enabled_metrics = { .value = enabled_metrics_cfg.value &
                                                       supported_metrics.value };