versioned comgr dll causes error in opencl apps (#3974)

versioned comgr dll causes error in runtime
setting kComgrVersioned
opencl=false
hip=true


## Technical Details
versioned comgr dll causes error in runtime
setting kComgrVersioned
opencl=false
hip=true


## JIRA ID
https://amd-hub.atlassian.net/browse/ROCM-20077

## Test Plan
hip-tests and opencl tests need to pass
<!-- Explain any relevant testing done to verify this PR. -->

## Test Result
hip-tests and opencl tests need to pass

Rock CI verifies hip-tests/hip apps
ocltst and clinfo were verified locally since Rock does not have Opencl
testing yet.
Used the artifacts from this PR  and run 
https://github.com/ROCm/rocm-systems/actions/runs/23009594300

python build_tools/install_rocm_from_artifacts.py --run-id 23009594300
--amdgpu-family gfx94X-dcgpu --tests --run-github-repo ROCm/rocm-systems

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Author: agunashe

.github/workflows/therock-ci-linux.yml

@@ -69,8 +69,7 @@ jobs:
       - name: Patch rocm-systems
         run: |
           # Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo
-          # rm ./TheRock/patches/amd-mainline/rocm-systems/*.patch
-          git -c user.name="therockbot" -c "user.email=therockbot@amd.com" am --whitespace=nowarn ./TheRock/patches/amd-mainline/rocm-systems/*.patch
+          rm ./TheRock/patches/amd-mainline/rocm-systems/0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch
 
       - name: Configure Projects
         env:

.github/workflows/therock-ci-windows.yml

@@ -53,8 +53,7 @@ jobs:
       - name: Patch rocm-systems
         run: |
           # Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo
-          # rm ./TheRock/patches/amd-mainline/rocm-systems/*.patch
-          git -c user.name="therockbot" -c "user.email=therockbot@amd.com" am --whitespace=nowarn ./TheRock/patches/amd-mainline/rocm-systems/*.patch
+          rm ./TheRock/patches/amd-mainline/rocm-systems/0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch
 
       - name: Install requirements
         run: |

.github/workflows/therock-rccl-ci-linux.yml

@@ -65,6 +65,11 @@ jobs:
         run: |
           ./TheRock/build_tools/fetch_sources.py --jobs 12 --no-include-rocm-systems
 
+      - name: Patch rocm-systems
+        run: |
+          # Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo
+          rm ./TheRock/patches/amd-mainline/rocm-systems/0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch
+
       - name: Configure Projects
         env:
           amdgpu_families: ${{ env.AMDGPU_FAMILIES }}

projects/clr/rocclr/device/device.cpp

@@ -807,8 +807,8 @@ Device::~Device() {
 }
 
 bool Device::ValidateComgr() {
-  // Check if Lightning compiler was requested
-  constexpr bool kComgrVersioned = false;
+  // use versioned comgr for HIP, unversioned for Opencl
+  const bool kComgrVersioned = amd::IS_HIP;
   std::call_once(amd::Comgr::initialized, amd::Comgr::LoadLib, kComgrVersioned);
   return amd::Comgr::IsReady();
 }