Merge branch 'amd-mainline' into amd/dev/ninohila/enable-palamida

[ROCm/rocm-core commit: 7aaa4aa]

Author: amd-ninohila

projects/rocm-core/.github/palamida.yml

@@ -2,4 +2,4 @@ disabled: false
 scmId: gh-emu-rocm
 branchesToScan:
   - amd-staging
-  - amd-mainline
+  - amd-mainline

projects/rocm-core/.github/workflows/kws-caller.yml

@@ -0,0 +1,15 @@
+name: Rocm Validation Suite KWS
+on:
+  push:
+    branches: [amd-staging, amd-mainline]
+  pull_request:
+    types: [opened, synchronize, reopened]
+  workflow_dispatch:
+jobs:
+  kws:
+    if: ${{ github.event_name == 'pull_request' }}
+    uses: AMD-ROCm-Internal/rocm_ci_infra/.github/workflows/kws.yml@mainline
+    secrets: inherit
+    with:
+      pr_number: ${{github.event.pull_request.number}}
+      base_branch: ${{github.base_ref}}

projects/rocm-core/.github/workflows/rocm_ci_caller.yml

@@ -0,0 +1,26 @@
+name: ROCm CI Caller
+on: 
+  # Commenting below to avoid re-runs of amd smi for trivial rebases
+  pull_request:  
+    branches: [release/rocm-rel-*, amd-mainline]  
+    types: [opened, reopened, synchronize]  
+  push:  
+    branches: [amd-mainline]  
+  workflow_dispatch:  
+  issue_comment:  
+    types: [created]
+    
+jobs:  
+  call-workflow:  
+    if: github.event_name != 'issue_comment' ||(github.event_name == 'issue_comment' && github.event.issue.pull_request && (startsWith(github.event.comment.body, '!verify') || startsWith(github.event.comment.body, '!verify release') || startsWith(github.event.comment.body, '!verify retest')))  
+    uses: AMD-ROCm-Internal/rocm_ci_infra/.github/workflows/rocm_ci.yml@mainline
+    secrets: inherit  
+    with:  
+      input_sha: ${{github.event_name == 'pull_request' && github.event.pull_request.head.sha || (github.event_name == 'push' && github.sha) || (github.event_name == 'issue_comment' && github.event.issue.pull_request.head.sha) || github.sha}}  
+      input_pr_num: ${{github.event_name == 'pull_request' && github.event.pull_request.number || (github.event_name == 'issue_comment' && github.event.issue.number) || 0}}  
+      input_pr_url: ${{github.event_name == 'pull_request' && github.event.pull_request.html_url || (github.event_name == 'issue_comment' && github.event.issue.pull_request.html_url) || ''}}  
+      input_pr_title: ${{github.event_name == 'pull_request' && github.event.pull_request.title || (github.event_name == 'issue_comment' && github.event.issue.pull_request.title) || ''}}  
+      repository_name: ${{ github.repository }}  
+      base_ref: ${{github.event_name == 'pull_request' && github.event.pull_request.base.ref || (github.event_name == 'issue_comment' && github.event.issue.pull_request.base.ref) || github.ref}}  
+      trigger_event_type: ${{ github.event_name }}  
+      comment_text: ${{ github.event_name == 'issue_comment' && github.event.comment.body || '' }}

projects/rocm-core/CHANGELOG.md

@@ -1,6 +1,10 @@
 Change Logs for rocm-core
 
-Unreleased ROCm6.1.0 release
+ROCm6.4.1 release
+ - Added changelog.debian and copyright for debian packages.
+ROCm6.3.0 release
+ - Enabled Support for CMAKE Module Config.
+ROCm6.1.0 release
  - Added new API to get ROCm install Path (getROCmInstallPath()) at runtime
    using dlinfo of rocm-core Target Library.
 ROCm6.0.0 release

projects/rocm-core/CMakeLists.txt

@@ -32,11 +32,32 @@ project( ${CORE_TARGET} CXX )
 ## Define Lib Target Name and Lib Target Install Dir to be available to c++ source
 add_definitions( -DTARGET_LIBRARY_NAME=\"${CORE_TARGET}\" -DTARGET_LIBRARY_INSTALL_DIR=\"${CMAKE_INSTALL_LIBDIR}\" )
 
+## Build Type Settings
+set( CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build, options are: None Debug Release RelWithDebInfo MinSizeRel." )
+
 ## Verbose output.
 set( CMAKE_VERBOSE_MAKEFILE on )
+include( GNUInstallDirs )
+
+if(ENABLE_ASAN_PACKAGING)
+  # Only libraries required for ASAN Package
+  set( CPACK_COMPONENTS_ALL CORE_ASAN )
+  set( COMP_TYPE "CORE_ASAN" )
+  set( PKG_DESCRIPTION "ROCm AddressSanitizer Instrumented Runtime software stack" )
+  set( CMAKE_INSTALL_DOCDIR "${CMAKE_INSTALL_DOCDIR}-asan" )
+else()
+  if(BUILD_SHARED_LIBS)
+    set( CPACK_COMPONENTS_ALL CORE_RUNTIME )
+    set( COMP_TYPE "CORE_RUNTIME" )
+    set( PKG_DESCRIPTION "ROCm Runtime software stack" )
+  else()
+    set( CPACK_COMPONENTS_ALL CORE_STATIC )
+    set( STATIC_COMP_TYPE "CORE_STATIC" )
+    set( PKG_DESCRIPTION "ROCm Static software stack" )
+  endif()
+endif()
 
 include( utils.cmake )
-include( GNUInstallDirs )
 
 #Parse Version
 message( STATUS "ROCM_VERSION = ${ROCM_VERSION}" )
@@ -45,12 +66,12 @@ parse_rocm_version( ${ROCM_VERSION} )
 set( CPACK_PACKAGING_INSTALL_PREFIX "/opt/rocm" CACHE PATH "default cpack directory" )
 set( BUILD_SHARED_LIBS ON CACHE BOOL "Build shared library (.so) or not." )
 set( CPACK_GENERATOR "TGZ;DEB;RPM" CACHE STRING "package types to be produced " )
-set( COPYRIGHT_FILE "${CMAKE_CURRENT_SOURCE_DIR}/copyright"  )
+set( LICENSE_FILE "${CMAKE_CURRENT_SOURCE_DIR}/copyright"  )
 set( BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR} )
-
-if(NOT ENABLE_ASAN_PACKAGING)
-    option(FILE_REORG_BACKWARD_COMPATIBILITY "Enable File Reorg with backward compatibility" OFF)
-endif()
+set( EXTENDED_PACKAGE_DESCRIPTION
+     "ROCM-CORE is a package which can be used to get ROCm release version, get ROCm install path information etc.
+     It is also important to note that ROCM-CORE takes the role as a base component on which all of ROCm can depend,
+     to make it easy to remove all of ROCm with a package manager." CACHE STRING "Debian Package Extended Description")
 
 ## Set variables
 set_variables()
@@ -62,37 +83,25 @@ if( NOT DEFINED BUILD_ID )
   set( BUILD_ID "9999")
 endif()
 
-set( PACKAGE_BUILD_INFO "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}.${VERSION_COMMIT_COUNT}-${BUILD_ID}-${VERSION_HASH}" )
+#Add the libpatch version if available
+if( DEFINED VERSION_POINT )
+  set( PACKAGE_BUILD_INFO "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}.${VERSION_POINT}.${VERSION_COMMIT_COUNT}-${BUILD_ID}-${VERSION_HASH}" )
+  message ( STATUS "PACKAGE_BUILD_INFO ${PACKAGE_BUILD_INFO}" )
+else ()
+  set( PACKAGE_BUILD_INFO "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}.${VERSION_COMMIT_COUNT}-${BUILD_ID}-${VERSION_HASH}" )
+endif()
 
 configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocmmod.in ${BUILD_DIR}/rocmmod @ONLY )
-configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm-core.postinst ${BUILD_DIR}/postinst @ONLY )
-configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm-core.prerm ${BUILD_DIR}/prerm @ONLY )
+
+# Setting Permission 0755 for pre/post install scripts
+configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm-core.postinst ${BUILD_DIR}/postinst
+	 FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE @ONLY )
+configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm-core.prerm ${BUILD_DIR}/prerm
+	 FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE @ONLY )
 
 #Generate BUILD_INFO
 configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm_version.h.in ${BUILD_DIR}/rocm_version.h @ONLY )
 configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/rocm_getpath.h.in ${BUILD_DIR}/rocm_getpath.h @ONLY )
-#File reorg Backward compatibility function
-if(NOT WIN32)
-    if(FILE_REORG_BACKWARD_COMPATIBILITY)
-    # To enabe/disable #error in wrapper header files
-        if(NOT DEFINED ROCM_HEADER_WRAPPER_WERROR)
-            if(DEFINED ENV{ROCM_HEADER_WRAPPER_WERROR})
-                set(ROCM_HEADER_WRAPPER_WERROR "$ENV{ROCM_HEADER_WRAPPER_WERROR}"
-                    CACHE STRING "Header wrapper warnings as errors.")
-            else()
-                set(ROCM_HEADER_WRAPPER_WERROR "OFF" CACHE STRING "Header wrapper warnings as errors.")
-            endif()
-        endif()
-
-        if(ROCM_HEADER_WRAPPER_WERROR)
-            set(deprecated_error 1)
-        else()
-            set(deprecated_error 0)
-        endif()
-
-        include(rocm-core-backward-compat.cmake)
-    endif() #FILE_REORG_BACKWARD_COMPATIBILITY
-endif()
 
 #Make the rocmlib
 set( SRCS rocm_version.cpp rocm_getpath.cpp)
@@ -110,34 +119,20 @@ set( SO_VERSION_STRING "${SO_MAJOR}.${SO_MINOR}.${ROCM_LIBPATCH_VERSION}" )
 set_property( TARGET ${CORE_TARGET} PROPERTY VERSION "${SO_VERSION_STRING}" )
 set_property( TARGET ${CORE_TARGET} PROPERTY SOVERSION "${SO_MAJOR}" )
 
-if(ENABLE_ASAN_PACKAGING)
-  # Only libraries required for ASAN Package
-  set( CPACK_COMPONENTS_ALL CORE_ASAN )
-  set( COMP_TYPE "CORE_ASAN" )
-  set( PKG_DESCRIPTION "Radeon Open Compute (ROCm) AddressSanitizer Instrumented Runtime software stack" )
+#Add the libpatch version if available to the version file
+if( DEFINED VERSION_POINT )
+  file ( WRITE "${CMAKE_CURRENT_BINARY_DIR}/version" "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}.${VERSION_POINT}\n" )
 else()
-  if(BUILD_SHARED_LIBS)
-    set( CPACK_COMPONENTS_ALL CORE_RUNTIME )
-    set( COMP_TYPE "CORE_RUNTIME" )
-    set( PKG_DESCRIPTION "Radeon Open Compute (ROCm) Runtime software stack" )
-  else()
-    set( CPACK_COMPONENTS_ALL CORE_STATIC )
-    set( STATIC_COMP_TYPE "CORE_STATIC" )
-    set( PKG_DESCRIPTION "Radeon Open Compute (ROCm) Static software stack" )
-  endif()
+  file ( WRITE "${CMAKE_CURRENT_BINARY_DIR}/version" "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}\n" )
 endif()
 
-#intallation directive
-file ( WRITE "${CMAKE_CURRENT_BINARY_DIR}/version" "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}-${BUILD_ID}\n" )
-
 ## Support for Static and Shared Target Packaging
 if(BUILD_SHARED_LIBS)
-  install ( FILES ${CMAKE_CURRENT_BINARY_DIR}/version DESTINATION .info COMPONENT CORE_RUNTIME )
+  install ( FILES ${BUILD_DIR}/version DESTINATION .info COMPONENT CORE_RUNTIME )
 
   # Target Library needs to installed/packaged to same destination
   # in both ASAN and nonASAN Shared library builds
-  install ( TARGETS ${CORE_TARGET} DESTINATION ${CMAKE_INSTALL_LIBDIR}
-            PERMISSIONS OWNER_WRITE OWNER_READ OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
+  install ( TARGETS ${CORE_TARGET} EXPORT rocmCoreTargets DESTINATION ${CMAKE_INSTALL_LIBDIR}
             COMPONENT ${COMP_TYPE} )
   install ( FILES ${BUILD_DIR}/rocm_version.h ${BUILD_DIR}/rocm_getpath.h
             DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/rocm-core
@@ -146,22 +141,20 @@ if(BUILD_SHARED_LIBS)
   install ( FILES ${CMAKE_CURRENT_SOURCE_DIR}/runpath_to_rpath.py
             DESTINATION ${CMAKE_INSTALL_LIBEXECDIR}/rocm-core
             COMPONENT CORE_RUNTIME )
-  install ( FILES ${CMAKE_CURRENT_BINARY_DIR}/rocmmod
+  install ( FILES ${BUILD_DIR}/rocmmod
             DESTINATION ${CMAKE_INSTALL_LIBDIR}
             COMPONENT CORE_RUNTIME )
 
   # License file
-  install ( FILES ${COPYRIGHT_FILE}
+  install ( FILES ${LICENSE_FILE}
             DESTINATION ${CMAKE_INSTALL_DOCDIR} RENAME LICENSE.txt
             COMPONENT CORE_RUNTIME)
-  install ( FILES ${COPYRIGHT_FILE} DESTINATION
-            ${CMAKE_INSTALL_DOCDIR}-asan RENAME LICENSE.txt
-            COMPONENT CORE_ASAN)
 else()
-  install ( FILES ${CMAKE_CURRENT_BINARY_DIR}/version
+  install ( FILES ${BUILD_DIR}/version
             DESTINATION .info
             COMPONENT ${STATIC_COMP_TYPE} )
   install ( TARGETS ${CORE_TARGET}
+            EXPORT rocmCoreTargets
             DESTINATION ${CMAKE_INSTALL_LIBDIR}
             COMPONENT ${STATIC_COMP_TYPE} )
 
@@ -172,25 +165,66 @@ else()
   install ( FILES ${CMAKE_CURRENT_SOURCE_DIR}/runpath_to_rpath.py
             DESTINATION ${CMAKE_INSTALL_LIBEXECDIR}/rocm-core
             COMPONENT ${STATIC_COMP_TYPE} )
-  install ( FILES ${CMAKE_CURRENT_BINARY_DIR}/rocmmod
+  install ( FILES ${BUILD_DIR}/rocmmod
             DESTINATION ${CMAKE_INSTALL_LIBDIR}
             COMPONENT ${STATIC_COMP_TYPE} )
   # License file
-  install ( FILES ${COPYRIGHT_FILE}
+  install ( FILES ${LICENSE_FILE}
             DESTINATION ${CMAKE_INSTALL_DOCDIR} RENAME LICENSE.txt
             COMPONENT ${STATIC_COMP_TYPE})
 endif()
 
+## Cmake module config file configurations
+set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules/" CACHE INTERNAL "Default module path.")
+
+## Export the package for use from the build-tree
+## (this registers the build-tree with a global CMake-registry)
+export(PACKAGE ${CORE_TARGET})
+set(CONF_LIB_DIR "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}")
+
+## Create the rocm-core-config.cmake and rocm-core-config-version files
+include(CMakePackageConfigHelpers)
+set(CONFIG_PACKAGE_INSTALL_DIR ${CONF_LIB_DIR}/cmake/${CORE_TARGET})
+set(LIB_INSTALL_DIR  "${CMAKE_INSTALL_LIBDIR}")
+set(INCLUDE_INSTALL_DIR  "${CMAKE_INSTALL_INCLUDEDIR}")
+set(BIN_INSTALL_DIR  "${CMAKE_INSTALL_BINDIR}")
+set(PKG_MAINTAINER_NM  "ROCm Dev Support")
+set(PKG_MAINTAINER_EMAIL  "rocm-dev.support@amd.com")
+
+## Generate Config File for rocm-core
+configure_package_config_file(
+    ${CMAKE_MODULE_PATH}/${CORE_TARGET}-config.cmake.in
+    ${BUILD_DIR}/${CORE_TARGET}-config.cmake
+    INSTALL_DESTINATION ${CONFIG_PACKAGE_INSTALL_DIR}
+    PATH_VARS LIB_INSTALL_DIR INCLUDE_INSTALL_DIR BIN_INSTALL_DIR
+)
+
+## Generate config Version File for rocm-core
+write_basic_package_version_file(
+    ${BUILD_DIR}/${CORE_TARGET}-config-version.cmake
+    VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}"
+    COMPATIBILITY SameMajorVersion)
+
+## Install the rocm-core-config.cmake and rocm-core-config-version.cmake
+install(FILES
+    "${PROJECT_BINARY_DIR}/${CORE_TARGET}-config.cmake"
+    "${PROJECT_BINARY_DIR}/${CORE_TARGET}-config-version.cmake"
+    DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${CORE_TARGET}"
+    COMPONENT ${COMP_TYPE})
+
+## Install the export set for use with the install-tree
+install(EXPORT rocmCoreTargets DESTINATION
+    "${CMAKE_INSTALL_LIBDIR}/cmake/${CORE_TARGET}" COMPONENT ${COMP_TYPE})
 
 ## Packaging directives
 set ( CPACK_PACKAGE_VENDOR "Advanced Micro Devices, Inc." )
 set ( CPACK_PACKAGE_VERSION_MAJOR ${VERSION_MAJOR} )
 set ( CPACK_PACKAGE_VERSION_MINOR ${VERSION_MINOR} )
 set ( CPACK_PACKAGE_VERSION_PATCH ${VERSION_PATCH} )
 set ( CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}" )
-set ( CPACK_PACKAGE_CONTACT "ROCm Dev Support <rocm-dev.support@amd.com>" )
+set ( CPACK_PACKAGE_CONTACT "${PKG_MAINTAINER_NM} <${PKG_MAINTAINER_EMAIL}>" )
 set ( CPACK_PACKAGE_DESCRIPTION_SUMMARY "${PKG_DESCRIPTION}" )
-set ( CPACK_RESOURCE_FILE_LICENSE "${COPYRIGHT_FILE}" )
+set ( CPACK_RESOURCE_FILE_LICENSE "${LICENSE_FILE}" )
 ## packaging variables
 if ( DEFINED ROCM_LIBPATCH_VERSION )
   set ( CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION}.${ROCM_LIBPATCH_VERSION}" )
@@ -207,6 +241,13 @@ set ( CPACK_DEBIAN_CORE_STATIC_PACKAGE_NAME ${CORE_TARGET} )
 message ( STATUS "Using CPACK_DEBIAN_PACKAGE_RELEASE ${CPACK_DEBIAN_PACKAGE_RELEASE}" )
 set ( CPACK_DEBIAN_FILE_NAME "DEB-DEFAULT" )
 
+# Debian specific packaging configuration
+if(COMP_TYPE)
+configure_debian_pkg( ${CORE_TARGET} ${COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${PKG_MAINTAINER_NM} ${PKG_MAINTAINER_EMAIL} )
+elseif(STATIC_COMP_TYPE)
+configure_debian_pkg( ${CORE_TARGET} ${STATIC_COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${PKG_MAINTAINER_NM} ${PKG_MAINTAINER_EMAIL} )
+endif()
+
 ## RPM package specific variables
 set ( CPACK_RPM_COMPONENT_INSTALL ON )
 set ( CPACK_RPM_CORE_RUNTIME_PACKAGE_NAME "${CORE_TARGET}" )
@@ -215,7 +256,6 @@ set ( CPACK_RPM_CORE_ASAN_PACKAGE_NAME ${CORE_TARGET}-asan )
 # STATIC package name - For Now, No change for static package Name from default
 set ( CPACK_RPM_CORE_STATIC_PACKAGE_NAME ${CORE_TARGET} )
 
-
 ## 'dist' breaks manual builds on debian systems due to empty Provides
 execute_process( COMMAND rpm --eval %{?dist}
                  RESULT_VARIABLE PROC_RESULT
@@ -230,28 +270,32 @@ set ( CPACK_RPM_FILE_NAME "RPM-DEFAULT" )
 
 # Debian package specific variables
 set ( CPACK_DEBIAN_PACKAGE_DEPENDS ${DEB_DEPENDS_STRING} )
-set ( CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/RadeonOpenCompute/ROCm" )
+set ( CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/ROCm/rocm-core" )
+set ( CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${BUILD_DIR}/postinst;${BUILD_DIR}/prerm" )
 set ( CPACK_DEBIAN_CORE_ASAN_PACKAGE_DEPENDS ${CORE_TARGET} )
-set ( CPACK_DEBIAN_CORE_RUNTIME_PACKAGE_CONTROL_EXTRA "${BUILD_DIR}/postinst;${BUILD_DIR}/prerm" )
-set ( CPACK_DEBIAN_CORE_STATIC_PACKAGE_CONTROL_EXTRA "${BUILD_DIR}/postinst;${BUILD_DIR}/prerm" )
+set ( CPACK_DEBIAN_CORE_RUNTIME_PACKAGE_CONTROL_EXTRA "${CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA}" )
+set ( CPACK_DEBIAN_CORE_STATIC_PACKAGE_CONTROL_EXTRA "${CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA}" )
+set ( CPACK_DEBIAN_PACKAGE_DESCRIPTION "${EXTENDED_PACKAGE_DESCRIPTION}" )
 
 ## RPM package specific variables
 set ( CPACK_RPM_PACKAGE_REQUIRES ${RPM_DEPENDS_STRING} )
 set ( CPACK_RPM_PACKAGE_LICENSE "MIT" )
 set ( CPACK_RPM_CORE_ASAN_PACKAGE_REQUIRES ${CORE_TARGET} )
-set ( CPACK_RPM_CORE_RUNTIME_POST_INSTALL_SCRIPT_FILE "${CMAKE_CURRENT_BINARY_DIR}/postinst" )
-set ( CPACK_RPM_CORE_RUNTIME_POST_UNINSTALL_SCRIPT_FILE "${CMAKE_CURRENT_BINARY_DIR}/prerm" )
-set ( CPACK_RPM_CORE_STATIC_POST_INSTALL_SCRIPT_FILE "${CMAKE_CURRENT_BINARY_DIR}/postinst" )
-set ( CPACK_RPM_CORE_STATIC_POST_UNINSTALL_SCRIPT_FILE "${CMAKE_CURRENT_BINARY_DIR}/prerm" )
+set ( CPACK_RPM_CORE_RUNTIME_POST_INSTALL_SCRIPT_FILE "${BUILD_DIR}/postinst" )
+set ( CPACK_RPM_CORE_RUNTIME_POST_UNINSTALL_SCRIPT_FILE "${BUILD_DIR}/prerm" )
+set ( CPACK_RPM_CORE_STATIC_POST_INSTALL_SCRIPT_FILE "${BUILD_DIR}/postinst" )
+set ( CPACK_RPM_CORE_STATIC_POST_UNINSTALL_SCRIPT_FILE "${BUILD_DIR}/prerm" )
+set ( CPACK_RPM_PACKAGE_DESCRIPTION "${EXTENDED_PACKAGE_DESCRIPTION}" )
 
 if ( DEFINED CPACK_PACKAGING_INSTALL_PREFIX )
-    set ( CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION "${CPACK_PACKAGING_INSTALL_PREFIX} ${CPACK_PACKAGING_INSTALL_PREFIX}/.info" )
-endif ( )
+    set ( CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION 
+          "${CPACK_PACKAGING_INSTALL_PREFIX} ${CPACK_PACKAGING_INSTALL_PREFIX}/.info" )
+endif()
+
 # Backward compatibility support for deprecated package rocm-clang-ocl
 # TODO: To be removed after two releases
 set(CPACK_DEBIAN_RUNTIME_PACKAGE_REPLACES "rocm-clang-ocl")
 set(CPACK_DEBIAN_RUNTIME_PACKAGE_CONFLICTS "rocm-clang-ocl")
-
 set(CPACK_RPM_RUNTIME_PACKAGE_OBSOLETES "rocm-clang-ocl")
 
 ## Include packaging

projects/rocm-core/CODEOWNERS

@@ -1 +1 @@
-* @nunnikri @frepaul @raramakr @ashutom @amd-isparry
+* @nunnikri @frepaul @raramakr @ashutom @amd-isparry @arvindcheru