-
Notifications
You must be signed in to change notification settings - Fork 180
Description
Problem Description
rocprofiler-register provides options to use system glog and fmt:
rocm-systems/projects/rocprofiler-register/cmake/rocprofiler_register_options.cmake
Lines 37 to 38 in 2e93b9f
| rocprofiler_register_add_option(ROCPROFILER_REGISTER_BUILD_GLOG "Build GLOG" ON) | |
| rocprofiler_register_add_option(ROCPROFILER_REGISTER_BUILD_FMT "Build FMT" ON) |
When these options are set rocprofiler-register's build will fail as these packages do not export the glog::glog or fmt::fmt targets that it expects. It seems that only the vendored build works.
Additionally rocprofiler-register/cmake/rocprofiler_register_config_packaging.cmake will crash when not using the vendored deps due to using cpack functions without calling include(CPack). It works with the vendored deps because one of them happens to always call include(CPack).
I think it might be best if rocprofiler-register required an opt-in to use vendored/fetched submodule dependencies rather than defaulting to it, in line with the behavior of deps in other places like rocm-libraries/hipblaslt.
Operating System
NixOS 25.11 (unstable)