From ae107ab61b1a5e944d32e3ccff078442975f5bd5 Mon Sep 17 00:00:00 2001 From: Danylo Lytovchenko Date: Tue, 3 Feb 2026 10:01:14 +0100 Subject: [PATCH 1/4] Bump TheRock version to enable hip-tests execution --- .github/workflows/therock-ci-linux.yml | 3 +-- .github/workflows/therock-ci-windows.yml | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index f85aa81d7de..4ce487201dd 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -8,7 +8,6 @@ on: project_to_test: type: string - permissions: contents: read @@ -38,7 +37,7 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: f5524a6ddbd928ec9a036002fdd8531c1a6f5eb2 # 2026-01-13 commit - name: Install python deps run: | diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index 5833b40744e..11c0721131c 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -39,12 +39,12 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: f5524a6ddbd928ec9a036002fdd8531c1a6f5eb2 # 2026-01-13 commit - name: Set up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 with: - python-version: '3.12' + python-version: "3.12" - name: Install python deps run: | @@ -70,7 +70,7 @@ jobs: - uses: iterative/setup-dvc@4bdfd2b0f6f1ad7e08afadb03b1a895c352a5239 # v2.0.0 with: - version: '3.62.0' + version: "3.62.0" # After other installs, so MSVC get priority in the PATH. - name: Configure MSVC From 093d6c773271e8606f70ff980cadc7759c80bf07 Mon Sep 17 00:00:00 2001 From: Danylo Lytovchenko Date: Tue, 3 Feb 2026 10:28:33 +0100 Subject: [PATCH 2/4] Bump TheRock version to the arch-dependent hip-tests version --- .github/workflows/therock-ci-linux.yml | 2 +- .github/workflows/therock-ci-windows.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/therock-ci-linux.yml b/.github/workflows/therock-ci-linux.yml index 4ce487201dd..6e968d6a746 100644 --- a/.github/workflows/therock-ci-linux.yml +++ b/.github/workflows/therock-ci-linux.yml @@ -37,7 +37,7 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: f5524a6ddbd928ec9a036002fdd8531c1a6f5eb2 # 2026-01-13 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit - name: Install python deps run: | diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index 11c0721131c..695668c0de7 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -39,7 +39,7 @@ jobs: with: repository: "ROCm/TheRock" path: "TheRock" - ref: f5524a6ddbd928ec9a036002fdd8531c1a6f5eb2 # 2026-01-13 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit - name: Set up Python uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0 From a71c34a08c6d04c46b1eb46a47863854e2eaabdd Mon Sep 17 00:00:00 2001 From: Danylo Lytovchenko Date: Tue, 3 Feb 2026 12:30:22 +0100 Subject: [PATCH 3/4] Make small formatting change to test the hip-tests trigger --- projects/hip-tests/catch/unit/assertion/assert.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/hip-tests/catch/unit/assertion/assert.cc b/projects/hip-tests/catch/unit/assertion/assert.cc index 07cc8f5fbab..f994dcdae23 100644 --- a/projects/hip-tests/catch/unit/assertion/assert.cc +++ b/projects/hip-tests/catch/unit/assertion/assert.cc @@ -74,7 +74,6 @@ bool isAbortOnErrorEnabled() { * - HIP_VERSION >= 5.2 */ TEST_CASE("Unit_Assert_Positive_Basic_KernelPass") { - #ifdef NDEBUG HipTest::HIP_SKIP_TEST("Assertions are disabled on this build."); return; @@ -116,7 +115,6 @@ TEST_CASE("Unit_Assert_Positive_Basic_KernelPass") { * - HIP_VERSION >= 5.2 */ TEST_CASE("Unit_Assert_Positive_Basic_KernelFail") { - #ifdef NDEBUG HipTest::HIP_SKIP_TEST("Assertions are disabled on this build."); return; @@ -146,6 +144,7 @@ TEST_CASE("Unit_Assert_Positive_Basic_KernelFail") { #endif } + /** * End doxygen group DeviceLanguageTest. * @} From 0c414f1b246ce1352fd03f5714f1b1b58934bd25 Mon Sep 17 00:00:00 2001 From: Danylo Lytovchenko Date: Tue, 3 Feb 2026 13:32:27 +0100 Subject: [PATCH 4/4] Bump theRock version in test-packages action --- .github/workflows/therock-test-packages.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/therock-test-packages.yml b/.github/workflows/therock-test-packages.yml index c1a063f5fa9..96a6e646df4 100644 --- a/.github/workflows/therock-test-packages.yml +++ b/.github/workflows/therock-test-packages.yml @@ -29,7 +29,7 @@ jobs: sparse-checkout: build_tools path: "prejob" repository: "ROCm/TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit # Checkout failure is possible on Windows, as it's the first job on a GPU test runner. # Post-job cleanup isn't necessary since no executables are launched in this job. @@ -42,7 +42,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 with: repository: "ROCm/TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit - name: "Configuring CI options" env: @@ -52,7 +52,7 @@ jobs: run: python ./build_tools/github_actions/fetch_test_configurations.py test_components: - name: 'Test ${{ matrix.components.job_name }}' + name: "Test ${{ matrix.components.job_name }}" runs-on: ${{ inputs.test_runs_on }} container: image: ${{ inputs.platform == 'linux' && 'ghcr.io/rocm/no_rocm_image_ubuntu24_04@sha256:405945a40deaff9db90b9839c0f41d4cba4a383c1a7459b28627047bf6302a26' || null }} @@ -84,7 +84,7 @@ jobs: sparse-checkout: build_tools path: "prejob" repository: "ROCm/TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit - name: Pre-job cleanup processes on Windows if: ${{ runner.os == 'Windows' }} @@ -95,10 +95,10 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 with: repository: "ROCm/TheRock" - ref: df5e21e3b8449ade0af12bcf94c0113510e97f6d # 2025-12-30 commit + ref: 83d82a1665a79e3a63ea53df1588e12bb7a75835 # 2026-01-16 commit - name: Run setup test environment workflow - uses: './.github/actions/setup_test_environment' + uses: "./.github/actions/setup_test_environment" with: ARTIFACT_RUN_ID: ${{ env.ARTIFACT_RUN_ID }} ARTIFACT_GROUP: ${{ inputs.amdgpu_families }}