Skip to content

Commit 09b6ef4

Browse files
Fixed duplicate keys in analysis_configs yamls (#707)
* fixed duplicate keys in analysis_configs yamls * Fix: removed TODO comment Signed-off-by: James Siddeley <james.siddeley@amd.com> --------- Signed-off-by: James Siddeley <james.siddeley@amd.com>
1 parent 41dd4aa commit 09b6ef4

File tree

3 files changed

+2
-19
lines changed

3 files changed

+2
-19
lines changed

src/rocprof_compute_soc/analysis_configs/gfx906/1000_compute-unit-instruction-mix.yaml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -218,12 +218,6 @@ Panel Config:
218218
max: MAX((TA_BUFFER_WAVEFRONTS_sum / $denom))
219219
unit: (instr + $normUnit)
220220
tips:
221-
Spill/Stack Coalesceable Instr:
222-
avg: None # No perf counter
223-
min: None # No perf counter
224-
max: None # No perf counter
225-
unit: (instr + $normUnit)
226-
tips:
227221
Spill/Stack Read:
228222
avg: AVG((TA_BUFFER_READ_WAVEFRONTS_sum / $denom))
229223
min: MIN((TA_BUFFER_READ_WAVEFRONTS_sum / $denom))
@@ -290,10 +284,10 @@ Panel Config:
290284
max: None # No HW module
291285
unit: (instr + $normUnit)
292286
tips:
293-
# TODO: Fix baseline comparision logic to handle non existent metrics, then
287+
# TODO: Fix baseline comparision logic to handle non existent metrics, then
294288
MFMA-F6F4:
295289
avg: None
296290
min: None
297291
max: None
298292
unit: (instr + $normUnit)
299-
tips:
293+
tips:

src/rocprof_compute_soc/analysis_configs/gfx940/1000_compute-unit-instruction-mix.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,9 @@ Panel Config:
281281
min: MIN((SQ_INSTS_VALU_MFMA_F64 / $denom))
282282
max: MAX((SQ_INSTS_VALU_MFMA_F64 / $denom))
283283
unit: (instr + $normUnit)
284-
# TODO: Fix baseline comparision logic to handle non existent metrics, then
285284
MFMA-F6F4:
286285
avg: None
287286
min: None
288287
max: None
289288
unit: (instr + $normUnit)
290289
tips:
291-
tips:

src/rocprof_compute_soc/analysis_configs/gfx950/1700_L2_cache.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,6 @@ Panel Config:
5252
unit: Unit
5353
tips: Tips
5454
metric:
55-
Read BW:
56-
avg: AVG((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
57-
* 64)) / $denom))
58-
min: MIN((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
59-
* 64)) / $denom))
60-
max: MAX((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
61-
* 64)) / $denom))
62-
unit: (Bytes + $normUnit)
63-
tips:
6455
Read BW:
6556
avg: AVG((((TCC_EA0_RDREQ_32B_sum * 32) + (TCC_EA0_RDREQ_64B_sum * 64) + (TCC_EA0_RDREQ_128B_sum * 128)) / $denom))
6657
min: MIN((((TCC_EA0_RDREQ_32B_sum * 32) + (TCC_EA0_RDREQ_64B_sum * 64) + (TCC_EA0_RDREQ_128B_sum * 128)) / $denom))

0 commit comments

Comments
 (0)