Skip to content

Commit 48b686d

Browse files
ammarwaammarwa
authored
CI: Enabling Navi3 and Vega20 runners & PR Jira Addition (#32)
* Enabling Navi3 and Vega20 runners * Update continuous_integration.yml * Update continuous_integration.yml * Fixing Github Actions issues * Fixing docs workflow * Fixing docs workflow miniconda3 location * Fixing docs workflow env setup * Fixing docs workflow env setup * Fixing docs workflow miniconda3 env * Fixing docs source build workflow * Balancing between navi3, vega20, mi300, mi200 * git sync workflow update * Adding Jira ticket place holder in PR Description * Fixing RHEL & SLES Builds * Fixing RHEL & SLES Builds * Fixing RHEL & SLES Builds * Fixing Re-run workflow * Update pull_request_template.md * Update continuous_integration.yml --------- Co-authored-by: Ammar ELWazir <aelwazir@amd.com> [ROCm/rocprofiler-sdk commit: f16c87f]
1 parent 398b5b5 commit 48b686d

File tree

8 files changed

+246
-171
lines changed

8 files changed

+246
-171
lines changed

‎.github/pull_request_template.md‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11

22
# PR Details
33

4+
## Associated Jira Ticket Number/Link
5+
46
## What type of PR is this? (check all applicable)
57

68
- [ ] Refactor
@@ -11,18 +13,18 @@
1113

1214
## Technical details
1315

14-
_Please explain the changes along with JIRA/Github link(if applies)._
16+
<!-- Please explain the changes along with JIRA/Github link(if applies). -->
1517

1618
## Added/updated tests?
1719

18-
_We encourage you to keep the code coverage percentage at 80% and above._
20+
<!-- We encourage you to keep the code coverage percentage at 80% and above. -->
1921

2022
- [ ] Yes
2123
- [ ] No, Does not apply to this PR.
2224

2325
## Updated CHANGELOG?
2426

25-
_Needed for Release updates for a ROCm release._
27+
<!-- Needed for Release updates for a ROCm release. -->
2628

2729
- [ ] Yes
2830
- [ ] No, Does not apply to this PR.

‎.github/workflows/continuous_integration.yml‎

Lines changed: 45 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
# define this for containers
4141
env:
4242
GIT_DISCOVERY_ACROSS_FILESYSTEM: 1
43-
CORE_EXT_RUNNER: mi200
43+
CORE_EXT_RUNNER: mi300
4444

4545
steps:
4646
- uses: actions/checkout@v4
@@ -277,7 +277,7 @@ jobs:
277277
strategy:
278278
# fail-fast: false
279279
matrix:
280-
runner: ['mi300-emu']
280+
runner: ['vega20-emu']
281281
os: ['ubuntu-22.04']
282282
build-type: ['Release']
283283

@@ -465,13 +465,40 @@ jobs:
465465
with:
466466
github-token: ${{ secrets.TOKEN }}
467467
script: |
468-
const comment_body = process.env.COMMENT_BODY;
469-
github.rest.issues.createComment({
470-
issue_number: context.issue.number,
471-
owner: context.repo.owner,
472-
repo: context.repo.repo,
473-
body: comment_body
474-
})
468+
const commentIdentifier = '<!-- unique-comment-identifier -->'; // Use this to identify your comment
469+
const commentBody = `
470+
${commentIdentifier}
471+
` + process.env.COMMENT_BODY;
472+
473+
// Fetch existing comments
474+
const { data: comments } = await github.rest.issues.listComments({
475+
owner: context.repo.owner,
476+
repo: context.repo.repo,
477+
issue_number: context.payload.pull_request.number,
478+
});
479+
480+
// Check for an existing comment
481+
const existingComment = comments.find(comment => comment.body.includes(commentIdentifier));
482+
483+
if (existingComment) {
484+
// Update the existing comment
485+
await github.rest.issues.updateComment({
486+
owner: context.repo.owner,
487+
repo: context.repo.repo,
488+
comment_id: existingComment.id,
489+
body: commentBody,
490+
});
491+
core.info(`Updated comment with ID: ${existingComment.id}`);
492+
} else {
493+
// Create a new comment
494+
await github.rest.issues.createComment({
495+
owner: context.repo.owner,
496+
repo: context.repo.repo,
497+
issue_number: context.payload.pull_request.number,
498+
body: commentBody,
499+
});
500+
core.info('Created a new comment.');
501+
}
475502
476503
- name: Archive Code Coverage Data
477504
uses: actions/upload-artifact@v4
@@ -518,20 +545,19 @@ jobs:
518545
strategy:
519546
fail-fast: false
520547
matrix:
521-
runner: ['mi200-emu', 'mi300-emu']
548+
runner: ['vega20-emu', 'navi3-emu', mi300-emu]
522549
sanitizer: ['AddressSanitizer', 'ThreadSanitizer', 'LeakSanitizer', 'UndefinedBehaviorSanitizer']
523550
os: ['ubuntu-22.04']
524551
build-type: ['RelWithDebInfo']
525552
exclude:
526-
# - { runner: 'navi3-emu', sanitizer: 'ThreadSanitizer' }
527-
# - { runner: 'navi3-emu', sanitizer: 'LeakSanitizer' }
528-
# - { runner: 'vega20-emu', sanitizer: 'AddressSanitizer' }
529-
# - { runner: 'vega20-emu', sanitizer: 'LeakSanitizer' }
530-
- { runner: 'mi200-emu', sanitizer: 'LeakSanitizer' }
531-
- { runner: 'mi200-emu', sanitizer: 'AddressSanitizer' }
532-
# - { runner: 'mi300-emu', sanitizer: 'AddressSanitizer' }
533-
- { runner: 'mi300-emu', sanitizer: 'ThreadSanitizer' }
534-
- { runner: 'mi300-emu', sanitizer: 'UndefinedBehaviorSanitizer' }
553+
- { runner: 'vega20-emu', sanitizer: 'ThreadSanitizer' }
554+
- { runner: 'vega20-emu', sanitizer: 'AddressSanitizer' }
555+
- { runner: 'vega20-emu', sanitizer: 'UndefinedBehaviorSanitizer' }
556+
- { runner: 'mi300-emu', sanitizer: 'AddressSanitizer' }
557+
- { runner: 'mi300-emu', sanitizer: 'LeakSanitizer' }
558+
- { runner: 'navi3-emu', sanitizer: 'LeakSanitizer' }
559+
- { runner: 'navi3-emu', sanitizer: 'ThreadSanitizer' }
560+
- { runner: 'navi3-emu', sanitizer: 'UndefinedBehaviorSanitizer' }
535561

536562
if: ${{ contains(github.event_name, 'pull_request') }}
537563
runs-on: ${{ matrix.runner }}-runner-set

‎.github/workflows/docs.yml‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,23 @@ jobs:
4040
with:
4141
submodules: true
4242
- name: Install Conda
43-
uses: conda-incubator/setup-miniconda@v3
44-
with:
45-
miniconda-version: "latest"
46-
auto-activate-base: true
47-
activate-environment: ""
43+
shell: bash -el {0}
44+
run: |
45+
curl -O https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh
46+
bash ./Miniconda3-latest-Linux-x86_64.sh -b
4847
- name: Setup Pages
4948
uses: actions/configure-pages@v5
5049
- name: Create Docs Directory
5150
run:
5251
mkdir -p docs
53-
- name: Install Conda environment
54-
shell: bash -el {0}
55-
working-directory: source/docs
56-
run: |
57-
conda env create -n rocprofiler-docs -f environment.yml
5852
- name: Build Docs
5953
shell: bash -el {0}
6054
working-directory: source/docs
6155
run: |
56+
source /home/runner/.bashrc
57+
export PATH=/home/runner/miniconda3/bin:$PATH
58+
conda init
59+
conda env create -n rocprofiler-docs -f environment.yml
6260
source activate
6361
conda activate rocprofiler-docs
6462
../scripts/update-docs.sh
@@ -84,7 +82,7 @@ jobs:
8482
uses: actions/deploy-pages@v4
8583

8684
build-docs-from-source:
87-
runs-on: gpuless-runner-set
85+
runs-on: gpuless-emu-runner-set
8886
steps:
8987
- name: Checkout
9088
uses: actions/checkout@v4

‎.github/workflows/formatting.yml‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,6 @@ jobs:
4747
exit 1
4848
fi
4949
50-
- name: Create pull request
51-
if: failure()
52-
uses: googleapis/code-suggester@v4
53-
with:
54-
command: review
55-
pull_number: ${{ github.event.pull_request.number }}
56-
git_dir: '.'
57-
5850
source:
5951
runs-on: ubuntu-22.04
6052
env:
@@ -89,14 +81,6 @@ jobs:
8981
exit 1
9082
fi
9183
92-
- name: Create pull request
93-
if: failure()
94-
uses: googleapis/code-suggester@v4
95-
with:
96-
command: review
97-
pull_number: ${{ github.event.pull_request.number }}
98-
git_dir: '.'
99-
10084
python:
10185
runs-on: ubuntu-22.04
10286
strategy:
@@ -136,14 +120,6 @@ jobs:
136120
exit 1
137121
fi
138122
139-
- name: Create pull request
140-
if: failure()
141-
uses: googleapis/code-suggester@v4
142-
with:
143-
command: review
144-
pull_number: ${{ github.event.pull_request.number }}
145-
git_dir: '.'
146-
147123
missing-new-line:
148124
runs-on: ubuntu-22.04
149125

‎.github/workflows/generate_afar.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ on:
3232

3333
jobs:
3434
generate-packages-ubuntu-22:
35-
runs-on: rocprofiler-cluster-runner-set
35+
runs-on: mi300-emu-runner-set
3636

3737
steps:
3838

0 commit comments

Comments
 (0)