Skip to content

Commit 35fdfd8

Browse files
authored
Fix post merge test issues (#707)
* add another job and remove post merge tests * fix bug * use matrix
1 parent 7f35284 commit 35fdfd8

File tree

2 files changed

+25
-103
lines changed

2 files changed

+25
-103
lines changed

.github/workflows/amd_perf_kernel_Integration_tests.yml

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ on:
44
workflow_dispatch:
55
pull_request:
66
branches: [main_perf]
7-
merge_group:
8-
branches: [main_perf]
9-
types: [checks_requested]
7+
merge_group:
8+
branches: [main_perf]
9+
types: [checks_requested]
1010

1111
concurrency:
1212
group: ${{ github.ref }}
@@ -98,7 +98,9 @@ jobs:
9898
timeout-minutes: 90
9999
strategy:
100100
matrix:
101-
runner: ${{fromJson(needs.Runner-Preparation-AMD.outputs.matrix-HIP)}}
101+
runner: ${{ fromJson(needs.Runner-Preparation-AMD.outputs.matrix-HIP) }}
102+
triton_version: [local, upstream]
103+
fail-fast: false # disables failing the entire job when one matrix entry fails
102104
container:
103105
image: rocm/pytorch:latest
104106
options: --device=/dev/kfd --device=/dev/dri --security-opt seccomp=unconfined --group-add video --user root
@@ -117,13 +119,26 @@ jobs:
117119
run: |
118120
python3 -m pip install --upgrade pip
119121
python3 -m pip install lit matplotlib pandas
120-
- name: Install Triton
122+
- name: Install Triton (local or upstream)
123+
run: |
124+
if [ "${{ matrix.triton_version }}" = "local" ]; then
125+
echo "Installing Local Triton..."
126+
pip uninstall -y triton
127+
cd python
128+
pip install -v -e .
129+
pip install numpy==1.26.4
130+
else
131+
echo "Installing Upstream Triton..."
132+
pip uninstall -y triton
133+
pip install matplotlib pandas pytest
134+
git clone https://github.com/triton-lang/triton
135+
cd triton
136+
pip install --verbose -e python
137+
cd ..
138+
fi
139+
- name: Show Triton version
121140
run: |
122-
echo "PATH is '$PATH'"
123-
pip uninstall -y triton
124-
cd python
125-
pip install -v -e .
126-
pip install numpy==1.26.4
141+
pip show triton
127142
- name: Run Perf Kernels Unit Tests
128143
run: |
129144
pytest -vvv ./python/perf-kernels/flash-attention.py

.github/workflows/amd_perf_kernel_postmerge_tests.yml

Lines changed: 0 additions & 93 deletions
This file was deleted.

0 commit comments

Comments
 (0)