Skip to content

Commit 74b4b8d

Browse files
authored
Change misleading method name RocmComputeCapability::has_amd_matrix_core() to more suitable name has_amd_mat_acc_instructions() as gfx11xx do not have matrix cores, but support matrix acceleration instruction set known as WMMA. (#390)
1 parent 1944ee0 commit 74b4b8d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

xla/backends/gpu/codegen/triton/compilation_pipeline_rocm.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ absl::Status CreateTritonPipeline(
9494
pm->addPass(mlir::createLoopInvariantCodeMotionPass());
9595
pm->addPass(mlir::createCanonicalizerPass());
9696

97-
if (cc.has_amd_matrix_core()) {
97+
if (cc.has_amd_matrix_instr()) {
9898
pm->addPass(
9999
mlir::createTritonAMDGPUStreamPipeline({num_stages, 0, 0, false}));
100100
// TODO(ROCm) Modify when corresponding run time flags are introduced.
@@ -113,7 +113,7 @@ absl::Status CreateTritonPipeline(
113113
pm->addPass(mlir::createTritonAMDGPUInThreadTranspose());
114114
pm->addPass(mt::gpu::createTritonGPURemoveLayoutConversions());
115115
}
116-
if (cc.has_amd_matrix_core()) {
116+
if (cc.has_amd_matrix_instr()) {
117117
pm->addPass(mt::gpu::createTritonGPUReorderInstructions());
118118
}
119119
if (/*(use_block_pingpong == "none") ==*/false) {

xla/stream_executor/device_description.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ class RocmComputeCapability {
165165

166166
bool has_mfma_instr_support() const { return gfx9_mi100_or_later(); }
167167

168-
bool has_amd_matrix_core() const {
168+
bool has_amd_matrix_instr() const {
169169
return gfx9_mi100_or_later() || gfx12() || gfx11();
170170
}
171171

0 commit comments

Comments
 (0)