Asar prints warning/error IDs + test suite succeeds with them

Author: RPGHacker

README.md

@@ -39,7 +39,7 @@ These two characters should precede each test line, so that Asar sees them as co
 * 2 hex digits - a byte for it to check for 
   * You can specify more than one, like in the examples below, and it will automatically increment the offset.
 * A line starting with `+` tells the testing app to patch the SMW ROM instead of creating a new ROM
-* `errEXXXX` and `warnWXXXX` (where `XXXX` is an ID number) means that the test is expected to throw that specific error or warning while patching. The test will succeed only if the number and order of errors and warnings thrown exactly matches what's specified here. Be wary that Asar uses multiple passes and throws errors and warnings across multiple of them. This can make the actual order in which errors and warnings are thrown a bit unintuitive.
+* `errE{name}` and `warnW{name}` (where `{name}` is the name of an error or warning) means that the test is expected to throw that specific error or warning while patching. The test will succeed only if the number and order of errors and warnings thrown exactly matches what's specified here. Be wary that Asar uses multiple passes and throws errors and warnings across multiple of them. This can make the actual order in which errors and warnings are thrown a bit unintuitive.
 
 In addition to the format mentioned above, it's also possible to check for user prints a patch is expected to output (by `print`, `error`, `warn` or `assert` commands). This is done by starting the line with one of the following sequences:
 ```
@@ -61,17 +61,17 @@ This line tests that `22`, `20`, `80` and `90` were written to the ROM offset `0
 ;`007606 22 20 80 90
 ```
 
-This line tests that assembling the patch throws error `5117` twice and warning `1030` once.
+This line tests that assembling the patch throws error `Eunknown_command` twice and warning `Wfeature_deprecated` once.
 ```
-;`errE5117
-;`errE5117
-;`warnW1030
+;`errEunknown_command
+;`errEunknown_command
+;`warnWfeature_deprecated
 ```
 
-This line tests that the byte `FF` was written to the start of the ROM, that the string `This is a print.` was printed and that the string `This is a user error.` was output via the error command (which itself also causes error `E5159`to be thrown once).
+This line tests that the byte `FF` was written to the start of the ROM, that the string `This is a print.` was printed and that the string `This is a user error.` was output via the error command (which itself also causes error `Eerror_command` to be thrown once).
 ```
 ;`FF
 ;P>This is a print.
 ;E>This is a user error.
-;`errE5159
+;`errEerror_command
 ```

docs/changelog/index.html

@@ -71,6 +71,7 @@ <h3>Bug fixes:</h3>
 
 		<h3>Deprecated features:</h3>
 		<ul>
+			<li>Warning and error IDs: Asar now uses named warnings and errors. (p4plus2, RPG Hacker)</li>
 		</ul></div>
 
 		<hr />

src/asar-tests/test.cpp

@@ -534,8 +534,8 @@ int main(int argc, char * argv[])
 
 		int numiter = 1;
 
-		std::vector<int> expected_errors;
-		std::vector<int> expected_warnings;
+		std::vector<std::string> expected_errors;
+		std::vector<std::string> expected_warnings;
 		std::vector<std::string> expected_prints;
 		std::vector<std::string> expected_error_prints;
 		std::vector<std::string> expected_warn_prints;
@@ -604,30 +604,16 @@ int main(int argc, char * argv[])
 					if (strncmp(cur_word.c_str(), token, strlen(token)) == 0)
 					{
 						const char* idstr = cur_word.c_str() + strlen(token);
-						char* endpos = nullptr;
-						long int id = strtol(idstr, &endpos, 10);
 
-						if (endpos == nullptr || *endpos != '\0')
-						{
-							dief("Error: Invalid %s declaration!\n", token);
-						}
-
-						expected_errors.push_back((int)id);
+						expected_errors.push_back(idstr-1);
 					}
 
 					token = "warnW";
 					if (strncmp(cur_word.c_str(), token, strlen(token)) == 0)
 					{
 						const char* idstr = cur_word.c_str() + strlen(token);
-						char* endpos = nullptr;
-						long int id = strtol(idstr, &endpos, 10);
-
-						if (endpos == nullptr || *endpos != '\0')
-						{
-							dief("Error: Invalid %s declaration!\n", token);
-						}
 
-						expected_warnings.push_back((int)id);
+						expected_warnings.push_back(idstr-1);
 					}
 
 					if (pos > len) len = pos;
@@ -824,8 +810,8 @@ int main(int argc, char * argv[])
 		FILE * out = nullptr;
 #endif
 
-		std::vector<int> actual_errors;
-		std::vector<int> actual_warnings;
+		std::vector<std::string> actual_errors;
+		std::vector<std::string> actual_warnings;
 		std::vector<std::string> actual_prints;
 		std::vector<std::string> actual_error_prints;
 		std::vector<std::string> actual_warn_prints;
@@ -851,20 +837,20 @@ int main(int argc, char * argv[])
 					size_t found = log_line.find(token);
 					if (found != std::string::npos)
 					{
-						char* endpos = nullptr;
-						long int num = strtol(log_line.c_str() + found + strlen(token), &endpos, 10);
+						size_t found_end = log_line.find(')', found + 1);
 
-						if (endpos == nullptr || *endpos != ')')
+						if (found_end == std::string::npos)
 						{
-							dief("Error: Failed parsing error code from Asar output!\n");
+							dief("Error: Failed parsing error name from Asar output!\n");
 						}
 
-						actual_errors.push_back(num);
+						size_t start_pos = found + strlen(token) - 1;
+						actual_errors.push_back(log_line.substr(start_pos, found_end - start_pos));
 
 						// RPG Hacker: Check if it's the error command. If so, we also need to add a print as well.
 						{
 							std::string command_token = ": error command: ";
-							std::string remainder = endpos;
+							std::string remainder = log_line.substr(found_end+1);
 							size_t command_found = remainder.find(command_token);
 
 							if (command_found != std::string::npos)
@@ -877,7 +863,7 @@ int main(int argc, char * argv[])
 						{
 							std::string command_token_1 = ": Assertion failed: ";
 							std::string command_token_2 = " [assert ";
-							std::string remainder = endpos;
+							std::string remainder = log_line.substr(found_end + 1);
 							size_t command_found_1 = remainder.find(command_token_1);
 							size_t command_found_2 = remainder.find(command_token_2);
 
@@ -895,20 +881,20 @@ int main(int argc, char * argv[])
 					found = log_line.find(token);
 					if (found != std::string::npos)
 					{
-						char* endpos = nullptr;
-						long int num = strtol(log_line.c_str() + found + strlen(token), &endpos, 10);
+						size_t found_end = log_line.find(')', found + 1);
 
-						if (endpos == nullptr || *endpos != ')')
+						if (found_end == std::string::npos)
 						{
 							dief("Error: Failed parsing warning code from Asar output!\n");
 						}
 
-						actual_warnings.push_back(num);
+						size_t start_pos = found + strlen(token) - 1;
+						actual_warnings.push_back(log_line.substr(start_pos, found_end - start_pos));
 
 						// RPG Hacker: Check if it's the warn command. If so, we also need to add a print as well.
 						{
 							std::string command_token = ": warn command: ";
-							std::string remainder = endpos;
+							std::string remainder = log_line.substr(found_end + 1);
 							size_t command_found = remainder.find(command_token);
 
 							if (command_found != std::string::npos)
@@ -1000,28 +986,28 @@ int main(int argc, char * argv[])
 			printf("\nExpected errors: ");
 			for (auto it = expected_errors.begin(); it != expected_errors.end(); ++it)
 			{
-				printf("%sE%d", (it != expected_errors.begin() ? "," : ""), *it);
+				printf("%s%s", (it != expected_errors.begin() ? "," : ""), it->c_str());
 			}
 			printf("\n");
 
 			printf("Actual errors: ");
 			for (auto it = actual_errors.begin(); it != actual_errors.end(); ++it)
 			{
-				printf("%sE%d", (it != actual_errors.begin() ? "," : ""), *it);
+				printf("%s%s", (it != actual_errors.begin() ? "," : ""), it->c_str());
 			}
 			printf("\n");
 
 			printf("\nExpected warnings: ");
 			for (auto it = expected_warnings.begin(); it != expected_warnings.end(); ++it)
 			{
-				printf("%sW%d", (it != expected_warnings.begin() ? "," : ""), *it);
+				printf("%s%s", (it != expected_warnings.begin() ? "," : ""), it->c_str());
 			}
 			printf("\n");
 
 			printf("Actual warnings: ");
 			for (auto it = actual_warnings.begin(); it != actual_warnings.end(); ++it)
 			{
-				printf("%sW%d", (it != actual_warnings.begin() ? "," : ""), *it);
+				printf("%s%s", (it != actual_warnings.begin() ? "," : ""), it->c_str());
 			}
 			printf("\n");
 
@@ -1068,7 +1054,7 @@ int main(int argc, char * argv[])
 		fclose(rom);
 #endif
 		bool fail = false;
-		for (int i = 0;i < min(len, truelen);i++)
+		for (int i = 0;i < min(len, truelen); i++)
 		{
 			if (truerom[i] != expectedrom[i] && !(i >= 0x07FDC && i <= 0x07FDF && (expectedrom[i] == 0x00 || expectedrom[i] == smwrom[i])))
 			{