Skip to content

Commit daab80a

Browse files
committed
Set PDB_NAME to something other than asar
CMake was automatically setting the PDB_NAME to be asar.pdb, which on Windows conflicts with the dlls pdb name, since it's the same (asar.dll -> asar.pdb). This was giving arcane linker errors since it was trying to write the same file at the same time from 2 places and it completely broke debugging on Visual Studio, since it wasn't loading the debug symbols. Setting the PDB_NAME alone works fine, symbols load correctly and there are no linker errors. This was also tested on Linux to confirm that it works just fine, cmake just ignores the property but doesn't complain.
1 parent 2e24afb commit daab80a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/asar/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ if(ASAR_GEN_EXE)
209209
endif()
210210

211211
set_target_properties(asar-standalone PROPERTIES OUTPUT_NAME "asar")
212+
set_target_properties(asar-standalone PROPERTIES PDB_NAME "asar-standalone")
212213
endif(ASAR_GEN_EXE)
213214

214215

0 commit comments

Comments
 (0)