Skip to content

Commit ef15f2c

Browse files
committed
Remove unnecessary null URI parameters
1 parent 96c6a2b commit ef15f2c

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

src/main/java/net/rptools/maptool/client/macro/MacroLocation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public static MacroLocation parseMacroName(
197197
String macroName = qMacroName.substring(0, qMacroName.indexOf("@"));
198198
String location = qMacroName.substring(qMacroName.indexOf("@") + 1);
199199
String namespace = location.replaceFirst("(?i)lib:", "");
200-
return new MacroLocation(macroName, MacroSource.library, namespace, location, null);
200+
return new MacroLocation(macroName, MacroSource.library, namespace, location);
201201
}
202202

203203
if (qMacroNameLower.contains("@this")) {
@@ -212,7 +212,7 @@ public static MacroLocation parseMacroName(
212212
}
213213
}
214214
return new MacroLocation(
215-
name, cfrom.getSource(), cfrom.getLocation(), cfrom.getCallableLocation(), null);
215+
name, cfrom.getSource(), cfrom.getLocation(), cfrom.getCallableLocation());
216216
}
217217

218218
// If none of the above then assume it is a URI

src/main/java/net/rptools/maptool/client/macro/MacroLocationFactory.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ public MacroLocation createCampaignLocation(@Nonnull String name) {
8888
* @return a new {@link MacroLocation} object for a token.
8989
*/
9090
public MacroLocation createTokenLocation(@Nonnull String name, @Nonnull Token token) {
91-
return new MacroLocation(
92-
name, MacroSource.token, token.getName(), "Token:" + token.getName(), null);
91+
return new MacroLocation(name, MacroSource.token, token.getName(), "Token:" + token.getName());
9392
}
9493

9594
/**
@@ -101,7 +100,7 @@ public MacroLocation createTokenLocation(@Nonnull String name, @Nonnull Token to
101100
*/
102101
public MacroLocation createLibTokenLocation(@Nonnull String name, @Nonnull Token libToken) {
103102
return new MacroLocation(
104-
name, MacroSource.library, libToken.getName().substring(4), libToken.getName(), null);
103+
name, MacroSource.library, libToken.getName().substring(4), libToken.getName());
105104
}
106105

107106
/**
@@ -212,11 +211,8 @@ public MacroLocation createChatLocation() {
212211
* @return a new {@link MacroLocation} object for a tooltip.
213212
*/
214213
public MacroLocation createToolTipLocation(@Nullable Token token) {
214+
var location = token != null ? token.getName() : "";
215215
return new MacroLocation(
216-
MacroSource.tooltip.getSourceName(),
217-
MacroSource.tooltip,
218-
token != null ? token.getName() : "",
219-
token != null ? token.getName() : "",
220-
null);
216+
MacroSource.tooltip.getSourceName(), MacroSource.tooltip, location, location);
221217
}
222218
}

0 commit comments

Comments
 (0)