review corrections

Author: alinbutu

services/catalog/rs_server_catalog/user_catalog.py

@@ -1352,6 +1352,8 @@ async def dispatch(
                 and not self.request_ids["collection_ids"]
                 and response_content["code"] == "NotFoundError"
             ):
+                # Return empty list of properties and additionalProperties set to true on /catalog/queryables
+                # when there are no collections in catalog.
                 empty_catalog_queryables_response = {
                     "$id": f"{request.base_url}queryables",
                     "type": "object",

services/catalog/tests/conftest.py

@@ -477,7 +477,6 @@ def add_feature(client: TestClient, feature: Feature):
 @pytest.mark.integration
 @pytest.fixture(scope="session", autouse=True)
 def setup_database(
-    request,  # Inject pytest request object
     client,
     toto_s1_l1,
     toto_s2_l3,
@@ -506,10 +505,6 @@ def setup_database(
         user id titi.
     """
 
-    # If test is using `client_with_empty_catalog`, do nothing
-    if "client_with_empty_catalog" in request.fixturenames:
-        return
-
     add_collection(client, toto_s1_l1)
     add_collection(client, toto_s2_l3)
     add_collection(client, titi_s2_l1)