Fixes

Author: Padeanu

services/common/rs_server_common/stac_api_common.py

@@ -956,10 +956,8 @@ def check_input_type(field_info, key, input_value):
 
 def check_datetime_input(input_value: Any) -> bool:
     """Used to check if a parameter is a datetime-like string"""
-    if isinstance(input_value, str):  # If input is a string, try parsing it
-        try:
-            dt.fromisoformat(input_value)  # ISO 8601 format check
-            return True
-        except ValueError:
-            return False
-    return False  # Not a string, so it can't be a valid datetime
+    try:
+        dt.fromisoformat(input_value)  # ISO 8601 format check
+        return True
+    except ValueError:
+        return False

tests/test_search_endpoint.py

@@ -765,6 +765,12 @@ def test_adgs_feature_collection_mapping(self, client, mock_token_validation, ad
                 "and Retransfer eq True&$orderby=PublicationDate desc&$top=10&$skip=0",
                 status.HTTP_200_OK,
             ),
+            (
+                ROUTER_PREFIX_CADIP,
+                "/cadip/collections/cadip_session_by_satellite/items?filter=cadip:retransfer=should_be_bool",
+                "no_odata",
+                status.HTTP_422_UNPROCESSABLE_ENTITY,
+            ),
             (
                 ROUTER_PREFIX_CADIP,
                 "/cadip/collections/cadip_session_by_satellite/items?filter=cadip:num_channels=2",
@@ -821,20 +827,28 @@ def test_adgs_feature_collection_mapping(self, client, mock_token_validation, ad
                 "No odata",
                 status.HTTP_422_UNPROCESSABLE_ENTITY,
             ),
+            (
+                ROUTER_PREFIX_AUXIP,
+                "/auxip/collections/adgs_by_platform/items?filter=published=invalid_date_format2020",
+                "No odata",
+                status.HTTP_422_UNPROCESSABLE_ENTITY,
+            ),
         ],
         indirect=["fastapi_app"],
         ids=[
             "cadip",
             "cadip_id",
             "cadip_id_and_dt",
             "cadip_retransfer",
+            "cadip_retransfer_invalid",
             "cadip_numchans",
             "cadip_inv",
             "auxip",
             "auxip_name",
             "auxip_name_and_dt",
             "auxip_processing",
             "auxip_inv",
+            "auxip_inv_dt",
         ],
     )
     @responses.activate