Removed hardcoded value, added UT

Author: Padeanu

services/cadip/rs_server_cadip/api/cadip_search.py

@@ -474,7 +474,7 @@ def process_session_search(  # type: ignore # pylint: disable=too-many-arguments
     sortby: str,
     limit: Annotated[
         Union[int, None],
-        Query(gt=0, le=10000, default=1000, description="Pagination Limit"),
+        Query(gt=0, default=1000, description="Pagination Limit"),
     ],
     page: Union[int, None] = 1,
 ) -> stac_pydantic.ItemCollection:

tests/test_search_endpoint.py

@@ -903,6 +903,36 @@ def test_invalid_limit_values(self, client, endpoint):
             "Input should be greater than 0",
         )
 
+    @pytest.mark.unit
+    @pytest.mark.parametrize(
+        "endpoint, odata",
+        [
+            (
+                "/auxip/collections/s2_adgs2_AUX_OBMEMC/items?limit=10000000",
+                "http://127.0.0.1:5001/Products?$filter=Attributes/OData.CSC.StringAttribute/any(att:att/Name eq "
+                "'productType' and att/OData.CSC.StringAttribute/Value eq 'AUX_OBMEMC')&$orderby=PublicationDate "
+                "desc&$top=9999&$skip=0&$expand=Attributes",
+            ),
+            (
+                "/cadip/collections/cadip_session_by_id/items?limit=10000000",
+                "http://127.0.0.1:5000/Sessions?$filter=SessionId eq 'S1A_20200105072204051312'&$orderby="
+                "PublicationDate desc&$top=9999&$skip=0",
+            ),
+        ],
+    )
+    @responses.activate
+    def test_bigger_limit_than_allowed(self, client, mock_token_validation, endpoint, odata):
+        """
+        Test that if user request with a limit value bigger than max allowed in config
+        the limit value is set to max_allowed - 1.
+        Limit in request is set to 1_000_000, for given collection max allowed is set to 10000, therefore
+        in the final odata request, $top is set to 9999.
+        """
+        mock_token_validation()
+        responses.add(responses.GET, odata, json={"value": []}, status=200)
+        response = client.get(endpoint)
+        assert response.status_code == status.HTTP_200_OK
+
     @pytest.mark.unit
     @pytest.mark.parametrize(
         "endpoint",