review corrections

Author: Alin BUTU

services/common/rs_server_common/utils/utils.py

@@ -196,6 +196,25 @@ def map_auxip_prip_mission(platform: str, constellation: str) -> tuple[str | Non
     return platform_short_name, platform_serial_identifier
 
 
+def reverse_adgs_prip_map_mission(
+    platform: str | None,
+    constellation: str | None,
+) -> tuple[str | None, str | None]:
+    """Function used to re-map platform and constellation based on satellite value."""
+    if not (constellation or platform):
+        return None, None
+
+    if constellation:
+        constellation = constellation.lower()  # type: ignore
+
+    for satellite in map_stac_platform()["satellites"]:
+        for key, info in satellite.items():
+            # Check for matching serialid and constellation
+            if info.get("serialid") == platform and info.get("constellation").lower() == constellation:
+                return key, info.get("constellation")
+    return None, None
+
+
 def odata_to_stac(
     feature_template: dict,
     odata_dict: dict,

services/prip/rs_server_prip/api/prip_search.py

@@ -205,7 +205,30 @@ async def get_prip_collection_items(
     Args:
         collection_id (str): PRIP collection ID. Must be a valid collection identifier
                              (e.g., 'ins_s1').
+        bbox (BBoxType, optional): Bounding box filter as four or six numbers
+            [west, south, east, north] or [west, south, minz, east, north, maxz].
+            Defaults to None. If provided, items intersecting the bbox are returned.
 
+        datetime (DateTimeType, optional): Temporal filter. Either a single RFC 3339
+            timestamp/interval (e.g., "2024-01-01T00:00:00Z") or a closed/open interval
+            (e.g., "2024-01-01T00:00:00Z/2024-01-31T23:59:59Z", "../2024-01-01T00:00:00Z").
+            Defaults to None.
+
+        filter_ (FilterType, optional): CQL2 filter expression (text or JSON depending
+            on `filter_lang`). Defaults to None.
+
+        filter_lang (FilterLangType, optional): CQL2 language for `filter_`. One of
+            "cql2-text" or "cql2-json". Defaults to "cql2-text".
+
+        sortby (SortByType, optional): Sort specification. Single field or list of fields
+            with optional direction, e.g., {"field": "published", "direction": "desc"}.
+            Defaults to None (implementation default ordering).
+
+        limit (LimitType, optional): Page size (maximum number of items to return).
+            Defaults to None (service default / configured max).
+
+        page (PageType, optional): 1-based page index.
+            Defaults to None (first page).
     Returns:
         list[dict]: A FeatureCollection of items belonging to the specified collection, or an
                     error message if the collection is not found.

services/prip/rs_server_prip/prip_utils.py

@@ -30,7 +30,7 @@
 import stac_pydantic
 import yaml
 from fastapi import HTTPException, status
-from rs_server_common.utils.utils import map_stac_platform
+from rs_server_common.utils.utils import reverse_adgs_prip_map_mission
 
 PRIP_CONFIG = Path(osp.realpath(osp.dirname(__file__))).parent / "config"
 search_yaml = PRIP_CONFIG / "prip_search_config.yaml"
@@ -120,29 +120,10 @@ def serialize_prip_asset(feature_collection: stac_pydantic.ItemCollection, produ
     return feature_collection
 
 
-def prip_reverse_map_mission(
-    platform: str | None,
-    constellation: str | None,
-) -> tuple[str | None, str | None]:
-    """Function used to re-map platform and constellation based on satellite value."""
-    if not (constellation or platform):
-        return None, None
-
-    if constellation:
-        constellation = constellation.lower()  # type: ignore
-
-    for satellite in map_stac_platform()["satellites"]:
-        for key, info in satellite.items():
-            # Check for matching serialid and constellation
-            if info.get("serialid") == platform and info.get("constellation").lower() == constellation:
-                return key, info.get("constellation")
-    return None, None
-
-
 def prepare_collection(collection: stac_pydantic.ItemCollection) -> stac_pydantic.ItemCollection:
     """Used to create a more complex mapping on platform/constallation from odata to stac."""
     for feature in collection.features:
-        feature.properties.platform, feature.properties.constellation = prip_reverse_map_mission(
+        feature.properties.platform, feature.properties.constellation = reverse_adgs_prip_map_mission(
             feature.properties.platform,
             feature.properties.constellation,
         )