A game.xml mod above a gameconfig.bin mod will crash when loading levels

[ElspethThePict]

Before opening this issue, I ensure that...

• I have read the FAQ and confirmed my issue is not mentioned in it.
• I have checked both open and closed issues and confirmed this bug has not already been reported.
• I am not asking for tech support (e.g. game closing on startup, error when trying to build, etc).
• I am not asking for modding support or reporting a bug in a specific mod; this bug either occurs without mods enabled or is directly related to the mod loader.
• This bug is not related to any unofficial fork/port of the decompilation, and any issues with those should be kept in the appropriate repository.

Expected Behavior

Both mods load, XML additions applied over modified .bin config

Actual Behavior

Application crashes to desktop when loading a level that uses global scripts

Steps to Reproduce

1. Supply two mods, one with a modified gameconfig.bin and one with a game.xml that adds objects.
2. Place the game.xml mod above the other in the mod list and activate both.
3. Attempt to start a regular stage that uses global objects, like Green Hill Zone
4. Application closes

Screenshots

No response

Log File

No response

Decompilation Version

Current latest

Game

Sonic 1

Game Version

Mobile (Sega Forever)

Game Revision

No response

Platform

Windows 10

Additional Comments

No response

[ElspethThePict]

I've fixed this in my own fork by reversing the load order of XML files in

RetroEngine::LoadXMLVariables()
RetroEngine::LoadXMLPalettes()
RetroEngine::LoadXMLObjects()
RetroEngine::LoadXMLSoundFX()
RetroEngine::LoadXMLPlayers()
RetroEngine::LoadXMLStages()

In truth, this has likely simply moved the bug to affect XML mods placed below gameconfig.bin mods in the list but the expected behaviour there is already undesired (the gameconfig file overwrites the XML changes completely).

[ElspethThePict]

Other users have found that the mod without an xml doesn't need a gameconfig.bin to cause the crash, and adding even a blank game.xml file fixes the issue. Given that this issue also doesn't happen when there are no new global objects in the xml, I believe RetroEngine::LoadXMLObjects() is crashing when it fails to find an xml file.