Fix off-by-one error with legacy stage checks

MegAmi24 · MegAmi24 · commit b205ee1847e3 · 2025-03-29T11:04:41.000-05:00
Fixes #293
diff --git a/RSDKv5/RSDK/Scene/Legacy/v3/ScriptLegacyv3.cpp b/RSDKv5/RSDK/Scene/Legacy/v3/ScriptLegacyv3.cpp
@@ -4349,7 +4349,7 @@ void RSDK::Legacy::v3::ProcessScript(int32 scriptCodeStart, int32 jumpTableStart
                     case VAR_STAGELISTPOS: {
                         SceneListInfo *list = &sceneInfo.listCategory[sceneInfo.activeCategory];
 
-                        if (list->sceneOffsetStart + scriptEng.operands[i] < list->sceneOffsetEnd)
+                        if (list->sceneOffsetStart + scriptEng.operands[i] <= list->sceneOffsetEnd)
                             sceneInfo.listPos = list->sceneOffsetStart + scriptEng.operands[i];
                         break;
                     }
diff --git a/RSDKv5/RSDK/Scene/Legacy/v4/ScriptLegacyv4.cpp b/RSDKv5/RSDK/Scene/Legacy/v4/ScriptLegacyv4.cpp
@@ -5852,7 +5852,7 @@ void RSDK::Legacy::v4::ProcessScript(int32 scriptCodeStart, int32 jumpTableStart
                     case VAR_STAGELISTPOS: {
                         SceneListInfo *list = &sceneInfo.listCategory[sceneInfo.activeCategory];
 
-                        if (list->sceneOffsetStart + scriptEng.operands[i] < list->sceneOffsetEnd)
+                        if (list->sceneOffsetStart + scriptEng.operands[i] <= list->sceneOffsetEnd)
                             sceneInfo.listPos = list->sceneOffsetStart + scriptEng.operands[i];
                         break;
                     }

Original file line number	Diff line number	Diff line change
`@@ -4349,7 +4349,7 @@ void RSDK::Legacy::v3::ProcessScript(int32 scriptCodeStart, int32 jumpTableStart`
`4349`	`4349`	`case VAR_STAGELISTPOS: {`
`4350`	`4350`	`SceneListInfo *list = &sceneInfo.listCategory[sceneInfo.activeCategory];`
`4351`	`4351`
`4352`		`- if (list->sceneOffsetStart + scriptEng.operands[i] < list->sceneOffsetEnd)`
	`4352`	`+ if (list->sceneOffsetStart + scriptEng.operands[i] <= list->sceneOffsetEnd)`
`4353`	`4353`	`sceneInfo.listPos = list->sceneOffsetStart + scriptEng.operands[i];`
`4354`	`4354`	`break;`
`4355`	`4355`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5852,7 +5852,7 @@ void RSDK::Legacy::v4::ProcessScript(int32 scriptCodeStart, int32 jumpTableStart`
`5852`	`5852`	`case VAR_STAGELISTPOS: {`
`5853`	`5853`	`SceneListInfo *list = &sceneInfo.listCategory[sceneInfo.activeCategory];`
`5854`	`5854`
`5855`		`- if (list->sceneOffsetStart + scriptEng.operands[i] < list->sceneOffsetEnd)`
	`5855`	`+ if (list->sceneOffsetStart + scriptEng.operands[i] <= list->sceneOffsetEnd)`
`5856`	`5856`	`sceneInfo.listPos = list->sceneOffsetStart + scriptEng.operands[i];`
`5857`	`5857`	`break;`
`5858`	`5858`	`}`