Skip to content

Commit 4f79932

Browse files
committed
simplify existing tests
1 parent 2024e8f commit 4f79932

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/test_dynamodb.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def nested_query_data(nested_table):
256256

257257

258258
@pytest.fixture(scope="module")
259-
def nested_query_data_optional(nested_table):
259+
def nested_query_data_empty_ticket(nested_table):
260260
presets = [dict()] * 5
261261
data = [datum for datum in [nested_model_data_generator(include_ticket=False, **i) for i in presets]]
262262
for datum in data:
@@ -413,15 +413,13 @@ def test_query_scan_complex(dynamo, complex_query_data):
413413

414414

415415
def test_query_with_nested_model(dynamo, nested_query_data):
416-
data_by_expires = nested_model_data_generator()
417-
res = NestedModel.query(filter_expr=Rule(f"expires <= '{data_by_expires['expires']}'"))
416+
res = NestedModel.query()
418417
res_data = [m.ticket for m in res]
419418
assert any(elem is not None for elem in res_data)
420419

421420

422-
def test_query_with_nested_model_optional(dynamo, nested_query_data_optional):
423-
data_by_expires = nested_model_data_generator(include_ticket=False)
424-
res = NestedModel.query(filter_expr=Rule(f"expires <= '{data_by_expires['expires']}'"))
421+
def test_query_with_nested_model_optional(dynamo, nested_query_data_empty_ticket):
422+
res = NestedModel.query()
425423
res_data = [m.ticket for m in res]
426424
assert any(elem is None for elem in res_data)
427425

0 commit comments

Comments
 (0)