Merge pull request #4835 from RSSNext/release/desktop/1.3.0

release(desktop): Release v1.3.0

Author: DIYgod

.claude/skills/desktop-release/SKILL.md

@@ -0,0 +1,145 @@
+---
+name: desktop-release
+description: Perform a regular desktop release from the dev branch. Gathers commits since last release, updates changelog, evaluates mainHash changes, bumps version, and creates release PR.
+disable-model-invocation: true
+allowed-tools: Bash, Read, Write, Edit, Glob, Grep
+---
+
+# Desktop Regular Release
+
+Perform a regular desktop release. This skill handles the full release workflow from the `dev` branch.
+
+## Pre-flight checks
+
+1. Confirm the current branch is `dev`. If not, abort with a warning.
+2. Run `git pull --rebase` in the repo root to ensure the local branch is up to date.
+3. Read `apps/desktop/package.json` to get the current `version` and `mainHash`.
+
+## Step 1: Gather changes since last release
+
+1. Find the last release tag:
+   ```bash
+   git tag --sort=-creatordate | grep '^desktop/v' | head -1
+   ```
+2. Get all commits since that tag on the current branch:
+   ```bash
+   git log <last-tag>..HEAD --oneline --no-merges
+   ```
+3. Categorize commits into:
+   - **Shiny new things** (feat: commits, new features)
+   - **Improvements** (refactor:, perf:, chore: improvements, dependency updates)
+   - **No longer broken** (fix: commits, bug fixes)
+   - **Thanks** (identify external contributor GitHub usernames from commits)
+
+## Step 2: Update changelog
+
+1. Read `apps/desktop/changelog/next.md`.
+2. Present the categorized changes to the user and draft the changelog content.
+3. Wait for user confirmation or edits before writing.
+4. Write the final content to `apps/desktop/changelog/next.md`, following the template format:
+
+   ```markdown
+   # What's new in vNEXT_VERSION
+
+   ## Shiny new things
+
+   - description of new feature
+
+   ## Improvements
+
+   - description of improvement
+
+   ## No longer broken
+
+   - description of fix
+
+   ## Thanks
+
+   Special thanks to volunteer contributors @username for their valuable contributions
+   ```
+
+5. Keep `NEXT_VERSION` as the placeholder - it will be replaced by `apply-changelog.ts` during bump.
+
+## Step 3: Evaluate mainHash
+
+This is critical for determining whether users need a full app update or can use the lightweight renderer hot update.
+
+1. Check what files changed in `apps/desktop/layer/main/` since the last release tag:
+   ```bash
+   git diff <last-tag>..HEAD --name-only -- apps/desktop/layer/main/
+   ```
+2. Also check changes to `apps/desktop/package.json` fields other than version/mainHash (since package.json is included in the hash calculation):
+   ```bash
+   git diff <last-tag>..HEAD -- apps/desktop/package.json
+   ```
+
+**Decision logic:**
+
+- If there are **NO changes** in `layer/main/` and no meaningful `package.json` changes (only version/mainHash/changelog-related), then mainHash should NOT be updated. Users will get a fast renderer-only hot update.
+- If there are **trivial changes** in `layer/main/` (typo fixes, comment changes, logging tweaks) that don't affect runtime behavior, recommend NOT updating mainHash. Present the changes to the user and ask for confirmation.
+- If there are **meaningful changes** in `layer/main/` (new features, bug fixes, dependency changes, API changes), mainHash MUST be updated. Users will need a full app update.
+
+Present your analysis to the user with:
+
+- List of changed files in `layer/main/`
+- A summary of what changed
+- Your recommendation (update or skip mainHash)
+- Ask for explicit confirmation
+
+## Step 4: Save old mainHash and execute bump
+
+1. Save the current mainHash from `apps/desktop/package.json` for later comparison.
+2. Change directory to `apps/desktop/` and run the bump:
+   ```bash
+   cd apps/desktop && pnpm bump
+   ```
+3. This command will:
+   - Pull latest changes
+   - Apply changelog (rename next.md to {version}.md, create new next.md)
+   - Recalculate mainHash and write to package.json
+   - Format package.json
+   - Bump minor version
+   - Commit with message `release(desktop): release v{NEW_VERSION}`
+   - Create branch `release/desktop/{NEW_VERSION}`
+   - Push branch and create PR to `main`
+
+## Step 5: Restore mainHash if skipping update
+
+If Step 3 decided mainHash should NOT be updated, restore the old value now. The bump has already committed, pushed, and created the PR on a new release branch, so we amend the commit and force push. This is safe because the release branch was just created.
+
+1. Change back to the repo root first (Step 4 left the working directory at `apps/desktop/`):
+   ```bash
+   cd ../..
+   ```
+2. Ensure you are on the `release/desktop/{NEW_VERSION}` branch (bump should have switched to it).
+3. Replace the recalculated mainHash with the saved old value in `apps/desktop/package.json`.
+4. Stage and amend the release commit:
+   ```bash
+   git add apps/desktop/package.json && git commit --amend --no-edit
+   ```
+5. Force push the release branch:
+   ```bash
+   git push --force origin release/desktop/{NEW_VERSION}
+   ```
+
+If Step 3 decided mainHash SHOULD be updated, skip this step entirely — the bump already wrote the correct new value.
+
+## Step 6: Verify
+
+1. Confirm the PR was created successfully by checking the output.
+2. Report the new version number and PR URL to the user.
+3. Summarize:
+   - New version: v{NEW_VERSION}
+   - mainHash updated: yes/no (and why)
+   - Changelog highlights
+   - PR URL
+
+## Reference
+
+- Bump config: `apps/desktop/bump.config.ts`
+- Changelog dir: `apps/desktop/changelog/`
+- Changelog template: `apps/desktop/changelog/next.template.md`
+- mainHash generator: `apps/desktop/plugins/vite/generate-main-hash.ts`
+- Hot updater logic: `apps/desktop/layer/main/src/updater/hot-updater.ts`
+- CI build workflow: `.github/workflows/build-desktop.yml`
+- Tag workflow: `.github/workflows/tag.yml`

apps/desktop/changelog/1.3.0.md

@@ -0,0 +1,16 @@
+# What's new in v1.3.0
+
+## Shiny new things
+
+- Markdown link supports open share feed link directly in the app
+
+## No longer broken
+
+- Fix preserve session when switching API domain
+- Fix handle invalid URL parsing in useFeedSafeUrl hook
+- Fix shortcuts page freeze
+- Fix icon service URL and image proxy URL
+
+## Thanks
+
+Special thanks to volunteer contributors @cuikaipeng @yjl9903 for their valuable contributions

apps/desktop/layer/main/src/lib/auth-cookie-migration.ts

@@ -0,0 +1,91 @@
+import type { Cookie, CookiesSetDetails, Session } from "electron"
+
+import { BETTER_AUTH_COOKIE_NAME_SESSION_TOKEN } from "~/constants/app"
+
+import { logger } from "../logger"
+
+const LEGACY_PROD_API_URL = "https://api.follow.is"
+const BETTER_AUTH_SESSION_DATA_COOKIE_NAME = "better-auth.session_data"
+
+const isBetterAuthSessionTokenCookie = (cookieName: string) => {
+  return cookieName.includes(BETTER_AUTH_COOKIE_NAME_SESSION_TOKEN)
+}
+
+const isBetterAuthSessionCookie = (cookieName: string) => {
+  return (
+    cookieName.includes(BETTER_AUTH_COOKIE_NAME_SESSION_TOKEN) ||
+    cookieName.includes(BETTER_AUTH_SESSION_DATA_COOKIE_NAME)
+  )
+}
+
+const toCookieSetDetails = (cookie: Cookie, url: string, domain: string): CookiesSetDetails => {
+  const details: CookiesSetDetails = {
+    url,
+    name: cookie.name,
+    value: cookie.value,
+    domain,
+    path: cookie.path,
+    secure: cookie.secure,
+    httpOnly: cookie.httpOnly,
+    sameSite: cookie.sameSite,
+  }
+
+  if (!cookie.session && cookie.expirationDate) {
+    details.expirationDate = cookie.expirationDate
+  }
+
+  return details
+}
+
+export const migrateAuthCookiesToNewApiDomain = async (
+  cookieSession: Session,
+  options: {
+    currentApiURL: string
+    legacyApiURL?: string
+  },
+) => {
+  const legacyApiURL = options.legacyApiURL ?? LEGACY_PROD_API_URL
+  if (!options.currentApiURL || options.currentApiURL === legacyApiURL) {
+    return
+  }
+
+  const currentHost = new URL(options.currentApiURL).hostname
+  const legacyHost = new URL(legacyApiURL).hostname
+
+  if (currentHost === legacyHost) {
+    return
+  }
+
+  const currentDomainCookies = await cookieSession.cookies.get({
+    domain: currentHost,
+  })
+  const hasCurrentDomainSessionTokenCookie = currentDomainCookies.some((cookie) =>
+    isBetterAuthSessionTokenCookie(cookie.name),
+  )
+  if (hasCurrentDomainSessionTokenCookie) {
+    return
+  }
+
+  const legacyDomainCookies = await cookieSession.cookies.get({
+    domain: legacyHost,
+  })
+  const legacySessionCookies = legacyDomainCookies.filter((cookie) =>
+    isBetterAuthSessionCookie(cookie.name),
+  )
+
+  if (legacySessionCookies.length === 0) {
+    return
+  }
+
+  await Promise.all(
+    legacySessionCookies.map((cookie) => {
+      return cookieSession.cookies.set(
+        toCookieSetDetails(cookie, options.currentApiURL, currentHost),
+      )
+    }),
+  )
+
+  logger.info(
+    `Migrated ${legacySessionCookies.length} auth cookie(s) from ${legacyHost} to ${currentHost}`,
+  )
+}

apps/desktop/layer/main/src/manager/bootstrap.ts

@@ -13,6 +13,7 @@ import { join } from "pathe"
 import { WindowManager } from "~/manager/window"
 
 import { isMacOS } from "../env"
+import { migrateAuthCookiesToNewApiDomain } from "../lib/auth-cookie-migration"
 import { handleUrlRouting } from "../lib/router"
 import { store } from "../lib/store"
 import { updateNotificationsToken } from "../lib/user"
@@ -81,6 +82,10 @@ export class BootstrapManager {
         callback({ cancel: false, requestHeaders: details.requestHeaders })
       })
 
+      await migrateAuthCookiesToNewApiDomain(session.defaultSession, {
+        currentApiURL: env.VITE_API_URL,
+      })
+
       // Bypass CORS for PostHog analytics
       session.defaultSession.webRequest.onHeadersReceived((details, callback) => {
         const url = new URL(details.url)

apps/desktop/layer/renderer/src/components/ui/markdown/renderers/MarkdownLink.tsx

@@ -7,11 +7,15 @@ import {
   TooltipTrigger,
 } from "@follow/components/ui/tooltip/index.jsx"
 import { useCorrectZIndex } from "@follow/components/ui/z-index/ctx.js"
-import { cn, stopPropagation } from "@follow/utils"
+import { env } from "@follow/shared/env.desktop"
+import { feedSyncServices } from "@follow/store/feed/store"
+import { cn, parseSafeUrl, stopPropagation } from "@follow/utils"
+import type { MouseEvent } from "react"
 import { use, useCallback } from "react"
 import { useTranslation } from "react-i18next"
 import { toast } from "sonner"
 
+import { navigateEntry } from "~/hooks/biz/useNavigateEntry"
 import { copyToClipboard } from "~/lib/clipboard"
 
 import { MarkdownRenderActionContext } from "../context"
@@ -21,6 +25,7 @@ export const MarkdownLink: Component<LinkProps> = (props) => {
   const { t } = useTranslation()
 
   const populatedFullHref = transformUrl(props.href)
+  const shareFeedInfo = parseShareFeedInfo(populatedFullHref)
 
   const handleCopyLink = useCallback(async () => {
     try {
@@ -34,6 +39,25 @@ export const MarkdownLink: Component<LinkProps> = (props) => {
     }
   }, [populatedFullHref, t])
 
+  const handleClickLink = useCallback(
+    async (event: MouseEvent<HTMLAnchorElement>) => {
+      stopPropagation(event)
+
+      if (!shareFeedInfo) {
+        return
+      }
+      event.preventDefault()
+
+      const view = await resolveShareFeedView(shareFeedInfo)
+      navigateEntry({
+        feedId: shareFeedInfo.id,
+        entryId: null,
+        view,
+      })
+    },
+    [shareFeedInfo],
+  )
+
   const parseTimeStamp = isAudio(populatedFullHref)
   const zIndex = useCorrectZIndex(0)
   if (parseTimeStamp) {
@@ -58,7 +82,7 @@ export const MarkdownLink: Component<LinkProps> = (props) => {
           title={props.title}
           target="_blank"
           rel="noreferrer"
-          onClick={stopPropagation}
+          onClick={handleClickLink}
         >
           {props.children}
 
@@ -93,3 +117,46 @@ export const MarkdownLink: Component<LinkProps> = (props) => {
     </Tooltip>
   )
 }
+
+const parseShareFeedInfo = (href?: string) => {
+  if (!href) return null
+
+  const baseUrl = parseSafeUrl(env.VITE_WEB_URL)
+  if (!baseUrl) return null
+
+  let parsedUrl: URL
+  try {
+    parsedUrl = new URL(href, baseUrl)
+  } catch {
+    return null
+  }
+
+  if (parsedUrl.host !== baseUrl.host) return null
+
+  const pathParts = parsedUrl.pathname.split("/").filter(Boolean)
+  if (pathParts.length !== 3 || pathParts[0] !== "share" || pathParts[1] !== "feeds") {
+    return null
+  }
+
+  const viewParam = parsedUrl.searchParams.get("view")
+  const view = viewParam ? Number.parseInt(viewParam, 10) : undefined
+
+  return {
+    id: pathParts[2]!,
+    view: Number.isNaN(view) ? undefined : view,
+  }
+}
+
+const resolveShareFeedView = async (info: { id: string; view?: number }) => {
+  if (typeof info.view === "number") {
+    return info.view
+  }
+
+  const data = await feedSyncServices.fetchFeedById({ id: info.id }).catch(() => {})
+  const analyticsView = data?.analytics?.view
+  if (typeof analyticsView === "number") {
+    return analyticsView
+  }
+
+  return 0
+}

apps/desktop/layer/renderer/src/hooks/common/useFeedSafeUrl.ts

@@ -31,8 +31,12 @@ export const useFeedSafeUrl = (entryId: string) => {
     }
 
     if (href.startsWith("http")) {
-      const domain = new URL(href).hostname
-      if (domain === "localhost") return null
+      try {
+        const domain = new URL(href).hostname
+        if (domain === "localhost") return null
+      } catch {
+        return null
+      }
 
       return href
     }