refactor: remove checkNew timeline update detection logic (#4817)

Remove the checkNew query and related state management that periodically checked for new entries in the timeline. The hasUpdate state and related UI indication (refresh button highlighting) have been removed while preserving fetchedTime for mark-all-read filtering.

Author: DIYgod

apps/desktop/layer/renderer/src/modules/entry-column/context/EntriesContext.tsx

@@ -15,7 +15,6 @@ type EntriesStateContextValue = {
   isLoading: boolean
   error: unknown | null
   view: FeedViewType
-  hasUpdate: boolean
   fetchedTime?: number
 }
 
@@ -112,7 +111,6 @@ export const EntriesProvider: React.FC<React.PropsWithChildren> = ({ children })
       isLoading: entries.isLoading,
       error: entries.error ?? null,
       view: view!,
-      hasUpdate: entries.hasUpdate,
       fetchedTime: entries.fetchedTime,
     }),
     [entries, view, syncType],

apps/desktop/layer/renderer/src/modules/entry-column/hooks/useEntriesByView.ts

@@ -25,8 +25,6 @@ import { useGeneralSettingKey } from "~/atoms/settings/general"
 import { ROUTE_FEED_PENDING } from "~/constants/app"
 import { useFeature } from "~/hooks/biz/useFeature"
 import { useRouteParams } from "~/hooks/biz/useRouteParams"
-import { useAuthQuery } from "~/hooks/common"
-import { entries } from "~/queries/entries"
 
 import { aiTimelineEnabledAtom } from "../atoms/ai-timeline"
 import { useIsPreviewFeed } from "./useIsPreviewFeed"
@@ -87,27 +85,6 @@ const useRemoteEntries = (): UseEntriesReturn => {
     }
   }, [query.isFetching])
 
-  const [pauseQuery, setPauseQuery] = useState(false)
-  const hasNewQuery = useAuthQuery(
-    entries.checkNew({
-      ...entriesOptions,
-      fetchedTime: fetchedTime!,
-    }),
-    {
-      refetchInterval: 1000 * 60 * 5,
-      enabled: !!fetchedTime && !pauseQuery,
-      notifyOnChangeProps: ["data"],
-    },
-  )
-  const hasUpdate = useMemo(
-    () => !!(fetchedTime && hasNewQuery?.data?.data?.has_new),
-    [hasNewQuery?.data?.data?.has_new, fetchedTime],
-  )
-
-  useEffect(() => {
-    setPauseQuery(hasUpdate)
-  }, [hasUpdate])
-
   const refetch = useCallback(async () => void query.refetch(), [query])
   const fetchNextPage = useCallback(async () => void query.fetchNextPage(), [query])
 
@@ -117,7 +94,6 @@ const useRemoteEntries = (): UseEntriesReturn => {
   return {
     entriesIds: query.entriesIds,
     hasNext: query.hasNextPage,
-    hasUpdate,
     refetch,
 
     fetchNextPage,
@@ -234,7 +210,6 @@ const useLocalEntries = (): UseEntriesReturn => {
   return {
     entriesIds: entries,
     hasNext,
-    hasUpdate: false,
     refetch,
     fetchNextPage: fetchNextPage as () => Promise<void>,
     isLoading: false,
@@ -312,7 +287,6 @@ export const useEntriesByView = ({ onReset }: { onReset?: () => void }) => {
     ...query,
 
     type: remoteQuery.isReady ? ("remote" as const) : ("local" as const),
-    hasUpdate: query.hasUpdate,
     refetch: useCallback(() => {
       const promise = query.refetch()
       unreadSyncService.resetFromRemote()

apps/desktop/layer/renderer/src/modules/entry-column/hooks/useLocalEntries.ts

@@ -131,7 +131,6 @@ export const useLocalEntries = ({
   return {
     entriesIds: entries,
     hasNext,
-    hasUpdate: false,
     refetch,
     fetchNextPage,
     isLoading: false,

apps/desktop/layer/renderer/src/modules/entry-column/index.tsx

@@ -166,11 +166,7 @@ function EntryColumnContent() {
         !state.error &&
         (!feed || feed?.type === "feed") && <AddFeedHelper />}
 
-      <EntryListHeader
-        refetch={actions.refetch}
-        isRefreshing={isRefreshing}
-        hasUpdate={state.hasUpdate}
-      />
+      <EntryListHeader refetch={actions.refetch} isRefreshing={isRefreshing} />
 
       <EntryColumnWrapper onScroll={handleCombinedScroll} key={`${routeFeedId}-${view}`}>
         {entriesIds.length === 0 ? (

apps/desktop/layer/renderer/src/modules/entry-column/layouts/EntryListHeader.tsx

@@ -43,8 +43,7 @@ import { SwitchToMasonryButton } from "./buttons/SwitchToMasonryButton"
 export const EntryListHeader: FC<{
   refetch: () => void
   isRefreshing: boolean
-  hasUpdate: boolean
-}> = ({ refetch, isRefreshing, hasUpdate }) => {
+}> = ({ refetch, isRefreshing }) => {
   const routerParams = useRouteParams()
   const { t } = useTranslation()
 
@@ -196,19 +195,12 @@ export const EntryListHeader: FC<{
                 </ActionButton>
               ) : (
                 <ActionButton
-                  tooltip={
-                    hasUpdate
-                      ? t("entry_list_header.new_entries_available")
-                      : t("entry_list_header.refetch")
-                  }
+                  tooltip={t("entry_list_header.refetch")}
                   onClick={() => {
                     refetch()
                   }}
                 >
-                  <RotatingRefreshIcon
-                    className={cn(hasUpdate && "text-accent")}
-                    isRefreshing={isRefreshing}
-                  />
+                  <RotatingRefreshIcon isRefreshing={isRefreshing} />
                 </ActionButton>
               ))}
             {!isCollection && (

apps/desktop/layer/renderer/src/queries/entries.ts

@@ -1,6 +1,5 @@
 import { followClient } from "~/lib/api-client"
 import { defineQuery } from "~/lib/defineQuery"
-import { getEntriesParams } from "~/lib/utils"
 
 export const entries = {
   preview: (id: string) =>
@@ -17,51 +16,4 @@ export const entries = {
         rootKey: ["entries-preview"],
       },
     ),
-
-  checkNew: ({
-    feedId,
-    inboxId,
-    listId,
-    view,
-    read,
-    fetchedTime,
-  }: {
-    feedId?: number | string
-    inboxId?: number | string
-    listId?: number | string
-    view?: number
-    read?: boolean
-    fetchedTime: number
-  }) =>
-    defineQuery(
-      ["entry-checkNew", inboxId || listId || feedId, view, read, fetchedTime],
-      async () => {
-        const query = {
-          ...getEntriesParams({
-            feedId,
-            inboxId,
-            listId,
-            view,
-          }),
-          read,
-          insertedAfter: fetchedTime,
-        }
-
-        if (query.feedIdList && query.feedIdList.length === 1) {
-          query.feedId = query.feedIdList[0]
-          delete query.feedIdList
-        }
-        return followClient.api.entries.checkNew({
-          insertedAfter: query.insertedAfter,
-          view: query.view,
-          feedId: query.feedId,
-          read: typeof query.read === "boolean" ? query.read : undefined,
-          feedIdList: query.feedIdList,
-        })
-      },
-
-      {
-        rootKey: ["entry-checkNew", inboxId || listId || feedId],
-      },
-    ),
 }

apps/mobile/src/modules/screen/atoms.ts

@@ -186,7 +186,6 @@ function useRemoteEntries(props?: UseEntriesProps): UseEntriesReturn {
   return {
     entriesIds: query.entriesIds,
     hasNext: query.hasNextPage,
-    hasUpdate: false,
     refetch,
     fetchNextPage,
     isLoading: query.isFetching,
@@ -299,7 +298,6 @@ function useLocalEntries(props?: UseEntriesProps): UseEntriesReturn {
   return {
     entriesIds: entries,
     hasNext,
-    hasUpdate: false,
     refetch,
     fetchNextPage,
     isLoading: false,

locales/app/en.json

@@ -201,7 +201,6 @@
   "entry_list_header.items": "items",
   "entry_list_header.masonry": "Masonry",
   "entry_list_header.masonry_column": "Masonry Column",
-  "entry_list_header.new_entries_available": "New entries available",
   "entry_list_header.preview_mode": "Preview Mode",
   "entry_list_header.refetch": "Refetch",
   "entry_list_header.refresh": "Refresh",

locales/app/ja.json

@@ -200,7 +200,6 @@
   "entry_list_header.items": "項目",
   "entry_list_header.masonry": "メイソンリー",
   "entry_list_header.masonry_column": "メイソンリー列",
-  "entry_list_header.new_entries_available": "新しいエントリーが利用可能です",
   "entry_list_header.preview_mode": "プレビューモード",
   "entry_list_header.refetch": "再取得",
   "entry_list_header.refresh": "更新",

locales/app/zh-CN.json

@@ -200,7 +200,6 @@
   "entry_list_header.items": "内容",
   "entry_list_header.masonry": "瀑布流布局",
   "entry_list_header.masonry_column": "布局列数",
-  "entry_list_header.new_entries_available": "有新内容",
   "entry_list_header.preview_mode": "预览模式",
   "entry_list_header.refetch": "刷新",
   "entry_list_header.refresh": "刷新",