Merge pull request #118 from luhuadong/develop

[BC28] optimize bc28 class functions

Author: Lawlieta

class/bc28/at_device_bc28.c

@@ -66,6 +66,7 @@ static int bc28_check_link_status(struct at_device *device)
     int result = -RT_ERROR;
 
     bc28 = (struct at_device_bc28 *)device->user_data;
+
     if ( ! bc28->power_status) // power off
     {
         LOG_E("the power is off.");
@@ -181,7 +182,6 @@ static int bc28_netdev_set_info(struct netdev *netdev)
 
     /* set network interface device IP address */
     {
-        #define IP_ADDR_SIZE_MAX    16
         char ipaddr[IP_ADDR_SIZE_MAX] = {0};
 
         /* send "AT+CGPADDR" commond to get IP address */
@@ -376,9 +376,7 @@ static int bc28_netdev_set_dns_server(struct netdev *netdev, uint8_t dns_num, ip
         goto __exit;
     }
 
-    /* send "AT+QIDNSCFG=<pri_dns>[,<sec_dns>]" commond to set dns servers */
-    if (at_obj_exec_cmd(device->client, resp, "AT+QIDNSCFG=%d,%s", 
-        dns_num, inet_ntoa(*dns_server)) != RT_EOK)
+    if (at_obj_exec_cmd(device->client, resp, "AT+QIDNSCFG=%s", inet_ntoa(*dns_server)) != RT_EOK)
     {
         result = -RT_ERROR;
         goto __exit;
@@ -439,7 +437,11 @@ static int bc28_netdev_ping(struct netdev *netdev, const char *host,
 #ifdef AT_USING_SOCKET
     else
     {
-        bc28_domain_resolve(host, ip_addr);
+        if(0 > bc28_domain_resolve(host, ip_addr))
+        {
+            LOG_E("can not resolve domain");
+            goto __exit;
+        }
     }
 #endif
 
@@ -613,8 +615,8 @@ static void bc28_init_thread_entry(void *parameter)
             goto __exit;
         }
 
-        /* search band 8 */
-        if (at_obj_exec_cmd(device->client, resp, "AT+NBAND=8") != RT_EOK)
+        /* search band */
+        if (at_obj_exec_cmd(device->client, resp, "AT+NBAND=%d", AT_DEVICE_BC28_OP_BAND) != RT_EOK)
         {
             result = -RT_ERROR;
             LOG_E(">> AT+NBAND=8");
@@ -765,7 +767,6 @@ static void bc28_init_thread_entry(void *parameter)
             rt_thread_mdelay(1000);
             if (at_obj_exec_cmd(device->client, resp, "AT+CGPADDR") == RT_EOK)
             {
-                #define IP_ADDR_SIZE_MAX    16
                 char ipaddr[IP_ADDR_SIZE_MAX] = {0};
 
                 /* parse response data "+CGPADDR: 0,<IP_address>" */
@@ -849,6 +850,19 @@ static int bc28_init(struct at_device *device)
 {
     struct at_device_bc28 *bc28 = (struct at_device_bc28 *)device->user_data;
 
+    /* configure AT client */
+    rt_device_t serial = rt_device_find(bc28->client_name);
+    struct serial_configure config = RT_SERIAL_CONFIG_DEFAULT;
+
+    config.baud_rate = BC28_AT_CLIENT_BAUD_RATE;
+    config.data_bits = DATA_BITS_8;
+    config.stop_bits = STOP_BITS_1;
+    config.bufsz     = bc28->recv_bufsz;
+    config.parity    = PARITY_NONE;
+
+    rt_device_control(serial, RT_DEVICE_CTRL_CONFIG, &config);
+    rt_device_close(serial);
+
     /* initialize AT client */
     at_client_init(bc28->client_name, bc28->recv_bufsz);
 
@@ -950,4 +964,4 @@ static int bc28_device_class_register(void)
 }
 INIT_DEVICE_EXPORT(bc28_device_class_register);
 
-#endif /* AT_DEVICE_USING_BC28 */
+#endif /* AT_DEVICE_USING_BC28 */

class/bc28/at_device_bc28.h

@@ -35,6 +35,10 @@ extern "C" {
 
 /* The maximum number of sockets supported by the BC28 device */
 #define AT_DEVICE_BC28_SOCKETS_NUM  7
+#define IP_ADDR_SIZE_MAX            16
+
+#define AT_DEVICE_BC28_MIN_SOCKET   BC28_SAMPLE_MIN_SOCKET
+#define BC28_AT_CLIENT_BAUD_RATE    BC28_SAMPLE_BAUD_RATE
 
 struct at_device_bc28
 {