[components][smp]remove redundant memset & unlock in smp

zmshahaha · web-flow · commit 344ea873477f · 2024-10-11T00:09:28.000-04:00
diff --git a/components/drivers/smp/smp.c b/components/drivers/smp/smp.c
@@ -33,18 +33,14 @@ static rt_err_t smp_call_handler(struct rt_smp_event *event)
 }
 void rt_smp_call_ipi_handler(int vector, void *param)
 {
-    int err;
     int cur_cpu = rt_hw_cpu_id();
-    rt_spin_lock(&rt_smp_work[cur_cpu].lock);
 
+    rt_spin_lock(&rt_smp_work[cur_cpu].lock);
     if (rt_smp_work[cur_cpu].event.event_id)
     {
-        err = smp_call_handler(&rt_smp_work[cur_cpu].event);
-        if (err)
+        if (smp_call_handler(&rt_smp_work[cur_cpu].event) != RT_EOK)
         {
             LOG_E("Have no event\n");
-            rt_memset(&rt_smp_work[cur_cpu].event, 0, sizeof(struct rt_smp_event));
-            rt_spin_unlock(&rt_smp_work[cur_cpu].lock);
         }
         rt_memset(&rt_smp_work[cur_cpu].event, 0, sizeof(struct rt_smp_event));
     }

Original file line number	Diff line number	Diff line change
`@@ -33,18 +33,14 @@ static rt_err_t smp_call_handler(struct rt_smp_event *event)`
`33`	`33`	`}`
`34`	`34`	`void rt_smp_call_ipi_handler(int vector, void *param)`
`35`	`35`	`{`
`36`		`- int err;`
`37`	`36`	`int cur_cpu = rt_hw_cpu_id();`
`38`		`- rt_spin_lock(&rt_smp_work[cur_cpu].lock);`
`39`	`37`
	`38`	`+ rt_spin_lock(&rt_smp_work[cur_cpu].lock);`
`40`	`39`	`if (rt_smp_work[cur_cpu].event.event_id)`
`41`	`40`	`{`
`42`		`- err = smp_call_handler(&rt_smp_work[cur_cpu].event);`
`43`		`- if (err)`
	`41`	`+ if (smp_call_handler(&rt_smp_work[cur_cpu].event) != RT_EOK)`
`44`	`42`	`{`
`45`	`43`	`LOG_E("Have no event\n");`
`46`		`- rt_memset(&rt_smp_work[cur_cpu].event, 0, sizeof(struct rt_smp_event));`
`47`		`- rt_spin_unlock(&rt_smp_work[cur_cpu].lock);`
`48`	`44`	`}`
`49`	`45`	`rt_memset(&rt_smp_work[cur_cpu].event, 0, sizeof(struct rt_smp_event));`
`50`	`46`	`}`