Skip to content

Commit 46b0b49

Browse files
committed
[Driver][MISC][ADC] Fixup ADC
1. Fixup error no. 2. Fixup type of control for args. 3. Fixup value no init. Signed-off-by: GuEe-GUI <[email protected]>
1 parent a774ea7 commit 46b0b49

File tree

1 file changed

+5
-4
lines changed
  • components/drivers/misc

1 file changed

+5
-4
lines changed

components/drivers/misc/adc.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,16 @@ static rt_ssize_t _adc_read(rt_device_t dev, rt_off_t pos, void *buffer, rt_size
4343
static rt_err_t _adc_control(rt_device_t dev, int cmd, void *args)
4444
{
4545
rt_adc_device_t adc = (struct rt_adc_device *)dev;
46-
rt_err_t result = RT_ERROR;
46+
rt_err_t result = -RT_EINVAL;
47+
4748

4849
if (cmd == RT_ADC_CMD_ENABLE && adc->ops->enabled)
4950
{
50-
result = adc->ops->enabled(adc, (rt_int8_t)(rt_base_t)args, RT_TRUE);
51+
result = adc->ops->enabled(adc, (rt_uint32_t)(rt_ubase_t)args, RT_TRUE);
5152
}
5253
else if (cmd == RT_ADC_CMD_DISABLE && adc->ops->enabled)
5354
{
54-
result = adc->ops->enabled(adc, (rt_int8_t)(rt_base_t)args, RT_FALSE);
55+
result = adc->ops->enabled(adc, (rt_uint32_t)(rt_ubase_t)args, RT_FALSE);
5556
}
5657
else if (cmd == RT_ADC_CMD_GET_RESOLUTION && adc->ops->get_resolution && args)
5758
{
@@ -167,7 +168,7 @@ rt_int16_t rt_adc_voltage(rt_adc_device_t dev, rt_int8_t channel)
167168
RT_ASSERT(dev);
168169

169170
rt_uint32_t value;
170-
rt_int16_t vref, voltage;
171+
rt_int16_t vref, voltage = 0;
171172
rt_uint8_t resolution;
172173
rt_err_t result;
173174

0 commit comments

Comments
 (0)