@@ -325,13 +325,13 @@ static rt_err_t _can_control(struct rt_can_device *can, int cmd, void *arg)
325325 * STD ID | STID[10:3] | STDID[2:0] |<- 21bit ->|
326326 * EXT ID | EXTID[28:21] | EXTID[20:13] | EXTID[12:5] | EXTID[4:0] IDE RTR 0|
327327 * @note the 32bit STD ID must << 21 to fill CAN_FxR1[31:21] and EXT ID must << 3,
328- * -> but the id bit of struct rt_can_filter_item is 29,
328+ * -> but the id bit of struct rt_can_filter_item is 29,
329329 * -> so STD id << 18 and EXT id Don't need << 3, when get the high 16bit.
330330 * -> FilterIdHigh : (((STDid << 18) or (EXT id)) >> 13) & 0xFFFF,
331- * -> FilterIdLow: ((STDid << 18) or (EXT id << 3)) & 0xFFFF.
332- * @note the mask bit of struct rt_can_filter_item is 32,
333- * -> FilterMaskIdHigh: (((STD mask << 21) or (EXT mask <<3)) >> 16) & 0xFFFF
334- * -> FilterMaskIdLow: ((STD mask << 21) or (EXT mask <<3)) & 0xFFFF
331+ * -> FilterIdLow: ((STDid << 18) or (EXT id << 3)) & 0xFFFF.
332+ * @note the mask bit of struct rt_can_filter_item is 32,
333+ * -> FilterMaskIdHigh: (((STD mask << 21) or (EXT mask <<3)) >> 16) & 0xFFFF
334+ * -> FilterMaskIdLow: ((STD mask << 21) or (EXT mask <<3)) & 0xFFFF
335335 */
336336 if (filter_cfg -> items [i ].mode == CAN_FILTERMODE_IDMASK )
337337 {
@@ -341,23 +341,23 @@ static rt_err_t _can_control(struct rt_can_device *can, int cmd, void *arg)
341341 else if (filter_cfg -> items [i ].mode == CAN_FILTERMODE_IDLIST )
342342 {
343343 /* same as CAN_FxR1 */
344- mask_l_tail = (filter_cfg -> items [i ].ide << 2 ) |
344+ mask_l_tail = (filter_cfg -> items [i ].ide << 2 ) |
345345 (filter_cfg -> items [i ].rtr << 1 );
346346 }
347347 if (filter_cfg -> items [i ].ide == RT_CAN_STDID )
348348 {
349349 id_h = ((filter_cfg -> items [i ].id << 18 ) >> 13 ) & 0xFFFF ;
350- id_l = ((filter_cfg -> items [i ].id << 18 ) |
351- (filter_cfg -> items [i ].ide << 2 ) |
350+ id_l = ((filter_cfg -> items [i ].id << 18 ) |
351+ (filter_cfg -> items [i ].ide << 2 ) |
352352 (filter_cfg -> items [i ].rtr << 1 )) & 0xFFFF ;
353353 mask_h = ((filter_cfg -> items [i ].mask << 21 ) >> 16 ) & 0xFFFF ;
354354 mask_l = ((filter_cfg -> items [i ].mask << 21 ) | mask_l_tail ) & 0xFFFF ;
355355 }
356356 else if (filter_cfg -> items [i ].ide == RT_CAN_EXTID )
357357 {
358358 id_h = (filter_cfg -> items [i ].id >> 13 ) & 0xFFFF ;
359- id_l = ((filter_cfg -> items [i ].id << 3 ) |
360- (filter_cfg -> items [i ].ide << 2 ) |
359+ id_l = ((filter_cfg -> items [i ].id << 3 ) |
360+ (filter_cfg -> items [i ].ide << 2 ) |
361361 (filter_cfg -> items [i ].rtr << 1 )) & 0xFFFF ;
362362 mask_h = ((filter_cfg -> items [i ].mask << 3 ) >> 16 ) & 0xFFFF ;
363363 mask_l = ((filter_cfg -> items [i ].mask << 3 ) | mask_l_tail ) & 0xFFFF ;
0 commit comments