fix: add \n for addr2line hint

mysterywolf · mysterywolf · commit 97b9cc50000b · 2025-01-08T17:54:46.000-05:00
diff --git a/components/lwp/lwp.c b/components/lwp/lwp.c
@@ -583,12 +583,12 @@ rt_err_t lwp_backtrace_frame(rt_thread_t uthread, struct rt_hw_backtrace_frame *
         argv = lwp_get_command_line_args(lwp);
         if (argv)
         {
-            rt_kprintf("please use: addr2line -e %s -a -f", argv[0]);
+            rt_kprintf("please use: addr2line -e %s -a -f\n", argv[0]);
             lwp_free_command_line_args(argv);
         }
         else
         {
-            rt_kprintf("please use: addr2line -e %s -a -f", lwp->cmd);
+            rt_kprintf("please use: addr2line -e %s -a -f\n", lwp->cmd);
         }
 
         while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)
diff --git a/libcpu/arm/cortex-a/backtrace.c b/libcpu/arm/cortex-a/backtrace.c
@@ -489,7 +489,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
     arm_get_current_stackframe(regs, &frame);
 
 #ifndef RT_BACKTRACE_FUNCTION_NAME
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
 #endif
     LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);
 
diff --git a/libcpu/arm/cortex-r52/backtrace.c b/libcpu/arm/cortex-r52/backtrace.c
@@ -490,7 +490,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
     arm_get_current_stackframe(regs, &frame);
 
 #ifndef RT_BACKTRACE_FUNCTION_NAME
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
 #endif
     LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);
 
diff --git a/src/kservice.c b/src/kservice.c
@@ -417,7 +417,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
 {
     long nesting = 0;
 
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");
 
     while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)
     {
@@ -441,7 +441,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
  */
 rt_weak rt_err_t rt_backtrace_formatted_print(rt_ubase_t *buffer, long buflen)
 {
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");
 
     for (rt_size_t i = 0; i < buflen && buffer[i] != 0; i++)
     {

Original file line number	Diff line number	Diff line change
`@@ -583,12 +583,12 @@ rt_err_t lwp_backtrace_frame(rt_thread_t uthread, struct rt_hw_backtrace_frame *`
`583`	`583`	`argv = lwp_get_command_line_args(lwp);`
`584`	`584`	`if (argv)`
`585`	`585`	`{`
`586`		`- rt_kprintf("please use: addr2line -e %s -a -f", argv[0]);`
	`586`	`+ rt_kprintf("please use: addr2line -e %s -a -f\n", argv[0]);`
`587`	`587`	`lwp_free_command_line_args(argv);`
`588`	`588`	`}`
`589`	`589`	`else`
`590`	`590`	`{`
`591`		`- rt_kprintf("please use: addr2line -e %s -a -f", lwp->cmd);`
	`591`	`+ rt_kprintf("please use: addr2line -e %s -a -f\n", lwp->cmd);`
`592`	`592`	`}`
`593`	`593`
`594`	`594`	`while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)`
Original file line number	Diff line number	Diff line change
`@@ -417,7 +417,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f`
`417`	`417`	`{`
`418`	`418`	`long nesting = 0;`
`419`	`419`
`420`		`- rt_kprintf("please use: addr2line -e rtthread.elf -a -f");`
	`420`	`+ rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");`
`421`	`421`
`422`	`422`	`while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)`
`423`	`423`	`{`
`@@ -441,7 +441,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f`
`441`	`441`	`*/`
`442`	`442`	`rt_weak rt_err_t rt_backtrace_formatted_print(rt_ubase_t *buffer, long buflen)`
`443`	`443`	`{`
`444`		`- rt_kprintf("please use: addr2line -e rtthread.elf -a -f");`
	`444`	`+ rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");`
`445`	`445`
`446`	`446`	`for (rt_size_t i = 0; i < buflen && buffer[i] != 0; i++)`
`447`	`447`	`{`