[bsp] 修改 PR 审核意见~

Author: lza1205

bsp/gd32105c-eval/JLinkLog.txt

@@ -219,7 +219,7 @@ const struct pin_index *get_pin(rt_uint8_t pin)
     return index;
 };
 
-void gd32_pin_mode(rt_device_t dev, rt_base_t pin, rt_base_t mode)
+static void _pin_mode(rt_device_t dev, rt_base_t pin, rt_base_t mode)
 {
     const struct pin_index *index;
     rt_uint32_t pin_mode;
@@ -262,7 +262,7 @@ void gd32_pin_mode(rt_device_t dev, rt_base_t pin, rt_base_t mode)
     gpio_init(index->gpio_periph, pin_mode, GPIO_OSPEED_50MHZ, index->pin);
 }
 
-void gd32_pin_write(rt_device_t dev, rt_base_t pin, rt_base_t value)
+static void _pin_write(rt_device_t dev, rt_base_t pin, rt_base_t value)
 {
     const struct pin_index *index;
 
@@ -275,7 +275,7 @@ void gd32_pin_write(rt_device_t dev, rt_base_t pin, rt_base_t value)
     gpio_bit_write(index->gpio_periph, index->pin, (bit_status)value);
 }
 
-int gd32_pin_read(rt_device_t dev, rt_base_t pin)
+static int _pin_read(rt_device_t dev, rt_base_t pin)
 {
     int value;
     const struct pin_index *index;
@@ -315,7 +315,7 @@ rt_inline const struct pin_irq_map *get_pin_irq_map(rt_uint32_t pinbit)
     }
     return &pin_irq_map[mapindex];
 };
-rt_err_t gd32_pin_attach_irq(struct rt_device *device, rt_int32_t pin,
+static rt_err_t _pin_attach_irq(struct rt_device *device, rt_int32_t pin,
                               rt_uint32_t mode, void (*hdr)(void *args), void *args)
 {
     const struct pin_index *index;
@@ -355,7 +355,7 @@ rt_err_t gd32_pin_attach_irq(struct rt_device *device, rt_int32_t pin,
 
     return RT_EOK;
 }
-rt_err_t gd32_pin_detach_irq(struct rt_device *device, rt_int32_t pin)
+static rt_err_t _pin_detach_irq(struct rt_device *device, rt_int32_t pin)
 {
     const struct pin_index *index;
     rt_base_t level;
@@ -386,7 +386,7 @@ rt_err_t gd32_pin_detach_irq(struct rt_device *device, rt_int32_t pin)
 
     return RT_EOK;
 }
-rt_err_t gd32_pin_irq_enable(struct rt_device *device, rt_base_t pin, rt_uint32_t enabled)
+static rt_err_t _pin_irq_enable(struct rt_device *device, rt_base_t pin, rt_uint32_t enabled)
 {
     const struct pin_index *index;
     const struct pin_irq_map *irqmap;
@@ -462,12 +462,12 @@ rt_err_t gd32_pin_irq_enable(struct rt_device *device, rt_base_t pin, rt_uint32_
 }
 const static struct rt_pin_ops _gd32_pin_ops =
 {
-    gd32_pin_mode,
-    gd32_pin_write,
-    gd32_pin_read,
-    gd32_pin_attach_irq,
-    gd32_pin_detach_irq,
-    gd32_pin_irq_enable,
+    _pin_mode,
+    _pin_write,
+    _pin_read,
+    _pin_attach_irq,
+    _pin_detach_irq,
+    _pin_irq_enable,
     RT_NULL,
 };
 

bsp/gd32105c-eval/JLinkSettings.ini

@@ -188,15 +188,15 @@ static rt_uint32_t xfer(struct rt_spi_device* device, struct rt_spi_message* mes
                     data = *send_ptr++;
                 }
 
-                // Todo: replace register read/write by gd32f3 lib
-                //Wait until the transmit buffer is empty
+                /* Todo: replace register read/write by gd32f3 lib */
+                /* Wait until the transmit buffer is empty */
                 while(RESET == spi_i2s_flag_get(spi_periph, SPI_FLAG_TBE));
-                // Send the byte
+                /* Send the byte */
                 spi_i2s_data_transmit(spi_periph, data);
 
-                //Wait until a data is received
+                /* Wait until a data is received */
                 while(RESET == spi_i2s_flag_get(spi_periph, SPI_FLAG_RBNE));
-                // Get the received data
+                /* Get the received data */
                 data = spi_i2s_data_receive(spi_periph);
 
                 if(recv_ptr != RT_NULL)
@@ -221,14 +221,14 @@ static rt_uint32_t xfer(struct rt_spi_device* device, struct rt_spi_message* mes
                     data = *send_ptr++;
                 }
 
-                //Wait until the transmit buffer is empty
+                /*Wait until the transmit buffer is empty */
                 while(RESET == spi_i2s_flag_get(spi_periph, SPI_FLAG_TBE));
-                // Send the byte
+                /* Send the byte */
                 spi_i2s_data_transmit(spi_periph, data);
 
-                //Wait until a data is received
+                /*Wait until a data is received */
                 while(RESET == spi_i2s_flag_get(spi_periph, SPI_FLAG_RBNE));
-                // Get the received data
+                /* Get the received data */
                 data = spi_i2s_data_receive(spi_periph);
 
                 if(recv_ptr != RT_NULL)

bsp/gd32105c-eval/gd32_rom.icf renamed to bsp/gd32105c-eval/board/linker_script/gd32_rom.icf

@@ -12,4 +12,4 @@
 #define gd32F30X_SPI_H_INCLUDED
 
 
-#endif // gd32F30X_SPI_H_INCLUDED
+#endif /* gd32F30X_SPI_H_INCLUDED */

bsp/gd32105c-eval/gd32_rom.ld renamed to bsp/gd32105c-eval/board/linker_script/gd32_rom.ld

@@ -16,7 +16,7 @@
 #define SPI_BUS_NAME                "spi0"
 #define SPI_DEVICE_NAME             "spi01"
 #define SPI_FLASH_DEVICE_NAME       "gd25q"
-#define GD25Q_SPI_CS_PIN             67          //PE3，在 drv_gpio.c 文件 pin_index pins[]中查到 PE3 编号为 2
+#define GD25Q_SPI_CS_PIN             67          /* PE3，在 drv_gpio.c 文件 pin_index pins[]中查到 PE3 编号为 67 */
 
 static int rt_hw_gd25q40_init(void)
 {