[lwp]对检查killpg的signo参数的有效性

heyuanjie87 · heyuanjie87 · commit b142f3776fdb · 2025-02-10T18:25:56.000+08:00
diff --git a/components/lwp/lwp_signal.c b/components/lwp/lwp_signal.c
@@ -27,6 +27,11 @@
 #include "sys/signal.h"
 #include "syscall_generic.h"
 
+rt_inline rt_err_t valid_signo_check(unsigned long sig)
+{
+	return sig <= _LWP_NSIG ? 0 : -RT_EINVAL;
+}
+
 static lwp_siginfo_t siginfo_create(rt_thread_t current, int signo, int code, lwp_siginfo_ext_t ext)
 {
     lwp_siginfo_t siginfo;
@@ -1432,7 +1437,8 @@ rt_err_t lwp_pgrp_signal_kill(rt_processgroup_t pgrp, long signo, long code,
 
     PGRP_ASSERT_LOCKED(pgrp);
 
-    if (pgrp)
+    rc = valid_signo_check(signo);
+    if (pgrp && !rc)
     {
         rt_list_for_each_entry(lwp, &pgrp->process, pgrp_node)
         {

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,11 @@`
`27`	`27`	`#include "sys/signal.h"`
`28`	`28`	`#include "syscall_generic.h"`
`29`	`29`
	`30`	`+rt_inline rt_err_t valid_signo_check(unsigned long sig)`
	`31`	`+{`
	`32`	`+ return sig <= _LWP_NSIG ? 0 : -RT_EINVAL;`
	`33`	`+}`
	`34`	`+`
`30`	`35`	`static lwp_siginfo_t siginfo_create(rt_thread_t current, int signo, int code, lwp_siginfo_ext_t ext)`
`31`	`36`	`{`
`32`	`37`	`lwp_siginfo_t siginfo;`
`@@ -1432,7 +1437,8 @@ rt_err_t lwp_pgrp_signal_kill(rt_processgroup_t pgrp, long signo, long code,`
`1432`	`1437`
`1433`	`1438`	`PGRP_ASSERT_LOCKED(pgrp);`
`1434`	`1439`
`1435`		`- if (pgrp)`
	`1440`	`+ rc = valid_signo_check(signo);`
	`1441`	`+ if (pgrp && !rc)`
`1436`	`1442`	`{`
`1437`	`1443`	`rt_list_for_each_entry(lwp, &pgrp->process, pgrp_node)`
`1438`	`1444`	`{`